Skip to content

Commit 82f568a

Browse files
authored
Merge pull request #3 from GeoNet/diskconfig-fix
fix: Missing property in DiskConfig.Clone()
2 parents a4a7922 + 2f88aa2 commit 82f568a

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

fs/fs.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ func (dc *DiskConfig) Clone() *DiskConfig {
8080
Name: dc.Name,
8181
Driver: dc.Driver,
8282
Root: dc.Root,
83+
PublicPath: dc.PublicPath,
8384
BaseURL: dc.BaseURL,
8485
GetBaseURL: dc.GetBaseURL,
8586
Provider: dc.Provider,

fs/fs_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ func TestDiskConfigClone(t *testing.T) {
1212
Name: "test",
1313
Driver: "test",
1414
Root: "test",
15+
PublicPath: "test",
1516
BaseURL: "test",
1617
GetBaseURL: func() string { return "test" },
1718
Provider: "test",
@@ -28,6 +29,7 @@ func TestDiskConfigClone(t *testing.T) {
2829
assert.Equal(t, dc.Name, clone.Name)
2930
assert.Equal(t, dc.Driver, clone.Driver)
3031
assert.Equal(t, dc.Root, clone.Root)
32+
assert.Equal(t, dc.PublicPath, clone.PublicPath)
3133
assert.Equal(t, dc.BaseURL, clone.BaseURL)
3234
assert.Equal(t, dc.GetBaseURL(), clone.GetBaseURL())
3335
assert.Equal(t, dc.Provider, clone.Provider)
@@ -55,6 +57,7 @@ func TestStorageConfigClone(t *testing.T) {
5557
Name: "test1",
5658
Driver: "test1",
5759
Root: "test1",
60+
PublicPath: "test1",
5861
BaseURL: "test1",
5962
GetBaseURL: func() string { return "test1" },
6063
Provider: "test1",
@@ -69,6 +72,7 @@ func TestStorageConfigClone(t *testing.T) {
6972
Name: "test2",
7073
Driver: "test2",
7174
Root: "test2",
75+
PublicPath: "test2",
7276
BaseURL: "test2",
7377
GetBaseURL: func() string { return "test2" },
7478
Provider: "test2",
@@ -90,6 +94,7 @@ func TestStorageConfigClone(t *testing.T) {
9094
assert.Equal(t, sc.Disks[i].Name, clone.Disks[i].Name)
9195
assert.Equal(t, sc.Disks[i].Driver, clone.Disks[i].Driver)
9296
assert.Equal(t, sc.Disks[i].Root, clone.Disks[i].Root)
97+
assert.Equal(t, sc.Disks[i].PublicPath, clone.Disks[i].PublicPath)
9398
assert.Equal(t, sc.Disks[i].BaseURL, clone.Disks[i].BaseURL)
9499
assert.Equal(t, sc.Disks[i].GetBaseURL(), clone.Disks[i].GetBaseURL())
95100
assert.Equal(t, sc.Disks[i].Provider, clone.Disks[i].Provider)

0 commit comments

Comments
 (0)