Skip to content

Commit 57d5393

Browse files
authored
GitHub Action Concurrency Failing To Cancel Irrelevant Runs (#247)
# Fix GitHub Action Group Concurrency ## Problem and Scope Rapidly pushing individual commits queues up massive amounts of runs that are not cancelled since concurrency groups blocking this are grouped with run IDs ## Description No longer group against run ids ## Gotchas and Limitations May take a little time to cancel ## Testing - [ ] HOOTL testing - [ ] HITL testing - [x] Human tested ### Testing Details Re-pushed off of 1d212d8 with 99a5712 and validated that it cancelled ## Larger Impact Pushing every commit no longer triggers up the same workload as it did before ## Additional Context and Ticket Resolves #246 Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
1 parent 6cb7bc7 commit 57d5393

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/AutoFormat.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55
pull_request:
66

77
concurrency:
8-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}-${{ github.run_id }}
8+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
99
cancel-in-progress: true
1010

1111
jobs:

.github/workflows/Linter.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
workflow_dispatch:
99

1010
concurrency:
11-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}-${{ github.run_id }}
11+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
1212
cancel-in-progress: true
1313

1414
jobs:

.github/workflows/UnitTestsHOOTL.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
workflow_dispatch:
99

1010
concurrency:
11-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}-${{ github.run_id }}
11+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
1212
cancel-in-progress: true
1313

1414
jobs:

0 commit comments

Comments
 (0)