Skip to content

ci(release): drop pnpm with.version so packageManager wins#176

Merged
GSTJ merged 2 commits into
mainfrom
fix/publish-pnpm-conflict
May 19, 2026
Merged

ci(release): drop pnpm with.version so packageManager wins#176
GSTJ merged 2 commits into
mainfrom
fix/publish-pnpm-conflict

Conversation

@GSTJ
Copy link
Copy Markdown
Owner

@GSTJ GSTJ commented May 19, 2026

Summary

Hotfix for the 🚀 Publish workflow on main, which has failed twice consecutively after PR #166 was merged (at 05:39 UTC).

The error is not an npm auth issue but a pnpm version conflict:

Error: Multiple versions of pnpm specified:
  - version 9 in the GitHub Action config with the key "version"
  - version pnpm@9.15.9 in the package.json with the key "packageManager"
Remove one of these versions to avoid version mismatch errors like ERR_PNPM_BAD_PM_VERSION

The prior orchestrator commit (479ad40) bumped pnpm/action-setup from v2/version: 8 to v4/version: 9 but left with.version in place, conflicting with packageManager: pnpm@9.15.9 in package.json.

This PR drops with.version entirely so packageManager wins — mirroring the successful fix applied to branch-validation.yml in commit fa0675c.

Test plan

  • Branch checkup CI passes
  • 🚀 Publish workflow succeeds on main after merge
  • npm view react-native-magic-modal version shows the new 7.x release

Copilot AI review requested due to automatic review settings May 19, 2026 06:17
@GSTJ GSTJ enabled auto-merge (squash) May 19, 2026 06:17
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the explicit version: 9 input from the pnpm/action-setup@v4 step in the publish workflow so the packageManager field in package.json (pnpm@9.15.9) is the sole source of truth, resolving the ERR_PNPM_BAD_PM_VERSION failure on main.

Changes:

  • Drop with.version: 9 from the Setup PNPM step in .github/workflows/release.yml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GSTJ GSTJ merged commit 510b192 into main May 19, 2026
3 checks passed
@GSTJ
Copy link
Copy Markdown
Owner Author

GSTJ commented May 19, 2026

Heads up — the Publish workflow downstream of this PR (run https://github.com/GSTJ/react-native-magic-modal/actions/runs/26082273487) failed at the npm publish step with HTTP 403.

Root cause: the current NPM_TOKEN secret is a token type that requires an interactive 2FA OTP at publish time, which CI can't provide.

Fix: rotate NPM_TOKEN to a Granular Access Token with Bypass 2FA for publishing enabled, scoped to the react-native-magic-modal package with write permission. Full step-by-step in the follow-up issue.

Also opened #179 to pre-stamp the version at 7.0.0 so the next publish run picks up the SDK 55 breaking-bump version verbatim (release-it was computing a patch because the most recent commits on main aren't feat!:).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants