Merge pull request #37 from FundingCircle/update-ruby-and-lint

Specify required_ruby_version >= 3.1.0 and run rubocop

Author: bliof-fc

.github/workflows/build-and-test.yml

@@ -31,7 +31,7 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 3.3
+          ruby-version: 3.4
           bundler-cache: true
 
       - name: Run tests

.github/workflows/publish-gem.yml

@@ -15,7 +15,7 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.3'
+          ruby-version: '3.4'
           bundler-cache: true
 
       - name: Build gem

.ruby-version

@@ -0,0 +1 @@
+3.4.2

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec

README.md

@@ -3,6 +3,7 @@
 Utility which will output a table containing gem versions used across your projects.
 
 [![Build & Test](https://github.com/FundingCircle/hellgrid/actions/workflows/build-and-test.yml/badge.svg)](https://github.com/FundingCircle/hellgrid/actions/workflows/build-and-test.yml)
+[![Gem Version](https://badge.fury.io/rb/hellgrid.svg)](https://badge.fury.io/rb/hellgrid)
 
 ## Install
 

bin/hellgrid

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'pathname'
 # XXX: BUNDLE_GEMFILE should be provided because the internals of bundler require a 'Gemfile' or '.bundle' to

exe/hellgrid

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'pathname'
 # XXX: BUNDLE_GEMFILE should be provided because the internals of bundler require a 'Gemfile' or '.bundle' to

hellgrid.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 project_root = File.dirname(__FILE__)
 lib = File.join(project_root, 'lib')
 
@@ -11,15 +13,23 @@ Gem::Specification.new do |s|
   s.description   = 'Display gem versions used across your projects in a table'
   s.authors       = ['Deyan Dobrinov', 'Aleksandar Ivanov']
   s.email         = ['engineering+hellgrid@fundingcircle.com']
-  s.files         = Dir.chdir(project_root) { Dir['lib/**/*.rb'] + Dir['bin/*'] + Dir['exe/*'] + Dir['spec/**/*.rb'] + %w(Gemfile Gemfile.lock README.md hellgrid.gemspec) }
+  s.files         = Dir.chdir(project_root) do
+    Dir['lib/**/*.rb'] +
+      Dir['bin/*'] +
+      Dir['exe/*'] +
+      Dir['spec/**/*.rb'] +
+      %w[Gemfile Gemfile.lock README.md hellgrid.gemspec]
+  end
   s.bindir        = 'exe'
-  s.executables   = s.files.grep(/^exe\//) { |f| File.basename(f) }
-  s.test_files    = s.files.grep(/^spec\//)
+  s.executables   = s.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  s.test_files    = s.files.grep(%r{^spec/})
   s.require_paths = ['lib']
   s.homepage      = 'https://github.com/FundingCircle/hellgrid'
   s.license       = 'BSD-3-Clause'
 
+  s.required_ruby_version = '>= 3.1.0'
+
   s.add_runtime_dependency 'bundler', '>= 1.11.0', '< 3'
 
-  s.add_development_dependency 'rspec', '~> 3.8.0'
+  s.add_development_dependency 'rspec', '~> 3.13'
 end

lib/hellgrid.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler'
 require 'find'
 require 'hellgrid/project'

lib/hellgrid/cli.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hellgrid
   class CLI
     def self.start(argv = ARGV)
@@ -11,8 +13,8 @@ def initialize(argv = ARGV)
     attr_reader :argv
 
     def start
-      recursive_search = !!(argv.delete('-r'))
-      transpose = !!(argv.delete('-t'))
+      recursive_search = !argv.delete('-r').nil?
+      transpose = !argv.delete('-t').nil?
 
       folders = argv.empty? ? [Dir.pwd] : argv