feat(agent): add workflow executor proxy routes#293
Merged
Conversation
3 new issues
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| "#{EXECUTOR_PREFIX}/#{run_id}#{suffix}" | ||
| end | ||
|
|
||
| def forward(method, base_url, path, args) |
| next if value.is_a?(Hash) || value.is_a?(Array) # 'data' body, etc. | ||
|
|
||
| acc[key.to_s] = value | ||
| end |
| FORWARDED_HEADERS.each_with_object({}) do |name, acc| | ||
| value = headers[name] || headers[name.downcase] || headers["HTTP_#{name.upcase}"] | ||
| acc[name] = value if value && !value.to_s.empty? | ||
| end |
| Faraday.new do |f| | ||
| f.request :json | ||
| f.response :json, content_type: /\bjson$/ | ||
| f.adapter Faraday.default_adapter |
There was a problem hiding this comment.
No timeout and open_timeout in the Faraday client ? (See https://lostisland.github.io/faraday/#/customization/request-options)
That depends ont the network layer between agent and executor, so exception might not be triggered.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Time.now.to_i + 1.hour returned an ActiveSupport::Duration, which serialized the JWT exp claim as a string. Use (Time.now + 1.hour).to_i so exp is a proper integer NumericDate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
christophebrun-forest
approved these changes
Jun 3, 2026
christophebrun-forest
left a comment
christophebrun-forest
left a comment
Member
There was a problem hiding this comment.
ok for me .
To test with orchestrator, the following two PRs must be merged for the executor:
forest-bot
added a commit
that referenced
this pull request
Jun 8, 2026
# [1.31.0](v1.30.7...v1.31.0) (2026-06-08) ### Features * **agent:** add workflow executor proxy routes ([#293](#293)) ([7adf991](7adf991))
Member
|
🎉 This PR is included in version 1.31.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add workflow executor proxy routes to forward workflow execution requests
WorkflowExecutorProxyroute class that registers two endpoints (GET /_internal/workflow-executions/:run_idandPOST /_internal/workflow-executions/:run_id/trigger) whenworkflow_executor_urlis configured.AuthorizationandCookieheaders, filtered query params, and JSON:API-aware body extraction.workflow_executor_urlas a new configuration option (defaultnil) in forest_admin_rails.rb.ConnectionFailedandTimeoutErrorare translated to503 ServiceUnavailableErrorinstead of leaking raw exceptions.workflow_executor_urlis set; if unset, no routes are exposed.Changes since #293 opened
ForestAdminAgent::Routes::Workflow::WorkflowExecutorProxywith method-specific timeouts [64b3bdc]ForestAdminAgent::Routes::Workflow::WorkflowExecutorProxy[64b3bdc]ForestAdminAgent::Routes::Workflow::WorkflowExecutorProxyfrom RuboCopMetrics/ClassLengthenforcement [64b3bdc]ForestAdminAgent::Auth::OAuth2::ForestResourceOwner.expiration_in_secondsto add one hour before converting to integer rather than after, and updated the corresponding spec to compare the 'exp' field as an integer [3704192]Macroscope summarized 0be6d8d.