add test coverage for FoodComposition

[atherdon]

https://github.com/GroceriStar/sd/tree/master/src/data/FoodComposition

[atherdon]

@AndrewSerra

[AndrewSerra]

This is the same as all tests I assume, right? Doing this now.

[AndrewSerra]

Again sorry about this week being a bit away because of the hospital issues I've been busy with getting health tests done.

[AndrewSerra]

for the test coverage (#532) I read and saw the json files being in generator/projects/FoodComposition/ directory. Will the json files stay in that directory or will they be moved to src/data/FoodComposition/? I'm asking this because files.js uses the directory src/data/FoodComposition/

Another question is should I add them to the files.js file to use them for the test? if yes, should they be separate for countries or use just one test?

[atherdon]

@vadim9999

[vadim9999]

@AndrewSerra

for the test coverage (#532) I read and saw the json files being in generator/projects/FoodComposition/ directory. Will the json files stay in that directory or will they be moved to src/data/FoodComposition/? I'm asking this because files.js uses the directory src/data/FoodComposition/

Another question is should I add them to the files.js file to use them for the test? if yes, should they be separate for countries or use just one test?

jsons files will be moved from generator/projects/FoodComposition to src/data/FoodComposition, but not now.
Yes, add separated for countries and FoodComposition.json to the files.js. Use separated by countries and FoodComposition.json for tests.

[AndrewSerra]

awesome working on it

[AndrewSerra]

as a suggestion, do you think having a single test file (foodComposition.test.js) containing all tests for the countries and foodComposition.json could be better? Since all tests are in a way "related" to FoodComposition I wanted to ask whether the test file can cover them all. or should I keep the test files all separate files as well?

[atherdon]

for now it's debatable because after finishing this tests we something like closing a door for this sub-project. But if Vadim told so - then I'm voting for his way

[AndrewSerra]

ok I'll keep all files separate and simple, no problem

[atherdon]

yeah, maybe it will save some time for people that will work or use this part in the future. That set is a pretty unique combination of data that our machine learning team created. When it will be released to public - i'm curious to see a response

[AndrewSerra]

it sounds like something awesome is happening :) I saw the comments in this issue interesting.

yeah, maybe it will save some time for people that will work or use this part in the future. That set is a pretty unique combination of data that our machine learning team created. When it will be released to public - i'm curious to see a response