removed redundant verbose print statements

Author: FlareCoding

userland/apps/stlxdm/include/stlxdm_input_manager.h

@@ -8,7 +8,7 @@
 #include "stlxdm_server.h"
 
 // Trace/debug output control
-#define STLXDM_INPUT_TRACE_ENABLED 1  // Set to 0 to disable all input manager trace output
+#define STLXDM_INPUT_TRACE_ENABLED 0  // Set to 0 to disable all input manager trace output
 
 #if STLXDM_INPUT_TRACE_ENABLED
     #define STLXDM_INPUT_TRACE(fmt, ...) printf("[STLXDM_INPUT] " fmt "\n", ##__VA_ARGS__)

userland/apps/stlxdm/include/stlxdm_server.h

@@ -5,6 +5,15 @@
 #include <stlxgfx/stlxgfx.h>
 #include <stlxgfx/window.h>
 
+// Trace/debug output control
+#define STLXDM_SERVER_TRACE_ENABLED 0  // Set to 0 to disable all server trace output
+
+#if STLXDM_SERVER_TRACE_ENABLED
+    #define STLXDM_SERVER_TRACE(fmt, ...) printf("[STLXDM_SERVER] " fmt "\n", ##__VA_ARGS__)
+#else
+    #define STLXDM_SERVER_TRACE(fmt, ...) ((void)0)  // No-op when disabled
+#endif
+
 // Maximum number of concurrent clients
 #define STLXDM_MAX_CLIENTS 16
 

userland/apps/stlxdm/src/stlxdm_framebuffer.c

@@ -14,10 +14,7 @@ int stlxdm_get_framebuffer_info(struct gfx_framebuffer_info* fb_info) {
         printf("ERROR: Failed to get framebuffer info: %ld\n", result);
         return -1;
     }
-    
-    printf("STLXDM] Framebuffer info: %ux%u, %u BPP, pitch=%u, size=%u\n", 
-           fb_info->width, fb_info->height, fb_info->bpp, fb_info->pitch, fb_info->size);
-    
+
     return 0;
 }
 
@@ -27,8 +24,7 @@ uint8_t* stlxdm_map_framebuffer(void) {
         printf("ERROR: Failed to map framebuffer: %ld\n", map_result);
         return NULL;
     }
-    
-    printf("[STLXDM] Framebuffer mapped at address: 0x%lx\n", map_result);
+
     return (uint8_t*)map_result;
 }
 
@@ -38,8 +34,7 @@ int stlxdm_unmap_framebuffer(void) {
         printf("ERROR: Failed to unmap framebuffer: %ld\n", result);
         return -1;
     }
-    
-    printf("Framebuffer unmapped successfully\n");
+
     return 0;
 }
 

userland/apps/stlxdm/src/stlxdm_hud.c

@@ -35,8 +35,7 @@ int stlxdm_hud_init(stlxdm_hud_t* hud, stlxgfx_context_t* gfx_ctx) {
     hud->mouse_y = -1;
     hud->mouse_over_hud = 0;
     hud->needs_redraw = 1;  // Initial render needed
-    
-    printf("[STLXDM_HUD] HUD initialized successfully\n");
+
     return 0;
 }
 
@@ -55,8 +54,6 @@ void stlxdm_hud_cleanup(stlxdm_hud_t* hud) {
     hud->component_count = 0;
     hud->max_components = 0;
     hud->needs_redraw = 0;
-    
-    printf("[STLXDM_HUD] HUD cleaned up\n");
 }
 
 int stlxdm_hud_register_component(stlxdm_hud_t* hud, stlxdm_hud_component_t* component) {
@@ -79,8 +76,6 @@ int stlxdm_hud_register_component(stlxdm_hud_t* hud, stlxdm_hud_component_t* com
 
     // Mark HUD as needing redraw
     stlxdm_hud_mark_dirty(hud);
-    
-    printf("[STLXDM_HUD] Registered component ID=%u, type=%d\n", component->id, component->type);
     return 0;
 }
 
@@ -106,7 +101,6 @@ int stlxdm_hud_unregister_component(stlxdm_hud_t* hud, uint32_t component_id) {
         }
     }
 
-    printf("[STLXDM_HUD] Component ID=%u not found for unregistration\n", component_id);
     return -1;
 }
 
@@ -167,7 +161,6 @@ int stlxdm_hud_handle_mouse_click(stlxdm_hud_t* hud, int32_t click_x, int32_t cl
 
     // Check if click is within HUD area
     if (click_y < 0 || click_y >= STLXDM_HUD_HEIGHT) {
-        printf("[STLXDM_HUD] Click outside HUD area (y=%d, HUD height=%d)\n", click_y, STLXDM_HUD_HEIGHT);
         return 0;  // Click outside HUD, not handled
     }
 

userland/apps/stlxdm/src/stlxdm_server.c

@@ -12,7 +12,7 @@
 
 int stlxdm_server_init(stlxdm_server_t* server, stlxgfx_context_t* gfx_ctx, stlxgfx_pixel_format_t format) {
     if (!server || !gfx_ctx) {
-        printf("[STLXDM_SERVER] ERROR: Invalid parameters for server init\n");
+        STLXDM_SERVER_TRACE("ERROR: Invalid parameters for server init");
         return -1;
     }
 
@@ -84,7 +84,7 @@ int stlxdm_server_accept_new_connections(stlxdm_server_t* server) {
                 // Allocate receive buffer for this client
                 server->clients[slot].receive_buffer = malloc(STLXGFX_MAX_PAYLOAD_SIZE);
                 if (!server->clients[slot].receive_buffer) {
-                    printf("[STLXDM_SERVER] ERROR: Failed to allocate receive buffer for client %u\n", server->clients[slot].client_id);
+                    STLXDM_SERVER_TRACE("ERROR: Failed to allocate receive buffer for client %u", server->clients[slot].client_id);
                     // Clean up the connection
                     close(new_client_fd);
                     server->clients[slot].socket_fd = -1;
@@ -97,13 +97,13 @@ int stlxdm_server_accept_new_connections(stlxdm_server_t* server) {
                 new_connections++;
             } else {
                 // No slots available, close the connection
-                printf("[STLXDM_SERVER] WARNING: No client slots available, closing connection\n");
+                STLXDM_SERVER_TRACE("WARNING: No client slots available, closing connection");
                 close(new_client_fd);
                 break;
             }
         } else if (new_client_fd == -2) {
             // Error accepting connection
-            printf("[STLXDM_SERVER] ERROR: Failed to accept client connection\n");
+            STLXDM_SERVER_TRACE("ERROR: Failed to accept client connection");
             return -1;
         } else {
             // No more pending connections (new_client_fd == -1)
@@ -137,7 +137,7 @@ static int stlxdm_server_dispatch_message(stlxdm_server_t* server,
             return stlxdm_server_handle_destroy_window_request(server, client, header, payload);
         }
         default: {
-            printf("[STLXDM_SERVER] Unknown message type %u from client %u\n", 
+            STLXDM_SERVER_TRACE("Unknown message type %u from client %u", 
                    header->message_type, client->client_id);
             return -1;
         }
@@ -152,7 +152,7 @@ static int stlxdm_server_handle_create_window_request(stlxdm_server_t* server,
 
     // Validate window dimensions
     if (req->width == 0 || req->height == 0 || req->width > 4096 || req->height > 4096) {
-        printf("[STLXDM_SERVER] Invalid window dimensions: %ux%u\n", req->width, req->height);
+        STLXDM_SERVER_TRACE("Invalid window dimensions: %ux%u", req->width, req->height);
         // TODO: Send error response
         return -1;
     }
@@ -165,14 +165,14 @@ static int stlxdm_server_handle_create_window_request(stlxdm_server_t* server,
 
     // Validate title length
     if (req->title_length > 255) {
-        printf("[STLXDM_SERVER] Title too long: %u characters\n", req->title_length);
+        STLXDM_SERVER_TRACE("Title too long: %u characters", req->title_length);
         // TODO: Send error response
         return -1;
     }
 
     // Check if client already has a window
     if (client->window != NULL) {
-        printf("[STLXDM_SERVER] Client %u already has a window\n", client->client_id);
+        STLXDM_SERVER_TRACE("Client %u already has a window", client->client_id);
         // TODO: Send error response
         return -1;
     }
@@ -181,7 +181,7 @@ static int stlxdm_server_handle_create_window_request(stlxdm_server_t* server,
     stlxgfx_context_t* gfx_ctx = server->gfx_ctx;
 
     if (!gfx_ctx) {
-        printf("[STLXDM_SERVER] ERROR: No graphics context available\n");
+        STLXDM_SERVER_TRACE("ERROR: No graphics context available");
         return -1;
     }
 
@@ -190,7 +190,7 @@ static int stlxdm_server_handle_create_window_request(stlxdm_server_t* server,
     stlxgfx_window_sync_t* sync_data;
 
     if (stlxgfx_dm_create_window_sync_shm(gfx_ctx, &sync_shm_handle, &sync_data) != 0) {
-        printf("[STLXDM_SERVER] Failed to create window sync SHM\n");
+        STLXDM_SERVER_TRACE("Failed to create window sync SHM");
         return -1;
     }
 
@@ -203,7 +203,7 @@ static int stlxdm_server_handle_create_window_request(stlxdm_server_t* server,
 
     if (stlxgfx_dm_create_shared_surface_set(gfx_ctx, req->width, req->height, surface_format,
                                              &surface_shm_handle, &surface0, &surface1, &surface2) != 0) {
-        printf("[STLXDM_SERVER] Failed to create surface set SHM\n");
+        STLXDM_SERVER_TRACE("Failed to create surface set SHM");
         // Clean up sync SHM
         stlxgfx_dm_destroy_window_sync_shm(gfx_ctx, sync_shm_handle, sync_data);
         return -1;
@@ -214,7 +214,7 @@ static int stlxdm_server_handle_create_window_request(stlxdm_server_t* server,
     stlxgfx_event_ring_t* event_ring;
 
     if (stlxgfx_dm_create_event_ring_shm(gfx_ctx, &event_shm_handle, &event_ring) != 0) {
-        printf("[STLXDM_SERVER] Failed to create event ring SHM\n");
+        STLXDM_SERVER_TRACE("Failed to create event ring SHM");
         // Clean up surface set SHM
         stlxgfx_dm_destroy_shared_surface_set(gfx_ctx, surface_shm_handle, surface0, surface1, surface2);
         // Clean up sync SHM
@@ -225,7 +225,7 @@ static int stlxdm_server_handle_create_window_request(stlxdm_server_t* server,
     // Create and populate window structure
     stlxgfx_window_t* window = malloc(sizeof(stlxgfx_window_t));
     if (!window) {
-        printf("[STLXDM_SERVER] Failed to allocate window structure\n");
+        STLXDM_SERVER_TRACE("Failed to allocate window structure");
         // Clean up all shared memory
         stlxgfx_dm_destroy_event_ring_shm(gfx_ctx, event_shm_handle, event_ring);
         stlxgfx_dm_destroy_shared_surface_set(gfx_ctx, surface_shm_handle, surface0, surface1, surface2);
@@ -278,11 +278,11 @@ static int stlxdm_server_handle_create_window_request(stlxdm_server_t* server,
     };
 
     if (stlxgfx_send_message(client->socket_fd, &response_header, &response) == 0) {
-        printf("[STLXDM_SERVER] Created window ID=%u with sync_shm=%lu, surface_shm=%lu, event_shm=%lu for client %u\n", 
+        STLXDM_SERVER_TRACE("Created window ID=%u with sync_shm=%lu, surface_shm=%lu, event_shm=%lu for client %u", 
                window->window_id, sync_shm_handle, surface_shm_handle, event_shm_handle, client->client_id);
         return 0;
     } else {
-        printf("[STLXDM_SERVER] Failed to send response to client %u\n", client->client_id);
+        STLXDM_SERVER_TRACE("Failed to send response to client %u", client->client_id);
         // Clean up everything on send failure
         client->window = NULL;
         free(window);
@@ -301,7 +301,7 @@ static int stlxdm_server_handle_destroy_window_request(stlxdm_server_t* server,
 
     // Check if client has a window
     if (client->window == NULL) {
-        printf("[STLXDM_SERVER] Client %u has no window to destroy\n", client->client_id);
+        STLXDM_SERVER_TRACE("Client %u has no window to destroy", client->client_id);
         // Send error response
         stlxgfx_message_header_t error_header = {
             .protocol_version = STLXGFX_PROTOCOL_VERSION,
@@ -323,7 +323,7 @@ static int stlxdm_server_handle_destroy_window_request(stlxdm_server_t* server,
 
     // Validate that the window ID matches
     if (client->window->window_id != req->window_id) {
-        printf("[STLXDM_SERVER] Window ID mismatch: client has %u, request for %u\n", 
+        STLXDM_SERVER_TRACE("Window ID mismatch: client has %u, request for %u", 
                client->window->window_id, req->window_id);
         // Send error response
         stlxgfx_message_header_t error_header = {
@@ -348,13 +348,13 @@ static int stlxdm_server_handle_destroy_window_request(stlxdm_server_t* server,
     stlxgfx_context_t* gfx_ctx = server->gfx_ctx;
 
     if (!gfx_ctx) {
-        printf("[STLXDM_SERVER] ERROR: No graphics context available\n");
+        STLXDM_SERVER_TRACE("ERROR: No graphics context available");
         return -1;
     }
 
     // Clean up window resources
     stlxgfx_window_t* window = client->window;
-    printf("[STLXDM_SERVER] Destroying window ID=%u for client %u\n", 
+    STLXDM_SERVER_TRACE("Destroying window ID=%u for client %u", 
            window->window_id, client->client_id);
 
     // Clean up shared memory resources
@@ -402,11 +402,11 @@ static int stlxdm_server_handle_destroy_window_request(stlxdm_server_t* server,
     };
 
     if (stlxgfx_send_message(client->socket_fd, &response_header, &response) == 0) {
-        printf("[STLXDM_SERVER] Successfully destroyed window ID=%u for client %u\n", 
+        STLXDM_SERVER_TRACE("Successfully destroyed window ID=%u for client %u", 
                req->window_id, client->client_id);
         return 0;
     } else {
-        printf("[STLXDM_SERVER] Failed to send destroy response to client %u\n", client->client_id);
+        STLXDM_SERVER_TRACE("Failed to send destroy response to client %u", client->client_id);
         return -1;
     }
 }
@@ -431,16 +431,16 @@ int stlxdm_server_handle_client_requests(stlxdm_server_t* server) {
 
         if (result == 0) {
             // Message received, dispatch to appropriate handler
-            printf("[STLXDM_SERVER] Received %s (%u) from client %u (slot %d)\n", 
+            STLXDM_SERVER_TRACE("Received %s (%u) from client %u (slot %d)", 
                    stlxdm_server_get_message_type_name(header.message_type),
                    header.message_type, client->client_id, i);
 
             if (stlxdm_server_dispatch_message(server, client, &header, client->receive_buffer) < 0) {
-                printf("[STLXDM_SERVER] Failed to handle message from client %u\n", client->client_id);
+                STLXDM_SERVER_TRACE("Failed to handle message from client %u", client->client_id);
             }
         } else if (result == -2) {
             // Client disconnected or error
-            printf("[STLXDM_SERVER] Client %u (slot %d) disconnected\n", client->client_id, i);
+            STLXDM_SERVER_TRACE("Client %u (slot %d) disconnected", client->client_id, i);
             stlxdm_server_disconnect_client(server, i);
         }
         // result == -1 means no data available, which is normal
@@ -464,7 +464,7 @@ int stlxdm_server_disconnect_client(stlxdm_server_t* server, int client_index) {
         return 0; // Already disconnected
     }
 
-    printf("[STLXDM_SERVER] Disconnecting client %u (slot %d, fd %d)\n", 
+    STLXDM_SERVER_TRACE("Disconnecting client %u (slot %d, fd %d)", 
            client->client_id, client_index, client->socket_fd);
 
     // Close socket
@@ -475,7 +475,7 @@ int stlxdm_server_disconnect_client(stlxdm_server_t* server, int client_index) {
     // Clean up window if it exists
     if (client->window) {
         stlxgfx_window_t* window = client->window;
-        printf("[STLXDM_SERVER] Cleaning up window ID=%u for client %u\n", 
+        STLXDM_SERVER_TRACE("Cleaning up window ID=%u for client %u", 
                window->window_id, client->client_id);
 
         // Properly destroy window with shared memory cleanup

userland/apps/stlxdm/src/stlxdm_splash.c

@@ -289,15 +289,13 @@ int stlxdm_show_splash_screen(stlxdm_compositor_t* compositor) {
         printf("[STLXDM_SPLASH] ERROR: Invalid compositor for splash screen\n");
         return -1;
     }
-    
-    printf("[STLXDM_SPLASH] Starting splash screen...\n");
-    
+
     const struct gfx_framebuffer_info* fb_info = stlxdm_compositor_get_fb_info(compositor);
     if (!fb_info) {
         printf("[STLXDM_SPLASH] ERROR: No framebuffer info available\n");
         return -1;
     }
-    
+
     stlxgfx_surface_t* splash_surface = stlxgfx_dm_create_surface(
         compositor->gfx_ctx,
         fb_info->width,
@@ -312,8 +310,7 @@ int stlxdm_show_splash_screen(stlxdm_compositor_t* compositor) {
 
     uint32_t frame = 0;
     uint32_t elapsed_ms = 0;
-    printf("[STLXDM_SPLASH] Displaying splash screen (press Enter to continue)\n");
-    
+
     while (1) {
         create_dark_background(splash_surface);
         draw_animated_gradient_logo(splash_surface, frame);
@@ -336,7 +333,6 @@ int stlxdm_show_splash_screen(stlxdm_compositor_t* compositor) {
         }
 
         if (check_for_enter_key()) {
-            printf("[STLXDM_SPLASH] Enter key pressed, continuing to display manager\n");
             break;
         }
 
@@ -354,6 +350,5 @@ int stlxdm_show_splash_screen(stlxdm_compositor_t* compositor) {
     stlxdm_launch_terminal();
 
     stlxgfx_dm_destroy_surface(compositor->gfx_ctx, splash_surface);
-    printf("[STLXDM_SPLASH] Splash screen completed\n");
     return 0;
 }