Block make reset with a safety setting

Author: emyller

api/app/settings/common.py

@@ -1471,3 +1471,7 @@
 PYLON_IDENTITY_VERIFICATION_SECRET = env.str("PYLON_IDENTITY_VERIFICATION_SECRET", None)
 
 OSIC_UPDATE_BATCH_SIZE = env.int("OSIC_UPDATE_BATCH_SIZE", default=500)
+
+# Allow the reset_local_database management command to run.
+# This command flushes and seeds the database with test data.
+ENABLE_LOCAL_DATABASE_RESET = False

api/app/settings/local.py

@@ -18,3 +18,5 @@
 ENABLE_ADMIN_ACCESS_USER_PASS = True
 
 SKIP_MIGRATION_TESTS = True
+
+ENABLE_LOCAL_DATABASE_RESET = True

api/core/management/commands/reset_local_database.py

@@ -1,7 +1,8 @@
 import json
 from typing import Any
 
-from django.core.management import BaseCommand, call_command
+from django.conf import settings
+from django.core.management import BaseCommand, CommandError, call_command
 from django.urls import reverse
 from rest_framework.test import APIClient
 
@@ -10,6 +11,11 @@ class Command(BaseCommand):
     help = "Resets and seeds the database with test data for local development"
 
     def handle(self, *args: Any, **kwargs: Any) -> None:
+        if not settings.ENABLE_LOCAL_DATABASE_RESET:
+            raise CommandError(
+                "This command is disabled. "
+                "Set ENABLE_LOCAL_DATABASE_RESET to True in Django settings to enable it."
+            )
         self.stdout.write("Flushing database...")
         call_command("flush", "--noinput", verbosity=0)
 

api/tests/integration/core/test_reset_local_database.py

@@ -1,7 +1,8 @@
 from unittest.mock import MagicMock
 
 import pytest
-from django.core.management import call_command
+from django.core.management import CommandError, call_command
+from pytest_django.fixtures import SettingsWrapper
 from pytest_mock import MockerFixture
 
 from environments.identities.models import Identity
@@ -21,6 +22,12 @@
 pytestmark = pytest.mark.django_db
 
 
+@pytest.fixture(autouse=True)
+def enable_local_database_reset(settings: SettingsWrapper) -> None:
+    """Enable the reset_local_database command for tests."""
+    settings.ENABLE_LOCAL_DATABASE_RESET = True
+
+
 @pytest.fixture(autouse=True)
 def mock_reset_commands(mocker: MockerFixture) -> MagicMock:
     """Mock flush/migrate/createcachetable to avoid resetting the test database."""
@@ -99,3 +106,16 @@ def test_reset_local_database__creates_expected_data() -> None:
     identifiers = list(Identity.objects.values_list("identifier", flat=True))
     assert "alice@example.com" in identifiers
     assert "bob@example.com" in identifiers
+
+
+def test_reset_local_database__raises_error_when_disabled(
+    settings: SettingsWrapper,
+) -> None:
+    # Given
+    settings.ENABLE_LOCAL_DATABASE_RESET = False
+
+    # When / Then
+    with pytest.raises(CommandError) as exc_info:
+        call_command("reset_local_database")
+
+    assert "ENABLE_LOCAL_DATABASE_RESET" in str(exc_info.value)