Skip to content

Commit 26d703e

Browse files
authored
fix: update-env-state-on-metadata-update (#6831)
1 parent 458a554 commit 26d703e

2 files changed

Lines changed: 9 additions & 8 deletions

File tree

frontend/web/components/metadata/AddMetadataToEntity.tsx

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,7 @@ import { Metadata } from 'common/types/responses'
66
import Utils from 'common/utils/utils'
77
import Switch from 'components/Switch'
88
import InputGroup from 'components/base/forms/InputGroup'
9-
import {
10-
metadataService,
11-
useGetEntityMetadataFieldsQuery,
12-
} from 'common/services/useMetadataField'
13-
import { getStore } from 'common/store'
9+
import { useGetEntityMetadataFieldsQuery } from 'common/services/useMetadataField'
1410
import { CustomMetadataField } from 'common/types/metadata-field'
1511
import { useGlobalMetadataValidation } from 'common/utils/metadataValidation'
1612
import RedirectCreateCustomFields from './RedirectCreateCustomFields'
@@ -26,6 +22,7 @@ type AddMetadataToEntityProps = {
2622
entity: string
2723
envName?: string
2824
onChange?: (metadata: Metadata[]) => void
25+
onMetadataSave?: (metadata: Metadata[]) => void
2926
setHasMetadataRequired?: (b: boolean) => void
3027
}
3128

@@ -61,6 +58,7 @@ const AddMetadataToEntity: FC<AddMetadataToEntityProps> = ({
6158
envName,
6259
isCloningEnvironment,
6360
onChange,
61+
onMetadataSave,
6462
organisationId,
6563
projectId,
6664
setHasMetadataRequired,
@@ -137,9 +135,7 @@ const AddMetadataToEntity: FC<AddMetadataToEntityProps> = ({
137135
toast(errorMessage || 'Failed to update custom fields', 'danger')
138136
} else {
139137
toast('Environment Field Updated')
140-
getStore().dispatch(
141-
metadataService.util.invalidateTags([{ type: 'Metadata' }]),
142-
)
138+
onMetadataSave?.(formatMetadataToApi(metadataFields))
143139
}
144140
}
145141

frontend/web/components/pages/EnvironmentSettingsPage.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -920,6 +920,11 @@ const EnvironmentSettingsPage: React.FC = () => {
920920
envName={currentEnv?.name}
921921
entityContentType={environmentContentType?.id}
922922
entity={environmentContentType.model}
923+
onMetadataSave={(metadata) => {
924+
setCurrentEnv((prev) =>
925+
prev ? { ...prev, metadata } : null,
926+
)
927+
}}
923928
/>
924929
}
925930
/>

0 commit comments

Comments
 (0)