Skip to content

Commit 355b57b

Browse files
committed
fix: Clean up Dockerfile and update deployment steps in workflow
1 parent d19804b commit 355b57b

2 files changed

Lines changed: 27 additions & 29 deletions

File tree

.github/workflows/deploy.yml

Lines changed: 23 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88
jobs:
99
build-and-deploy:
1010
runs-on: ubuntu-latest
11+
environment: Development
1112

1213
steps:
1314
- name: Checkout code
@@ -28,31 +29,28 @@ jobs:
2829
context: .
2930
push: true
3031
tags: ${{ secrets.DOCKERHUB_USERNAME }}/resourcehub:latest
31-
# No build-args for secrets; secrets will be injected at runtime
32-
33-
# Add deployment steps
34-
- name: Deploy container
35-
env:
36-
USER: ${{ secrets.USER }}
37-
PASSWORD: ${{ secrets.PASSWORD }}
38-
HOST: ${{ secrets.HOST }}
39-
PORT: ${{ secrets.PORT }}
40-
DATABASE: ${{ secrets.DATABASE }}
41-
SMTP_HOST: ${{ secrets.SMTP_HOST }}
42-
SMTP_PASSWORD: ${{ secrets.SMTP_PASSWORD }}
43-
SMTP_USER: ${{ secrets.SMTP_USER }}
44-
PDFSHIFT_API_KEY: ${{ secrets.PDFSHIFT_API_KEY }}
45-
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
32+
33+
- name: Set up Docker context for remote server
34+
run: |
35+
docker context create remote --docker "host=${{ secrets.DOCKER_HOST }}"
36+
docker context use remote
37+
38+
- name: Deploy to remote server
4639
run: |
40+
docker pull ${{ secrets.DOCKERHUB_USERNAME }}/resourcehub:latest
41+
docker stop resourcehub || true
42+
docker rm resourcehub || true
4743
docker run -d \
48-
-e USER="$USER" \
49-
-e PASSWORD="$PASSWORD" \
50-
-e HOST="$HOST" \
51-
-e PORT="$PORT" \
52-
-e DATABASE="$DATABASE" \
53-
-e SMTP_HOST="$SMTP_HOST" \
54-
-e SMTP_PASSWORD="$SMTP_PASSWORD" \
55-
-e SMTP_USER="$SMTP_USER" \
56-
-e PDFSHIFT_API_KEY="$PDFSHIFT_API_KEY" \
44+
--name resourcehub \
45+
-e USER="${{ secrets.USER }}" \
46+
-e PASSWORD="${{ secrets.PASSWORD }}" \
47+
-e HOST="${{ secrets.HOST }}" \
48+
-e PORT="${{ secrets.PORT }}" \
49+
-e DATABASE="${{ secrets.DATABASE }}" \
50+
-e SMTP_HOST="${{ secrets.SMTP_HOST }}" \
51+
-e SMTP_PASSWORD="${{ secrets.SMTP_PASSWORD }}" \
52+
-e SMTP_USER="${{ secrets.SMTP_USER }}" \
53+
-e PDFSHIFT_API_KEY="${{ secrets.PDFSHIFT_API_KEY }}" \
5754
-p 80:80 -p 9090-9094:9090-9094 \
58-
"$DOCKERHUB_USERNAME/resourcehub:latest"
55+
${{ secrets.DOCKERHUB_USERNAME }}/resourcehub:latest
56+
docker logs resourcehub

Dockerfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ RUN apt-get update && apt-get install -y \
77
unzip \
88
nodejs \
99
npm \
10-
openjdk-11-jre
10+
openjdk-11-jre && \
11+
apt-get clean && rm -rf /var/lib/apt/lists/*
1112

1213
# Download and extract Ballerina SDK
1314
RUN curl -L https://github.com/ballerina-platform/ballerina-lang/releases/download/v2201.12.7/ballerina-2201.12.7-swan-lake.zip -o ballerina.zip && \
@@ -26,13 +27,12 @@ COPY Front-End /app/Front-End
2627
RUN npm install && npm run build
2728

2829
# Port configuration
29-
EXPOSE 9090 9091 9092 9093 9094 80
30+
EXPOSE 80 9090-9094
3031

3132
# Create a non-root user and switch to it
3233
RUN useradd -u 10001 -m resourcehub
3334
USER 10001
3435

35-
3636
# Prepare the final image
3737
WORKDIR /app
38-
CMD ["sh", "-c", "java -jar /app/Back-End/target/bin/ResourceHub.jar & npx serve -s /app/Front-End/build -l 80"]
38+
CMD ["sh", "-c", "java -jar /app/Back-End/target/bin/ResourceHub.jar & npx serve -s /app/Front-End/build -l 80"]

0 commit comments

Comments
 (0)