Skip to content

Commit 77bbd2f

Browse files
committed
Address review: tighten Value-quoting assertion and drop off-topic entity test
Match the alias-qualified `."Value"` pattern instead of bare `"Value"` so the assertion no longer matches the user-supplied raw SQL substring and genuinely verifies EF Core's outer projection quotes the identifier. Remove EntitySingleOrDefaultQuotesIdentifiers — it has no Value column, asserts nothing about SQL content, and the Take(1) before SingleOrDefaultAsync was redundant.
1 parent 936435c commit 77bbd2f

1 file changed

Lines changed: 3 additions & 13 deletions

File tree

src/FirebirdSql.EntityFrameworkCore.Firebird.Tests/Query/ElementaryTests.cs

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ public async Task SqlQueryScalarSingleQuotesValueColumn()
218218
var query = db.Database.SqlQueryRaw<int>(@"SELECT 1 AS ""Value"" FROM RDB$DATABASE");
219219
Assert.DoesNotThrowAsync(() => query.SingleAsync());
220220
var sql = db.LastCommandText;
221-
StringAssert.Contains(@"""Value""", sql);
221+
StringAssert.Contains(@".""Value""", sql);
222222
}
223223
}
224224

@@ -230,7 +230,7 @@ public async Task SqlQueryScalarSingleOrDefaultQuotesValueColumn()
230230
var query = db.Database.SqlQueryRaw<int>(@"SELECT 1 AS ""Value"" FROM RDB$DATABASE");
231231
Assert.DoesNotThrowAsync(() => query.SingleOrDefaultAsync());
232232
var sql = db.LastCommandText;
233-
StringAssert.Contains(@"""Value""", sql);
233+
StringAssert.Contains(@".""Value""", sql);
234234
}
235235
}
236236

@@ -242,17 +242,7 @@ public async Task SqlQueryScalarComposedWhereQuotesValueColumn()
242242
var query = db.Database.SqlQueryRaw<int>(@"SELECT 1 AS ""Value"" FROM RDB$DATABASE").Where(x => x > 0);
243243
Assert.DoesNotThrowAsync(() => query.LoadAsync());
244244
var sql = db.LastCommandText;
245-
StringAssert.Contains(@"""Value""", sql);
246-
}
247-
}
248-
249-
[Test]
250-
public async Task EntitySingleOrDefaultQuotesIdentifiers()
251-
{
252-
await using (var db = await GetDbContext<SelectContext>())
253-
{
254-
var query = db.Set<MonAttachment>().OrderBy(x => x.AttachmentId).Take(1);
255-
Assert.DoesNotThrowAsync(() => query.SingleOrDefaultAsync());
245+
StringAssert.Contains(@".""Value""", sql);
256246
}
257247
}
258248
}

0 commit comments

Comments
 (0)