Skip to content

Commit dbdb38d

Browse files
Copilotredpanda-f
andauthored
Fix invalid v/* glob example — replace with v* throughout (#92)
* Initial plan * Replace invalid v/* glob pattern with v* in docs and code Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com>
1 parent 535fa10 commit dbdb38d

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

README_ADVANCED.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ foc-devnet init [OPTIONS]
2626

2727
**Source Format:**
2828
- `latesttag` - Newest git tag in the default repo (resolved once at `init`).
29-
- `latesttag:<selector>` - Newest git tag matching a glob selector, e.g. `latesttag:v/*` or `latesttag:pdp/v*`.
30-
- `latesttag:<url>:<selector>` - Newest matching tag from a custom repo, e.g. `latesttag:https://github.com/org/repo.git:v/*`.
29+
- `latesttag:<selector>` - Newest git tag matching a glob selector, e.g. `latesttag:v*` or `latesttag:pdp/v*`.
30+
- `latesttag:<url>:<selector>` - Newest matching tag from a custom repo, e.g. `latesttag:https://github.com/org/repo.git:v*`.
3131
- `gittag:<tag>` - Specific git tag (uses default repo)
3232
- `gittag:<url>:<tag>` - Tag from custom repo, e.g. `gittag:https://github.com/org/repo.git:v1.0.0`
3333
- `gitcommit:<sha>` - Specific commit (uses default repo)
@@ -817,7 +817,7 @@ port_range_count = 100
817817
Default versions for these repositories are defined in code (see [`src/config.rs`](src/config.rs) `Config::default()`).
818818

819819
**Version specification methods:**
820-
- **Latest tag** (`latesttag`, `latesttag:<selector>`, `latesttag:<url>:<selector>`): Resolved once at `init` time via `git ls-remote` and pinned as a concrete `GitTag` in `config.toml`. Use a glob selector to scope which tags are considered, e.g. `latesttag:v/*` or `latesttag:pdp/v*`. Bare `latesttag` matches all tags.
820+
- **Latest tag** (`latesttag`, `latesttag:<selector>`, `latesttag:<url>:<selector>`): Resolved once at `init` time via `git ls-remote` and pinned as a concrete `GitTag` in `config.toml`. Use a glob selector to scope which tags are considered, e.g. `latesttag:v*` or `latesttag:pdp/v*`. Bare `latesttag` matches all tags.
821821
- **Git tags** (`GitTag`): Used for stable releases. Tags provide version pinning and stability.
822822
- **Git commits** (`GitCommit`): Used for repositories where specific commits are required and there isn't a corresponding tag yet. (Generally tags should be preferred over commits.)
823823
- **Git branches** (`GitBranch`): Used for development or when tracking latest changes.

src/cli.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,15 @@ pub enum Commands {
3232
#[arg(long)]
3333
curio: Option<String>,
3434
/// Lotus source location.
35-
/// Latest tag: 'latesttag' (newest), 'latesttag:<selector>' (e.g. 'latesttag:v/*'),
35+
/// Latest tag: 'latesttag' (newest), 'latesttag:<selector>' (e.g. 'latesttag:v*'),
3636
/// 'latesttag:<url>:<selector>' (custom repo). Resolved once at init.
3737
/// Explicit: 'gittag:<tag>', 'gittag:<url>:<tag>', 'gitcommit:<sha>',
3838
/// 'gitcommit:<url>:<sha>', 'gitbranch:<branch>', 'gitbranch:<url>:<branch>',
3939
/// 'local:/path/to/lotus'.
4040
#[arg(long)]
4141
lotus: Option<String>,
4242
/// Filecoin Services source location.
43-
/// Latest tag: 'latesttag' (newest), 'latesttag:<selector>' (e.g. 'latesttag:v/*'),
43+
/// Latest tag: 'latesttag' (newest), 'latesttag:<selector>' (e.g. 'latesttag:v*'),
4444
/// 'latesttag:<url>:<selector>' (custom repo). Resolved once at init.
4545
/// Explicit: 'gittag:<tag>', 'gittag:<url>:<tag>', 'gitcommit:<sha>',
4646
/// 'gitcommit:<url>:<sha>', 'gitbranch:<branch>', 'gitbranch:<url>:<branch>',
@@ -97,7 +97,7 @@ pub enum BuildCommands {
9797
pub enum ConfigCommands {
9898
/// Configure Lotus source location
9999
Lotus {
100-
/// Lotus source location (e.g., 'latesttag', 'latesttag:v/*', 'latesttag:<url>:v/*', 'gittag:v1.0.0', 'gitcommit:abc123', 'gitbranch:main', 'local:/path/to/lotus')
100+
/// Lotus source location (e.g., 'latesttag', 'latesttag:v*', 'latesttag:<url>:v*', 'gittag:v1.0.0', 'gitcommit:abc123', 'gitbranch:main', 'local:/path/to/lotus')
101101
source: String,
102102
},
103103
/// Configure Curio source location

src/config.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ mod tests {
452452
#[test]
453453
fn latesttag_with_url() {
454454
assert_eq!(
455-
canonicalize("latesttag:https://github.com/randomorg/randomrepo:v/*").unwrap(),
455+
canonicalize("latesttag:https://github.com/randomorg/randomrepo:v*").unwrap(),
456456
(
457457
"gittag".into(),
458458
"https://github.com/randomorg/randomrepo".into(),

0 commit comments

Comments
 (0)