From e4478b0e7c2e7025bb961168a7a3720a6e7bf2f0 Mon Sep 17 00:00:00 2001
From: Robotgiggle <88736742+Robotgiggle@users.noreply.github.com>
Date: Tue, 31 Mar 2026 01:03:32 -0400
Subject: [PATCH] Add config toggle for the iota NBT dump with advanced
 tooltips

---
 .../hexcasting/api/item/IotaHolderItem.java      |  3 ++-
 .../at/petrak/hexcasting/api/mod/HexConfig.java  |  3 +++
 .../assets/hexcasting/lang/en_us.flatten.json5   |  4 ++++
 .../hexcasting/fabric/FabricHexConfig.java       |  5 +++++
 .../petrak/hexcasting/forge/ForgeHexConfig.java  | 16 ++++++++++++----
 5 files changed, 26 insertions(+), 5 deletions(-)

diff --git a/Common/src/main/java/at/petrak/hexcasting/api/item/IotaHolderItem.java b/Common/src/main/java/at/petrak/hexcasting/api/item/IotaHolderItem.java
index c312383129..0735cb3198 100644
--- a/Common/src/main/java/at/petrak/hexcasting/api/item/IotaHolderItem.java
+++ b/Common/src/main/java/at/petrak/hexcasting/api/item/IotaHolderItem.java
@@ -4,6 +4,7 @@
 import at.petrak.hexcasting.api.casting.iota.IotaType;
 import at.petrak.hexcasting.api.utils.HexUtils;
 import at.petrak.hexcasting.api.utils.NBTHelper;
+import at.petrak.hexcasting.api.mod.HexConfig;
 import at.petrak.hexcasting.client.ClientTickCounter;
 import at.petrak.hexcasting.common.lib.hex.HexIotaTypes;
 import net.minecraft.ChatFormatting;
@@ -107,7 +108,7 @@ static void appendHoverText(IotaHolderItem self, ItemStack stack, List<Component
             var cmp = IotaType.getDisplay(datumTag);
             components.add(Component.translatable("hexcasting.spelldata.onitem", cmp));
 
-            if (flag.isAdvanced()) {
+            if (flag.isAdvanced() && (HexConfig.client() == null || HexConfig.client().advancedTooltipsShowsIotaNBT())) {
                 components.add(Component.literal("").append(NbtUtils.toPrettyComponent(datumTag)));
             }
         } else if (NBTHelper.hasString(stack, IotaHolderItem.TAG_OVERRIDE_VISUALLY)) {
diff --git a/Common/src/main/java/at/petrak/hexcasting/api/mod/HexConfig.java b/Common/src/main/java/at/petrak/hexcasting/api/mod/HexConfig.java
index aa4859f5ed..13d3acc567 100644
--- a/Common/src/main/java/at/petrak/hexcasting/api/mod/HexConfig.java
+++ b/Common/src/main/java/at/petrak/hexcasting/api/mod/HexConfig.java
@@ -51,12 +51,15 @@ public interface ClientConfigAccess {
 
         boolean alwaysShowListCommas();
 
+        boolean advancedTooltipsShowsIotaNBT();
+
         boolean DEFAULT_CTRL_TOGGLES_OFF_STROKE_ORDER = false;
         boolean DEFAULT_INVERT_SPELLBOOK_SCROLL = false;
         boolean DEFAULT_INVERT_ABACUS_SCROLL = false;
         double DEFAULT_GRID_SNAP_THRESHOLD = 0.5;
         boolean DEFAULT_CLICKING_TOGGLES_DRAWING = false;
         boolean DEFAULT_ALWAYS_SHOW_LIST_COMMAS = false;
+        boolean DEFAULT_ADVANCED_TOOLTIPS_SHOWS_IOTA_NBT = false;
     }
 
     public interface ServerConfigAccess {
diff --git a/Common/src/main/resources/assets/hexcasting/lang/en_us.flatten.json5 b/Common/src/main/resources/assets/hexcasting/lang/en_us.flatten.json5
index 5a0087c10f..28ec447cc0 100644
--- a/Common/src/main/resources/assets/hexcasting/lang/en_us.flatten.json5
+++ b/Common/src/main/resources/assets/hexcasting/lang/en_us.flatten.json5
@@ -355,6 +355,10 @@
           "": "Always Show List Commas",
           "@Tooltip": "Whether all iota types should be comma-separated when displayed in lists (by default, pattern iotas do not use commas)",
         },
+        advancedTooltipsShowsIotaNBT: {
+          "": "Advanced Tooltips Shows Iota NBT",
+          "@Tooltip": "Whether enabling advanced tooltips (F3+H) should display the full NBT of iotas stored in items like foci and spellbooks",
+        }
       },
       
       server: {
diff --git a/Fabric/src/main/java/at/petrak/hexcasting/fabric/FabricHexConfig.java b/Fabric/src/main/java/at/petrak/hexcasting/fabric/FabricHexConfig.java
index 6ab5d09ff4..eeffebcb64 100644
--- a/Fabric/src/main/java/at/petrak/hexcasting/fabric/FabricHexConfig.java
+++ b/Fabric/src/main/java/at/petrak/hexcasting/fabric/FabricHexConfig.java
@@ -138,6 +138,8 @@ public static final class Client implements HexConfig.ClientConfigAccess, Config
         private boolean clickingTogglesDrawing = DEFAULT_CLICKING_TOGGLES_DRAWING;
         @ConfigEntry.Gui.Tooltip
         private boolean alwaysShowListCommas = DEFAULT_ALWAYS_SHOW_LIST_COMMAS;
+        @ConfigEntry.Gui.Tooltip
+        private boolean advancedTooltipsShowsIotaNBT = DEFAULT_ADVANCED_TOOLTIPS_SHOWS_IOTA_NBT;
 
         @Override
         public void validatePostLoad() throws ValidationException {
@@ -173,6 +175,9 @@ public boolean clickingTogglesDrawing() {
         public boolean alwaysShowListCommas() {
              return alwaysShowListCommas;
         }
+
+        @Override
+        public boolean advancedTooltipsShowsIotaNBT() { return advancedTooltipsShowsIotaNBT; }
     }
 
     @Config(name = "server")
diff --git a/Forge/src/main/java/at/petrak/hexcasting/forge/ForgeHexConfig.java b/Forge/src/main/java/at/petrak/hexcasting/forge/ForgeHexConfig.java
index dd3eb257e3..931155ea2a 100644
--- a/Forge/src/main/java/at/petrak/hexcasting/forge/ForgeHexConfig.java
+++ b/Forge/src/main/java/at/petrak/hexcasting/forge/ForgeHexConfig.java
@@ -85,6 +85,7 @@ public static class Client implements HexConfig.ClientConfigAccess {
         private static ForgeConfigSpec.DoubleValue gridSnapThreshold;
         private static ForgeConfigSpec.BooleanValue clickingTogglesDrawing;
         private static ForgeConfigSpec.BooleanValue alwaysShowListCommas;
+        private static ForgeConfigSpec.BooleanValue advancedTooltipsShowsIotaNBT;
 
         public Client(ForgeConfigSpec.Builder builder) {
             ctrlTogglesOffStrokeOrder = builder.comment(
@@ -102,11 +103,15 @@ public Client(ForgeConfigSpec.Builder builder) {
                         "means 50% of the way.")
                 .defineInRange("gridSnapThreshold", DEFAULT_GRID_SNAP_THRESHOLD, 0.5, 1.0);
             clickingTogglesDrawing = builder.comment(
-                            "Whether you click to start and stop drawing instead of clicking and dragging")
-                    .define("clickingTogglesDrawing", DEFAULT_CLICKING_TOGGLES_DRAWING);
+                    "Whether you click to start and stop drawing instead of clicking and dragging")
+                .define("clickingTogglesDrawing", DEFAULT_CLICKING_TOGGLES_DRAWING);
             alwaysShowListCommas = builder.comment(
-                            "Whether all iota types should be comma-separated in lists (by default, pattern iotas don't use commas)")
-                    .define("alwaysShowListCommas", DEFAULT_ALWAYS_SHOW_LIST_COMMAS);
+                    "Whether all iota types should be comma-separated in lists (by default, pattern iotas don't use commas)")
+                .define("alwaysShowListCommas", DEFAULT_ALWAYS_SHOW_LIST_COMMAS);
+            advancedTooltipsShowsIotaNBT = builder.comment(
+                    "Whether enabling advanced tooltips (F3+H) should display the full NBT of iotas stored in items " +
+                        "like foci and spellbooks")
+                .define("advancedTooltipsShowsIotaNBT", DEFAULT_ADVANCED_TOOLTIPS_SHOWS_IOTA_NBT);
         }
 
         @Override
@@ -138,6 +143,9 @@ public boolean clickingTogglesDrawing() {
         public boolean alwaysShowListCommas() {
             return alwaysShowListCommas.get();
         }
+
+        @Override
+        public boolean advancedTooltipsShowsIotaNBT() { return advancedTooltipsShowsIotaNBT.get(); }
     }
 
     public static class Server implements HexConfig.ServerConfigAccess {