From c3aa24dacad1b8be238f7af40e06bc3547119a41 Mon Sep 17 00:00:00 2001 From: FBumann <117816358+FBumann@users.noreply.github.com> Date: Tue, 10 Mar 2026 23:02:38 +0100 Subject: [PATCH 1/5] ci: trigger checks on release-please branches Co-Authored-By: Claude Opus 4.6 --- .github/workflows/ci.yaml | 2 +- .github/workflows/pr-title.yaml | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 5f93000..dddfe6d 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -2,7 +2,7 @@ name: CI on: push: - branches: [main] + branches: [main, 'release-please--**'] pull_request: workflow_call: diff --git a/.github/workflows/pr-title.yaml b/.github/workflows/pr-title.yaml index 3ca5139..8537600 100644 --- a/.github/workflows/pr-title.yaml +++ b/.github/workflows/pr-title.yaml @@ -1,6 +1,8 @@ name: PR Title on: + push: + branches: ['release-please--**'] pull_request: types: [opened, edited, synchronize, reopened] @@ -9,7 +11,8 @@ jobs: name: Validate conventional commit format runs-on: ubuntu-24.04 steps: - - uses: amannn/action-semantic-pull-request@v6 + - if: ${{ github.event_name != 'push' }} + uses: amannn/action-semantic-pull-request@v6 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: @@ -25,3 +28,6 @@ jobs: requireScope: false subjectPattern: ^.+$ subjectPatternError: "PR title must have a description after the type" + + - if: ${{ github.event_name == 'push' }} + run: echo "Release Please PRs always use valid conventional commit format" From 657d3a27f611dc726d9566695ed1efde7cae2778 Mon Sep 17 00:00:00 2001 From: FBumann <117816358+FBumann@users.noreply.github.com> Date: Wed, 11 Mar 2026 08:05:23 +0100 Subject: [PATCH 2/5] chore: add fluxopt git dep to dev group Co-Authored-By: Claude Opus 4.6 --- pyproject.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/pyproject.toml b/pyproject.toml index 5f5c1f2..2dbf4d6 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -44,6 +44,7 @@ include = ["src/fluxopt_plot/", "LICENSE", "README.md"] [dependency-groups] dev = [ + "fluxopt @ git+https://github.com/FBumann/fluxopt.git", "mypy==1.19.1", "pre-commit==4.5.1", "pytest==9.0.2", From 4b81e938c0a2195025566bf27155ce93dede5935 Mon Sep 17 00:00:00 2001 From: FBumann <117816358+FBumann@users.noreply.github.com> Date: Wed, 11 Mar 2026 08:14:45 +0100 Subject: [PATCH 3/5] ci: use GitHub App token for release-please GITHUB_TOKEN pushes don't trigger workflow events, so CI never runs on release-please PRs. Use a GitHub App token instead, which does trigger events and avoids PAT downsides (personal attribution, manual rotation). Co-Authored-By: Claude Opus 4.6 --- .github/workflows/release.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 35d5352..00311f5 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -16,11 +16,18 @@ jobs: release_created: ${{ steps.release.outputs.release_created }} tag_name: ${{ steps.release.outputs.tag_name }} steps: + - uses: actions/create-github-app-token@v2 + id: app-token + with: + app-id: ${{ secrets.APP_ID }} + private-key: ${{ secrets.APP_PRIVATE_KEY }} + - uses: googleapis/release-please-action@v4 id: release with: config-file: .release-please-config.json manifest-file: .release-please-manifest.json + token: ${{ steps.app-token.outputs.token }} publish: name: Build & publish to PyPI From 3486a4445a635c484c8373b806cf3a791ee9fdd3 Mon Sep 17 00:00:00 2001 From: FBumann <117816358+FBumann@users.noreply.github.com> Date: Wed, 11 Mar 2026 08:27:15 +0100 Subject: [PATCH 4/5] chore: use plain fluxopt dep instead of git URL Co-Authored-By: Claude Opus 4.6 --- pyproject.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 2dbf4d6..3f28260 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -26,7 +26,7 @@ classifiers = [ "Topic :: Scientific/Engineering :: Visualization", ] dependencies = [ - "fluxopt>=0.0.1rc0", + "fluxopt", "plotly>=6", ] @@ -44,7 +44,7 @@ include = ["src/fluxopt_plot/", "LICENSE", "README.md"] [dependency-groups] dev = [ - "fluxopt @ git+https://github.com/FBumann/fluxopt.git", + "fluxopt", "mypy==1.19.1", "pre-commit==4.5.1", "pytest==9.0.2", From 54c3f490333486eabffc9449fd5ecc9bfc76bff0 Mon Sep 17 00:00:00 2001 From: FBumann <117816358+FBumann@users.noreply.github.com> Date: Wed, 11 Mar 2026 08:36:26 +0100 Subject: [PATCH 5/5] chore: allow fluxopt prereleases and remove duplicate dev dep Co-Authored-By: Claude Opus 4.6 --- pyproject.toml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 3f28260..ef91830 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -26,7 +26,7 @@ classifiers = [ "Topic :: Scientific/Engineering :: Visualization", ] dependencies = [ - "fluxopt", + "fluxopt>=0.0.1a0", "plotly>=6", ] @@ -44,7 +44,6 @@ include = ["src/fluxopt_plot/", "LICENSE", "README.md"] [dependency-groups] dev = [ - "fluxopt", "mypy==1.19.1", "pre-commit==4.5.1", "pytest==9.0.2",