From 7070f54649ced838f4b86538d7057e186f89221e Mon Sep 17 00:00:00 2001 From: "Rory Abraham (via MelvinBot)" Date: Tue, 11 Aug 2026 23:59:01 +0000 Subject: [PATCH] Drop obsolete expo-modules-jsi Xcode 26.2 type-inference patch The patch worked around a Swift type-inference bug specific to Xcode 26.2. The iOS build pipeline now uses Xcode 26.6 (Expensify/App#97774), so this workaround should no longer be needed. Removing it to verify a clean build. Co-authored-by: Rory Abraham --- patches/expo-modules-jsi/details.md | 8 -------- ...si+57.0.4+001+fix-xcode-26-2-type-inference.patch | 12 ------------ 2 files changed, 20 deletions(-) delete mode 100644 patches/expo-modules-jsi/details.md delete mode 100644 patches/expo-modules-jsi/expo-modules-jsi+57.0.4+001+fix-xcode-26-2-type-inference.patch diff --git a/patches/expo-modules-jsi/details.md b/patches/expo-modules-jsi/details.md deleted file mode 100644 index 8f374ef9656f..000000000000 --- a/patches/expo-modules-jsi/details.md +++ /dev/null @@ -1,8 +0,0 @@ -# `expo-modules-jsi` patches - -### [expo-modules-jsi+57.0.4+001+fix-xcode-26-2-type-inference.patch](expo-modules-jsi+57.0.4+001+fix-xcode-26-2-type-inference.patch) - -- Reason: Qualifies Swift's `abs` function to avoid an Xcode 26.2 type-inference failure when building the `ExpoModulesJSI` XCFramework in Swift 6 mode. -- Upstream PR/issue: 🛑 -- E/App issue: https://github.com/Expensify/App/issues/96278 -- PR introducing patch: https://github.com/Expensify/App/pull/96372 diff --git a/patches/expo-modules-jsi/expo-modules-jsi+57.0.4+001+fix-xcode-26-2-type-inference.patch b/patches/expo-modules-jsi/expo-modules-jsi+57.0.4+001+fix-xcode-26-2-type-inference.patch deleted file mode 100644 index 116bf1a9e814..000000000000 --- a/patches/expo-modules-jsi/expo-modules-jsi+57.0.4+001+fix-xcode-26-2-type-inference.patch +++ /dev/null @@ -1,12 +0,0 @@ -diff --git a/node_modules/expo-modules-jsi/apple/Sources/ExpoModulesJSI/Coding/JavaScriptCodable+Date.swift b/node_modules/expo-modules-jsi/apple/Sources/ExpoModulesJSI/Coding/JavaScriptCodable+Date.swift ---- a/node_modules/expo-modules-jsi/apple/Sources/ExpoModulesJSI/Coding/JavaScriptCodable+Date.swift -+++ b/node_modules/expo-modules-jsi/apple/Sources/ExpoModulesJSI/Coding/JavaScriptCodable+Date.swift -@@ -50,7 +50,7 @@ let maxJavaScriptDateMilliseconds: Double = 8_640_000_000_000_000 - /// faithful to `new Date(number)`; the `Date`/string branches pass an already-clipped `getTime()` through. - @usableFromInline - func dateFromMilliseconds(_ milliseconds: Double) throws -> Date { -- guard milliseconds.isFinite, abs(milliseconds) <= maxJavaScriptDateMilliseconds else { -+ guard milliseconds.isFinite, Swift.abs(milliseconds) <= maxJavaScriptDateMilliseconds else { - throw InvalidDateException() - } - return Date(timeIntervalSince1970: milliseconds.rounded(.towardZero) / 1000.0)