[Awaiting Payment 2024-01-30] [$2000] We can send an empty message using dictation on iPhone

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App
2. Go to any chat
3. Press on the message composer
4. Press the mic icon from the keyboard and do not speak anything
5. Press the mic icon again to stop dictation

Expected Result:

If we have not spoken anything then send button should have to be disabled

Actual Result:

Send button is enabled on an empty message and we can send the empty message in the chat

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

dictate-bug.MP4

VSSR0553.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682627289846559

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fe24292fbc44e5d8
• Upwork Job ID: 1651956178824339456
• Last Price Increase: 2023-05-08

[MelvinBot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We can send an empty message using dictation on iPhone

What is the root cause of that problem?

We are checking if comment is empty to disable the send button, however the result return from empty dictation in iPhone was a escape character \ufffc, that's why our regex didn't work and button still can be enable.

App/src/pages/home/report/ReportActionCompose.js

Line 578 in 6fb0969

isCommentEmpty: !!newComment.match(/^(\s)*$/),

What changes do you think we should make in order to solve the problem?

Add more condition to our isCommentEmpty's regex to prevent such thing. So our regex will look like:

isCommentEmpty: !!newComment.match(/^(\s|\ufffc)*$/),

What alternative solutions did you explore? (Optional)

None.

Result:

Screen.Recording.2023-04-28.at.10.08.56.mov

[trjExpensify]

I can reliably reproduce this. Moving on External.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01fe24292fbc44e5d8

[MelvinBot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)