modify behavior of function according to new agreed one

Author: feyruzb

web/api/report_server.thrift

@@ -594,26 +594,26 @@ service codeCheckerDBAccess {
   //============================================
 
   // Stores the given FilterPreset with the given id
-  // If the preset exists, it overwrites the name, and all preset values
-  // if the preset does not exist yet, it creates it with
-  // if the id is -1 a new preset filter is created
-  // the filter preset name must be unique.
-  // An error must be thrown if another preset exists with the same name.
-  // The encoding of the name must be unicode. (whitespaces allowed?)
-  // Returns: the id of the modified or created preset, -1 in case of error
+  // If the preset exists with the given id, it overwrites the name, and all preset values
+  // if the preset does not exist yet, throws and error
+  // if the id is -1 a new preset filter is created and the id of the new preset is returned.
+  // If a preset with that name already existed, it throws an error. Thus the filter preset name must be unique.
+  // The encoding of the name must be unicode. (whitespaces allowed)
+  // Maximum filter preset name 50
+  // Returns: the id of the modified or created preset
   // PERMISSION: PRODUCT_ADMIN
   i64 storeFilterPreset(1: FilterPreset preset)
                       throws (1: codechecker_api_shared.RequestFailed requestError);
 
   // Returns the FilterPreset identified by id
-  // Returns -1 in case there is no preset with the given id
+  // Throws and error in case there is no preset with the given id
   // PERMISSION: PRODUCT_VIEW
   FilterPreset getFilterPreset(1: i64 id)
                             throws (1: codechecker_api_shared.RequestFailed requestError);
 
-  // Removes the filterpreset with the given id
+  // Removes the filter preset with the given id
   // returns the id of the filter preset removed
-  // and -1 in case of error.
+  // throws an error if the preset with the given id does not exist.
   // PERMISSION: PRODUCT_ADMIN
   i64 deleteFilterPreset(1: i64 id)
                         throws (1: codechecker_api_shared.RequestFailed requestError);

web/server/codechecker_server/api/report_server.py

@@ -1751,7 +1751,6 @@ def to_jsonable(obj):
 
                     session.add(preset_entry)
                     session.commit()
-                    print(f"Created new filter preset with name '{name}' and id {preset_entry.id}")
                     return preset_entry.id
 
                 # case for updating an existing preset
@@ -1767,7 +1766,6 @@ def to_jsonable(obj):
                 preset_entry.preset_name = name
                 preset_entry.report_filter = report_filter
                 session.commit()
-                print(f"Updated filter preset id {id} with name '{name}'")
                 return preset_entry.id
         except Exception as ex:
             session.rollback()
@@ -1790,8 +1788,12 @@ def deleteFilterPreset(self, preset_id):
             with DBSession(self._Session) as session:
                 preset = session.query(FilterPreset). \
                     filter(FilterPreset.id == preset_id).one_or_none()
+
                 if not preset:
-                    return -1
+                    raise codechecker_api_shared.ttypes.RequestFailed(
+                        codechecker_api_shared.ttypes.ErrorCode.DATABASE,
+                        f"No filter preset found with id {preset_id}!")
+
 
                 session.query(FilterPreset) \
                     .filter(FilterPreset.id == preset_id) \
@@ -1822,7 +1824,9 @@ def getFilterPreset(self, preset_id):
                 )
 
             if preset is None:
-                return -1
+                raise codechecker_api_shared.ttypes.RequestFailed(
+                    codechecker_api_shared.ttypes.ErrorCode.DATABASE,
+                    f"No filter preset found with id {preset_id}!")
 
             # Pre creation of variables that are objects themselves.
             report_filter = tranform_rf_db_to_thrift(preset.report_filter)