Throw an ISE on attempting to modify a bazel profile thread after being sorted

Signed-off-by: Felipe <afrueda97@outlook.com>

Author: afrueda97

analyzer/java/com/engflow/bazel/invocation/analyzer/bazelprofile/ProfileThread.java

@@ -112,8 +112,14 @@ public Integer getSortIndex() {
   /**
    * Parses a {@link JsonObject} as a tracing event and adds it to this thread. Returns {@code true}
    * if parsing and adding the event was successful and {@code false} otherwise.
+   *
+   * @throws IllegalStateException if the thread has already been sorted, and as such cannot be
+   *     modified anymore.
    */
   public boolean addEvent(JsonObject event) {
+    if (sorted) {
+      throw new IllegalStateException("Cannot add event, Bazel profile thread has been sorted!");
+    }
     try {
       switch (event.get(TraceEventFormatConstants.EVENT_PHASE).getAsString()) {
         case TraceEventFormatConstants.PHASE_COMPLETE: // Complete events

analyzer/javatests/com/engflow/bazel/invocation/analyzer/bazelprofile/BUILD

@@ -14,6 +14,7 @@ java_test(
         "//analyzer/java/com/engflow/bazel/invocation/analyzer/time",
         "//analyzer/java/com/engflow/bazel/invocation/analyzer/traceeventformat",
         "//analyzer/javatests/com/engflow/bazel/invocation/analyzer:test_base",
+        "//third_party/gson",
         "//third_party/guava",
         "//third_party/junit",
         "//third_party/truth",

analyzer/javatests/com/engflow/bazel/invocation/analyzer/bazelprofile/BazelProfileTest.java

@@ -40,6 +40,7 @@
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.Lists;
+import com.google.gson.JsonObject;
 import java.io.ByteArrayInputStream;
 import java.nio.charset.StandardCharsets;
 import java.util.stream.IntStream;
@@ -349,6 +350,63 @@ public void getActionCountsMixedUsesNew()
     assertThat(profile.getActionCounts().get().size()).isEqualTo(201);
   }
 
+  @Test
+  public void addEventShouldThrowOnSortedProfileThread() throws Exception {
+    var name = "CPP";
+    var want =
+        new ProfileThread(
+            new ThreadId(1, 1),
+            BazelProfileConstants.THREAD_CRITICAL_PATH,
+            0,
+            ImmutableList.of(),
+            ImmutableList.of(),
+            Lists.newArrayList(
+                new CompleteEvent(
+                    name,
+                    BazelProfileConstants.CAT_CRITICAL_PATH_COMPONENT,
+                    Timestamp.ofMicros(11),
+                    TimeUtil.getDurationForMicros(10),
+                    1,
+                    1,
+                    ImmutableMap.of()),
+                new CompleteEvent(
+                    name,
+                    BazelProfileConstants.CAT_CRITICAL_PATH_COMPONENT,
+                    Timestamp.ofMicros(21),
+                    TimeUtil.getDurationForMicros(10),
+                    1,
+                    1,
+                    ImmutableMap.of()),
+                new CompleteEvent(
+                    name,
+                    BazelProfileConstants.CAT_CRITICAL_PATH_COMPONENT,
+                    Timestamp.ofMicros(31),
+                    TimeUtil.getDurationForMicros(10),
+                    1,
+                    1,
+                    ImmutableMap.of()),
+                new CompleteEvent(
+                    name,
+                    BazelProfileConstants.CAT_CRITICAL_PATH_COMPONENT,
+                    Timestamp.ofMicros(50),
+                    TimeUtil.getDurationForMicros(10),
+                    1,
+                    1,
+                    ImmutableMap.of())),
+            ImmutableMap.of(),
+            ImmutableMap.of());
+
+    // Getting the completeEvents from the thread will trigger them to be sorted.
+    var sorted = want.getCompleteEvents();
+    // At this point, any further attempts at modifying the thread should throw an ISE, as this
+    // would break the sorting that was previously done.
+    var exception =
+        assertThrows(IllegalStateException.class, () -> want.addEvent(new JsonObject()));
+    assertThat(exception)
+        .hasMessageThat()
+        .isEqualTo("Cannot add event, Bazel profile thread has been sorted!");
+  }
+
   @Test
   public void isMainThreadShouldReturnFalseOnUnnamedProfileThread() {
     ProfileThread thread = new ProfileThread(new ThreadId(0, 0));