Test cyclical price calculation with more complex cycles

[tsmbland]

We should add a regression test containing a cycle with more than 2 nodes. Easiest approach would be to just add one or more extra flows to the existing circularity example (e.g. gas extraction requires electricity).

A problem with this currently is that most complex cycles fail due to limitations with the investment algorithm (discussed in #1089).

A couple of approaches:

• run the model only for the first year, as no investments take place in the first year
• wait until we fix the issues with investments

[alexdewar]

While it would be nice to have the extra coverage, even if that means having a model that only runs for one year, I'm not sure it would be a great example, so I'm slightly reluctant to include it, unless we think we'll fix things and be able to have it run for more years before we make the next release? Essentially it wouldn't be a great example for users.

We could always make it a patch example, then it will be hidden from users. There's currently no other way to hide examples from users, but we could add one, if we think that's something we'll want in future.

[tsmbland]

Yes, was thinking this would be a patch, at least for now. All you need is to add one extra flow to the existing circularity model

[alexdewar]

Hi @AlexisST24. @tsmbland mentioned you were looking at this, so I've assigned the issue to you.