-
-
Notifications
You must be signed in to change notification settings - Fork 23
Version Check Not Detecting Change Past 20 Commits #287
Copy link
Copy link
Open
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededstatus: pinnedShould not be labeled as staleShould not be labeled as staletype: featureNew feature or feature requestNew feature or feature request
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededstatus: pinnedShould not be labeled as staleShould not be labeled as staletype: featureNew feature or feature requestNew feature or feature request
Based on reading the source code, I understand that once there are more than 20+ commits, the GHA is limited and may not check all commits for a package.json version change.
However, in the code, if a commit message contains the release version and it matches the packageObj.version then it should find and detect the change (here).
For context, these are the settings of the action when I run it:
So, since there are 20+ commits, it is not checking every commit for a package.json version update which is expected. But even when I do a later commit with a semver version in the message, it doesn't detect it. Is that expected too??
Proposed solution:
Can commits somehow be reversed so that the most recent 20 commits are checked instead of the first 20? Or can there be a flag to allow this to happen? I'm not entirely sure where this change would go (here maybe?).