Why is it better to replace Newtonsoft.Json

[ddikhtyar]

Newtonsoft.Json puts a limit on the popularity of the entire Electron.NET because many corporations have included this package in the banned list.

[liebki]

@ddikhtyar why is it on ban lists?

[ddikhtyar]

because the vulnerabilities prevent the security department from allowing its use.

[Denny09310]

If @FlorianRappl and @GregorBiswanger are interested, since they're currently testing the alpha with the new architecture, I can try and work on replacing all Newtonsoft.Json usages with System.Text.Json, assuming there's no specific reason to avoid making this change.

[softworkz]

Hm, and all other tests are running fine?
You're on Windows? Visual Studio?
Did you "Rebuild solution" (creates errors), then "Build Solution "(no errors)?

[softworkz]

If that doesn't help, we'll need to find out where it hangs.. Debug and use breakpoints rather than stepping:

[Denny09310]

Yes all good.

This will help: taskkill /f /im electron.exe

That was the problem, I didn't noticed orphaned processes. Thanks again

[Denny09310]

I was able to integrate your tests in my branch and migrate to System.Text.Json, all but one test (except for the two already failing) are passing 😁

[softworkz]

Now that the test provides a fixed pattern, you can run Wireshark on the local loopback interface and execute the failing test once with and once without JSON migration.
Then you can compare the payloads which go over the wire.

I had looked for but not found a public interception point in SocketIO, otherwise I had created unit tests as well (without Electron running) - so Wireshark is probably the best bet.