fixed creashes

Author: Earth1283

pymcl/main_window.py

@@ -147,7 +147,7 @@ def init_ui(self):
         left_widget = QWidget()
         left_widget.setObjectName("left_title_container")
         # Ensure the widget itself has transparent bg if styled otherwise in stylesheet
-        left_widget.setAttribute(Qt.WidgetAttribute.WA_TranslucentBackground)
+        left_widget.setAttribute(Qt.WidgetAttribute.WA_StyledBackground)
 
         left_layout = QVBoxLayout(left_widget)
         left_layout.setSpacing(5)

pymcl/mod_browser.py

@@ -159,9 +159,14 @@ def on_search_text_changed(self, text):
         self.search_timer.start()
 
     def populate_results(self):
-        # Clear existing results
+        # Clear existing results safely
         for i in reversed(range(self.results_layout.count())):
-            self.results_layout.itemAt(i).widget().setParent(None)
+            item = self.results_layout.itemAt(i)
+            if item:
+                widget = item.widget()
+                if widget:
+                    widget.setParent(None)
+                    widget.deleteLater()
 
         if not self.search_results:
             self.results_layout.addWidget(QLabel("No results found."), 0, 0, 1, 3)
@@ -194,7 +199,10 @@ def on_icon_downloaded(self, mod_id, icon_path):
             return
 
         for i in range(self.results_layout.count()):
-            widget = self.results_layout.itemAt(i).widget()
+            item = self.results_layout.itemAt(i)
+            if not item:
+                continue
+            widget = item.widget()
             if isinstance(widget, ModListItem) and widget.mod_data.get("project_id") == mod_id:
                 widget.set_icon(icon_path)
                 break

pymcl/mod_manager.py

@@ -168,9 +168,15 @@ def on_updates_found(self, updates):
         self.check_updates_button.setEnabled(True)
         self.check_updates_button.setText("Check for Mod Updates")
 
+        if not updates:
+            self.download_status_label.setText("All mods are up to date.")
+            return
+
         count = 0
         for i in range(self.mod_list_widget.count()):
             item = self.mod_list_widget.item(i)
+            if not item:
+                continue
             mod_path = item.data(Qt.ItemDataRole.UserRole)
             widget = self.mod_list_widget.itemWidget(item)
 
@@ -227,7 +233,15 @@ def get_mods_directory(self):
 
     @pyqtSlot()
     def populate_mods_list(self):
+        # Clear list widget correctly
+        for i in range(self.mod_list_widget.count()):
+            item = self.mod_list_widget.item(i)
+            if item:
+                widget = self.mod_list_widget.itemWidget(item)
+                if widget:
+                    widget.deleteLater()
         self.mod_list_widget.clear()
+
         try:
             mods_dir = self.get_mods_directory()
             if not os.path.exists(mods_dir):

pymcl/modrinth_client.py

@@ -25,7 +25,11 @@ def search(self, query, game_versions=None, loader=None, limit=20):
         try:
             response = self.session.get(f"{self.BASE_URL}/search", params=params, timeout=15)
             response.raise_for_status()
-            return response.json().get("hits", [])
+            try:
+                data = response.json()
+                return data.get("hits", []) if isinstance(data, dict) else []
+            except (json.JSONDecodeError, ValueError):
+                return []
         except requests.RequestException as e:
             print(f"Error searching Modrinth: {e}")
             return []
@@ -34,7 +38,10 @@ def get_project(self, slug):
         try:
             response = self.session.get(f"{self.BASE_URL}/project/{slug}", timeout=15)
             response.raise_for_status()
-            return response.json()
+            try:
+                return response.json()
+            except (json.JSONDecodeError, ValueError):
+                return {}
         except requests.RequestException as e:
             print(f"Error getting project from Modrinth: {e}")
             return {}
@@ -49,7 +56,10 @@ def get_updates(self, file_hashes):
             )
             response.raise_for_status()
             print("ModrinthClient: Successfully received update response.")
-            return response.json()
+            try:
+                return response.json()
+            except (json.JSONDecodeError, ValueError):
+                return {}
         except requests.RequestException as e:
             print(f"ModrinthClient: Error getting updates: {e}")
             return {}
@@ -64,7 +74,10 @@ def get_versions(self, mod_id, game_versions=None, loader=None):
         try:
             response = self.session.get(f"{self.BASE_URL}/project/{mod_id}/version", params=params, timeout=15)
             response.raise_for_status()
-            return response.json()
+            try:
+                return response.json()
+            except (json.JSONDecodeError, ValueError):
+                return []
         except requests.RequestException as e:
             print(f"Error getting versions from Modrinth: {e}")
             return []

pymcl/servers_page.py

@@ -87,9 +87,10 @@ def clear_list_ui(self):
         # Remove all widgets from layout except the stretch
         while self.list_layout.count() > 1:
             item = self.list_layout.takeAt(0)
-            widget = item.widget()
-            if widget:
-                widget.deleteLater()
+            if item:
+                widget = item.widget()
+                if widget:
+                    widget.deleteLater()
 
     @pyqtSlot()
     def add_server(self):
@@ -121,7 +122,10 @@ def remove_server(self, ip):
             # Find and remove widget
             for i in range(self.list_layout.count()):
                 item = self.list_layout.itemAt(i)
+                if not item:
+                    continue
                 widget = item.widget()
                 if isinstance(widget, ServerCard) and widget.ip == ip:
+                    self.list_layout.takeAt(i)
                     widget.deleteLater()
                     break

pymcl/skin_manager.py

@@ -105,27 +105,27 @@ def paintEvent(self, event):
         painter = QPainter(self)
         painter.setRenderHint(QPainter.RenderHint.Antialiasing, False) # Keep pixel look
 
-        if not self.raw_skin:
+        if not self.raw_skin or self.raw_skin.isNull():
             # Draw placeholder text centered
             painter.setPen(Qt.GlobalColor.white)
             painter.drawText(self.rect(), Qt.AlignmentFlag.AlignCenter, "No Skin Loaded")
             return
 
-        # Basic 2D Front View Mapping
-        # Head: 8,8 (8x8)
-        # Body: 20,20 (8x12)
-        # Arms: 44,20 (4x12) - Note: Alex/Slim is 3x12
-        # Legs: 4,20 (4x12)
-
         # Scaling
         s = 16 # Draw scale
 
         # Center X
         cx = self.width() // 2
         cy = 50
 
+        sw = self.raw_skin.width()
+        sh = self.raw_skin.height()
+
         # Helper to draw rect from skin to screen
         def draw_part(sx, sy, w, h, dx, dy):
+            # Safety check for dimensions
+            if sx + w > sw or sy + h > sh:
+                return
             part = self.raw_skin.copy(sx, sy, w, h).scaled(w*s, h*s, Qt.AspectRatioMode.IgnoreAspectRatio)
             painter.drawPixmap(dx, dy, part)
 
@@ -261,8 +261,14 @@ def refresh_skin(self):
             return
 
         self.status_label.setText("Fetching skin...")
+        if self.fetcher and self.fetcher.isRunning():
+            self.fetcher.terminate()
+            self.fetcher.wait()
+
         self.fetcher = SkinFetcher(uuid)
         self.fetcher.finished.connect(self.on_skin_fetched)
+        self.fetcher.finished.connect(self.fetcher.quit)
+        self.fetcher.finished.connect(self.fetcher.deleteLater)
         self.fetcher.start()
 
     @pyqtSlot(QPixmap, bool)
@@ -286,8 +292,14 @@ def upload_skin(self):
         token = self.minecraft_info.get("access_token")
 
         self.status_label.setText("Uploading skin...")
+        if self.uploader and self.uploader.isRunning():
+             self.uploader.terminate()
+             self.uploader.wait()
+
         self.uploader = SkinUploader(token, file_path, variant)
         self.uploader.finished.connect(self.on_upload_finished)
+        self.uploader.finished.connect(self.uploader.quit)
+        self.uploader.finished.connect(self.uploader.deleteLater)
         self.uploader.start()
 
     @pyqtSlot(bool, str)

pymcl/stylesheet.py

@@ -231,7 +231,7 @@
 }
 
 QWidget#left_title_container {
-    background-color: rgba(15, 17, 21, 0.65);
+    background-color: rgba(10, 12, 16, 0.85);
     border: 1px solid rgba(255, 255, 255, 0.08);
     border-radius: 20px;
     padding: 15px;
@@ -250,7 +250,7 @@
 QPushButton#nav_button, QPushButton#nav_button_active {
     background-color: transparent;
     border: 1px solid transparent;
-    color: #9ca3af;
+    color: #e5e7eb;
     font-size: 15px;
     font-weight: 600;
     text-align: left;