fix(ocpp16): Send invalid fw signature security event (#1125)

mlitre · stephenredhat · commit 13751e456aa5 · 2025-08-11T12:41:05.000+01:00
Invalid firmware signature security event is forced as a critical event to comply with TC_081_CS.

Signed-off-by: Martin Litre &lt;mnlitre@gmail.com&gt;
diff --git a/lib/ocpp/v16/charge_point_impl.cpp b/lib/ocpp/v16/charge_point_impl.cpp
@@ -3041,7 +3041,8 @@ void ChargePointImpl::signed_firmware_update_status_notification(FirmwareStatusE
     this->message_dispatcher->dispatch_call(call, initiated_by_trigger_message);
 
     if (status == FirmwareStatusEnumType::InvalidSignature) {
-        this->securityEventNotification(ocpp::security_events::INVALIDFIRMWARESIGNATURE, std::nullopt, true);
+        // Force critical status to send event to comply with TC_081_CS
+        this->securityEventNotification(ocpp::security_events::INVALIDFIRMWARESIGNATURE, std::nullopt, true, true);
     }
 
     if (this->firmware_update_is_pending) {

Original file line number	Diff line number	Diff line change
`@@ -3041,7 +3041,8 @@ void ChargePointImpl::signed_firmware_update_status_notification(FirmwareStatusE`
`3041`	`3041`	`this->message_dispatcher->dispatch_call(call, initiated_by_trigger_message);`
`3042`	`3042`
`3043`	`3043`	`if (status == FirmwareStatusEnumType::InvalidSignature) {`
`3044`		`- this->securityEventNotification(ocpp::security_events::INVALIDFIRMWARESIGNATURE, std::nullopt, true);`
	`3044`	`+ // Force critical status to send event to comply with TC_081_CS`
	`3045`	`+ this->securityEventNotification(ocpp::security_events::INVALIDFIRMWARESIGNATURE, std::nullopt, true, true);`
`3045`	`3046`	`}`
`3046`	`3047`
`3047`	`3048`	`if (this->firmware_update_is_pending) {`