The raw abm data (peak crop-fire month) should be 14 (invalid value) where crop = 0%

[slevis-lmwg]

This issue continues from #3224 where we made the following improvements to mksurfdata_esmf:

• Included "no crop fire" (value 13) in the calculation of dominant abm (peak crop-fire month), rather than picking the dominant from range 1 to 12. The latter overestimated crop fire, while this improvement got too many 13s and underestimated crop fire.
• Included "invalid" (value 14 for ocean, determined from abm's LANDMASK) not to be included in the calculation of dominant, so as to get fewer dominant 13s along coastlines. Fang Li finds that we still get more 13s than she would like.

So now we propose that @lifang0209 change the abm raw data to 14 where the MODIS data shows crop 0%:

• The new abm raw data will range 1 to 13 in grid cells with crop > 0% and 14 in grid cells with crop = 0%. This will eliminate dominant 13s that came from non-agricultural areas before.
• We propose that @lifang0209 make the change using data directly from MODIS (rather than using clm's pct_crop which has many assumptions built into it).
• We acknowledge that the abm raw data was and will continue to be inconsistent with past and future crop distributions, but we have no good way around that currently.

Definition of DONE

• @lifang0209 generates new abm raw dataset with value 14 (invalid value) where crop = 0%
• @slevis-lmwg generates new f19 1850 78pft fsurdat
• @lifang0209 conducts testing with the new f19 fsurdat
• @lifang0209 provides script that generates this new abm raw dataset placed in tools/contrib for availability in the future
• @slevis-lmwg copies the new raw dataset to /inputdata

---

• @slevis-lmwg updates abm raw dataset in gen_mksurfdata_namelist.xml
• make new 5.4 branch tag alpha-ctsm5.4.CMIP7.04.ctsm5.3.063 with Prepare to make ctsm54 datasets #3233 (expected)
• make new 5.4 branch tag alpha-ctsm5.4.CMIP7.05.ctsm5.3.063 with Urban mesh was pointing to a 3x3min instead of a 0.25x0.25 file #3347 (unexpected correction)
• use this tag to update 5.4 datasets, only ne30, f09, and f19 for testing (fsurdat/landuse files being generated currently)
• add surface datasets to xml defaults and make new 5.4 branch tag

@lifang0209 @samsrabin
I welcome comments and corrections

[ekluzek]

Adding next, so we talk about the current status of this. There's been work done, but more things need to be tried.