Merge pull request #388 from ben-schwen/as.data.frame_defaultArgs

xiaodaigh · web-flow · commit e589d90b15b9 · 2023-02-01T23:24:41.000+11:00
add default arguments to as.data.frame.disk.frame
diff --git a/R/as.data.frame.r b/R/as.data.frame.r
@@ -10,7 +10,7 @@
 #' 
 #' # clean up
 #' delete(cars.df)
-as.data.frame.disk.frame <- function(x, row.names, optional, ...) { # needs to retain x for consistency
+as.data.frame.disk.frame <- function(x, row.names = NULL, optional = FALSE, ...) { # needs to retain x for consistency
   as.data.frame(collect(x), row.names, optional, ...)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`#'`
`11`	`11`	`#' # clean up`
`12`	`12`	`#' delete(cars.df)`
`13`		`-as.data.frame.disk.frame <- function(x, row.names, optional, ...) { # needs to retain x for consistency`
	`13`	`+as.data.frame.disk.frame <- function(x, row.names = NULL, optional = FALSE, ...) { # needs to retain x for consistency`
`14`	`14`	`as.data.frame(collect(x), row.names, optional, ...)`
`15`	`15`	`}`
`16`	`16`