diff --git a/apps/roam/src/components/LeftSidebarView.tsx b/apps/roam/src/components/LeftSidebarView.tsx index 46ca39cc5..a3306f66c 100644 --- a/apps/roam/src/components/LeftSidebarView.tsx +++ b/apps/roam/src/components/LeftSidebarView.tsx @@ -52,9 +52,8 @@ import deleteBlock from "roamjs-components/writes/deleteBlock"; import getTextByBlockUid from "roamjs-components/queries/getTextByBlockUid"; import refreshConfigTree from "~/utils/refreshConfigTree"; import { Dispatch, SetStateAction } from "react"; -import { SettingsDialog } from "./settings/Settings"; +import { openSettingsDialog } from "./settings/Settings"; import { OnloadArgs } from "roamjs-components/types"; -import renderOverlay from "roamjs-components/util/renderOverlay"; import getBasicTreeByParentUid from "roamjs-components/queries/getBasicTreeByParentUid"; import { DISCOURSE_CONFIG_PAGE_TITLE } from "~/data/constants"; import getPageTitleByPageUid from "roamjs-components/queries/getPageTitleByPageUid"; @@ -445,12 +444,9 @@ const FavoritesPopover = ({ onloadArgs }: { onloadArgs: OnloadArgs }) => { }, [handleGlobalPointerDownCapture, isMenuOpen]); const renderSettingsDialog = (tabId: TabId) => { - renderOverlay({ - Overlay: SettingsDialog, - props: { - onloadArgs, - selectedTabId: tabId, - }, + openSettingsDialog({ + onloadArgs, + selectedTabId: tabId, }); }; diff --git a/apps/roam/src/components/settings/Settings.tsx b/apps/roam/src/components/settings/Settings.tsx index 80c35bdcd..48a44aeb5 100644 --- a/apps/roam/src/components/settings/Settings.tsx +++ b/apps/roam/src/components/settings/Settings.tsx @@ -50,7 +50,7 @@ export const SettingsPanel = ({ onloadArgs }: { onloadArgs: OnloadArgs }) => {