From 98af9b197712d9a4c85e2a283a0d96cf7431b1c5 Mon Sep 17 00:00:00 2001
From: Trang Doan <doantranghp2000@gmail.com>
Date: Mon, 11 May 2026 08:58:51 -0700
Subject: [PATCH 1/4] ENG-1693 Add insert backlink checkbox to ModifyNodeModal
 with smart defaults

- Add "Insert backlink" checkbox to ModifyNodeModal (create mode only)
- Default true when pre-filled text exists (user had text selected) or existing node is chosen; false otherwise
- Gate backlink insertion in canvas flow and editor command flow on checkbox value

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 .../src/components/ModifyNodeModal.tsx        | 28 +++++++++++++++++--
 .../canvas/utils/nodeCreationFlow.ts          | 13 +++++----
 apps/obsidian/src/utils/createNode.ts         |  2 +-
 apps/obsidian/src/utils/registerCommands.ts   |  8 ++++--
 4 files changed, 40 insertions(+), 11 deletions(-)

diff --git a/apps/obsidian/src/components/ModifyNodeModal.tsx b/apps/obsidian/src/components/ModifyNodeModal.tsx
index 6c4107cb9..f14a42f8e 100644
--- a/apps/obsidian/src/components/ModifyNodeModal.tsx
+++ b/apps/obsidian/src/components/ModifyNodeModal.tsx
@@ -1,4 +1,4 @@
-import { App, Modal, Notice, TFile } from "obsidian";
+import { App, MarkdownView, Modal, Notice, TFile } from "obsidian";
 import { createRoot, Root } from "react-dom/client";
 import {
   StrictMode,
@@ -49,6 +49,7 @@ type ModifyNodeFormProps = {
     /** DiscourseRelation.id; when set, relation is created with currentFile as the other end. */
     relationshipId?: string;
     relationshipTargetFile?: TFile;
+    insertBacklink: boolean;
   }) => Promise<void>;
   onCancel: () => void;
   initialTitle?: string;
@@ -83,6 +84,9 @@ export const ModifyNodeForm = ({
   const [selectedRelationshipKey, setSelectedRelationshipKey] = useState<
     string | undefined
   >(undefined);
+  const hasEditorContext =
+    plugin.app.workspace.activeLeaf?.view instanceof MarkdownView;
+  const [insertBacklink, setInsertBacklink] = useState(!!initialTitle);
   const queryEngine = useRef(new QueryEngine(plugin.app));
   const titleInputRef = useRef<HTMLTextAreaElement>(null);
   const popoverRef = useRef<HTMLDivElement>(null);
@@ -278,6 +282,7 @@ export const ModifyNodeForm = ({
       setSelectedExistingNode(file);
       setQuery(file.basename);
       setTitle(file.basename);
+      setInsertBacklink(true);
       // Auto-detect node type from the selected file's frontmatter
       const nodeTypeId = await getNodeTypeIdForFile(plugin, file);
       if (nodeTypeId && selectedFileRef.current === file) {
@@ -291,12 +296,13 @@ export const ModifyNodeForm = ({
   const handleClearSelection = useCallback(() => {
     selectedFileRef.current = null;
     setSelectedExistingNode(null);
+    setInsertBacklink(!!initialTitle);
     setQuery("");
     setTitle("");
     setTimeout(() => {
       titleInputRef.current?.focus();
     }, 50);
-  }, []);
+  }, [initialTitle]);
 
   const handleKeyDown = (e: React.KeyboardEvent<HTMLTextAreaElement>) => {
     if (selectedExistingNode) {
@@ -391,6 +397,7 @@ export const ModifyNodeForm = ({
         selectedExistingNode: selectedExistingNode || undefined,
         relationshipId: selectedRel?.uniqueKey || undefined,
         relationshipTargetFile: currentFile || undefined,
+        insertBacklink,
       });
       onCancel();
     } catch (error) {
@@ -418,6 +425,7 @@ export const ModifyNodeForm = ({
     selectedRelationshipKey,
     currentFile,
     availableRelationships,
+    insertBacklink,
   ]);
 
   return (
@@ -568,6 +576,20 @@ export const ModifyNodeForm = ({
         </div>
       )}
 
+      {!isEditMode && hasEditorContext && (
+        <div className="setting-item">
+          <div className="setting-item-name">Insert backlink</div>
+          <div className="setting-item-control">
+            <input
+              type="checkbox"
+              checked={insertBacklink}
+              onChange={(e) => setInsertBacklink(e.target.checked)}
+              disabled={isSubmitting}
+            />
+          </div>
+        </div>
+      )}
+
       <div className="modal-button-container mt-5 flex justify-end gap-2">
         <button
           type="button"
@@ -606,6 +628,7 @@ type ModifyNodeModalProps = {
     selectedExistingNode?: TFile;
     relationshipId?: string;
     relationshipTargetFile?: TFile;
+    insertBacklink: boolean;
   }) => Promise<void>;
   initialTitle?: string;
   initialNodeType?: DiscourseNode;
@@ -622,6 +645,7 @@ class ModifyNodeModal extends Modal {
     selectedExistingNode?: TFile;
     relationshipId?: string;
     relationshipTargetFile?: TFile;
+    insertBacklink: boolean;
   }) => Promise<void>;
   private root: Root | null = null;
   private initialTitle?: string;
diff --git a/apps/obsidian/src/components/canvas/utils/nodeCreationFlow.ts b/apps/obsidian/src/components/canvas/utils/nodeCreationFlow.ts
index 54dbc2e13..1f3014ea9 100644
--- a/apps/obsidian/src/components/canvas/utils/nodeCreationFlow.ts
+++ b/apps/obsidian/src/components/canvas/utils/nodeCreationFlow.ts
@@ -32,6 +32,7 @@ export const openCreateDiscourseNodeAt = (args: CreateNodeAtArgs): void => {
       selectedExistingNode,
       relationshipId,
       relationshipTargetFile,
+      insertBacklink,
     }) => {
       try {
         // If user selected an existing node, use it instead of creating a new one
@@ -54,11 +55,13 @@ export const openCreateDiscourseNodeAt = (args: CreateNodeAtArgs): void => {
           });
         }
 
-        const src = await addWikilinkBlockrefForFile({
-          app: plugin.app,
-          canvasFile,
-          linkedFile: fileToUse,
-        });
+        const src = insertBacklink
+          ? await addWikilinkBlockrefForFile({
+              app: plugin.app,
+              canvasFile,
+              linkedFile: fileToUse,
+            })
+          : undefined;
 
         let preloadedImageSrc: string | undefined = undefined;
         if (selectedNodeType.keyImage) {
diff --git a/apps/obsidian/src/utils/createNode.ts b/apps/obsidian/src/utils/createNode.ts
index e16a2de04..ac88f65f2 100644
--- a/apps/obsidian/src/utils/createNode.ts
+++ b/apps/obsidian/src/utils/createNode.ts
@@ -134,7 +134,7 @@ export const createDiscourseNode = async ({
     nodeType,
   });
 
-  if (newFile && editor && editor.somethingSelected()) {
+  if (newFile && editor) {
     editor.replaceSelection(`[[${formattedNodeName}]]`);
   }
 
diff --git a/apps/obsidian/src/utils/registerCommands.ts b/apps/obsidian/src/utils/registerCommands.ts
index 052c35144..605ad0337 100644
--- a/apps/obsidian/src/utils/registerCommands.ts
+++ b/apps/obsidian/src/utils/registerCommands.ts
@@ -22,6 +22,7 @@ type ModifyNodeSubmitParams = {
   selectedExistingNode?: TFile;
   relationshipId?: string;
   relationshipTargetFile?: TFile;
+  insertBacklink: boolean;
 };
 
 export const createModifyNodeModalSubmitHandler = (
@@ -34,10 +35,11 @@ export const createModifyNodeModalSubmitHandler = (
     selectedExistingNode,
     relationshipId,
     relationshipTargetFile,
+    insertBacklink,
   }: ModifyNodeSubmitParams) => {
     if (selectedExistingNode) {
-      if (editor && editor.somethingSelected()) {
-        editor?.replaceSelection(`[[${selectedExistingNode.basename}]]`);
+      if (insertBacklink && editor) {
+        editor.replaceSelection(`[[${selectedExistingNode.basename}]]`);
       }
       await addRelationIfRequested(plugin, selectedExistingNode, {
         relationshipId,
@@ -48,7 +50,7 @@ export const createModifyNodeModalSubmitHandler = (
         plugin,
         nodeType,
         text: title,
-        editor,
+        editor: insertBacklink ? editor : undefined,
       });
       if (newFile) {
         await addRelationIfRequested(plugin, newFile, {

From e70f8118cdb77d927882f489b7e9d732ed00a2a6 Mon Sep 17 00:00:00 2001
From: Trang Doan <doantranghp2000@gmail.com>
Date: Mon, 11 May 2026 16:42:54 -0700
Subject: [PATCH 2/4] small fixes

---
 apps/obsidian/src/components/ModifyNodeModal.tsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/apps/obsidian/src/components/ModifyNodeModal.tsx b/apps/obsidian/src/components/ModifyNodeModal.tsx
index f14a42f8e..bf8f71f43 100644
--- a/apps/obsidian/src/components/ModifyNodeModal.tsx
+++ b/apps/obsidian/src/components/ModifyNodeModal.tsx
@@ -85,7 +85,8 @@ export const ModifyNodeForm = ({
     string | undefined
   >(undefined);
   const hasEditorContext =
-    plugin.app.workspace.activeLeaf?.view instanceof MarkdownView;
+    !!plugin.app.workspace.getActiveViewOfType(MarkdownView);
+  console.log("hasEditorContext", hasEditorContext);
   const [insertBacklink, setInsertBacklink] = useState(!!initialTitle);
   const queryEngine = useRef(new QueryEngine(plugin.app));
   const titleInputRef = useRef<HTMLTextAreaElement>(null);

From b9ac0a62524315255a9d528b3177c49e5c2cfaae Mon Sep 17 00:00:00 2001
From: Trang Doan <doantranghp2000@gmail.com>
Date: Mon, 11 May 2026 16:44:07 -0700
Subject: [PATCH 3/4] clear console

---
 apps/obsidian/src/components/ModifyNodeModal.tsx | 1 -
 1 file changed, 1 deletion(-)

diff --git a/apps/obsidian/src/components/ModifyNodeModal.tsx b/apps/obsidian/src/components/ModifyNodeModal.tsx
index bf8f71f43..cd1736736 100644
--- a/apps/obsidian/src/components/ModifyNodeModal.tsx
+++ b/apps/obsidian/src/components/ModifyNodeModal.tsx
@@ -86,7 +86,6 @@ export const ModifyNodeForm = ({
   >(undefined);
   const hasEditorContext =
     !!plugin.app.workspace.getActiveViewOfType(MarkdownView);
-  console.log("hasEditorContext", hasEditorContext);
   const [insertBacklink, setInsertBacklink] = useState(!!initialTitle);
   const queryEngine = useRef(new QueryEngine(plugin.app));
   const titleInputRef = useRef<HTMLTextAreaElement>(null);

From 6ba4a87f7d76142bdde5bdaaf7faba2982077a1c Mon Sep 17 00:00:00 2001
From: Trang Doan <doantranghp2000@gmail.com>
Date: Sat, 23 May 2026 23:56:18 -0400
Subject: [PATCH 4/4] revert the canvas bug

---
 .../src/components/canvas/utils/nodeCreationFlow.ts | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/apps/obsidian/src/components/canvas/utils/nodeCreationFlow.ts b/apps/obsidian/src/components/canvas/utils/nodeCreationFlow.ts
index 1f3014ea9..54dbc2e13 100644
--- a/apps/obsidian/src/components/canvas/utils/nodeCreationFlow.ts
+++ b/apps/obsidian/src/components/canvas/utils/nodeCreationFlow.ts
@@ -32,7 +32,6 @@ export const openCreateDiscourseNodeAt = (args: CreateNodeAtArgs): void => {
       selectedExistingNode,
       relationshipId,
       relationshipTargetFile,
-      insertBacklink,
     }) => {
       try {
         // If user selected an existing node, use it instead of creating a new one
@@ -55,13 +54,11 @@ export const openCreateDiscourseNodeAt = (args: CreateNodeAtArgs): void => {
           });
         }
 
-        const src = insertBacklink
-          ? await addWikilinkBlockrefForFile({
-              app: plugin.app,
-              canvasFile,
-              linkedFile: fileToUse,
-            })
-          : undefined;
+        const src = await addWikilinkBlockrefForFile({
+          app: plugin.app,
+          canvasFile,
+          linkedFile: fileToUse,
+        });
 
         let preloadedImageSrc: string | undefined = undefined;
         if (selectedNodeType.keyImage) {