[ENG-1459] Obsidian plugin store prep Part 2 (#849)

* fix(obsidian): address plugin store submission requirements + UI text + commands

- Update manifest.json description to start with verb and end with period (SR-4, SR-5)
- Remove top-level "Discourse Graph Settings" heading (PG-UI7, PG-UI8)
- Remove default hotkey Mod+\ from open-node-type-menu command (PG-C14)
- Replace workspace.activeLeaf with getActiveViewOfType() (PG-W16)
- Add PLUGIN_STORE_SUBMISSION.md and PR_SUMMARY.md tracking docs

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Revise PLUGIN_STORE_SUBMISSION.md for clarity and updates

Updated submission document to reflect changes addressing failed criteria and improved clarity on plugin guidelines.

* remove PR_SUMMARY.md

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(obsidian): remove unnecessary console logging statements (PG-G2)

Remove console.log, console.warn, and console.debug statements from
production code across 8 files. Retained console.error for legitimate
error handling.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* remove comments

* remove excessive comments

* rm more logs

* add remove orphan back

* delete file

* address PR comment

* address PR comments

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: trangdoan982

apps/obsidian/src/components/canvas/TldrawView.tsx

@@ -82,7 +82,6 @@ export class TldrawView extends TextFileView {
     const store = this.createStore(fileData, assetStore);
 
     if (!store) {
-      console.warn("No tldraw data found in file");
       return;
     }
 
@@ -100,13 +99,11 @@ export class TldrawView extends TextFileView {
       );
 
       if (!match?.[1]) {
-        console.warn("No tldraw data found in file");
         return;
       }
 
       const data = JSON.parse(match[1]) as TLData;
       if (!data.raw) {
-        console.warn("Invalid tldraw data format - missing raw field");
         return;
       }
       if (data.meta?.uuid) {
@@ -116,7 +113,6 @@ export class TldrawView extends TextFileView {
       }
 
       if (!this.file) {
-        console.warn("TldrawView not initialized: missing file");
         return;
       }
 
@@ -152,7 +148,6 @@ export class TldrawView extends TextFileView {
       throw new Error("TldrawView not initialized: missing canvas UUID");
 
     if (!this.assetStore) {
-      console.warn("Asset store is not set");
       return;
     }
 
@@ -254,4 +249,4 @@ export class TldrawView extends TextFileView {
       this.assetStore = null;
     }
   }
-}
+}

apps/obsidian/src/components/canvas/utils/relationJsonUtils.ts

@@ -30,10 +30,6 @@ export const addRelationToRelationsJson = async ({
     const missing: string[] = [];
     if (!sourceId) missing.push(`source (${sourceFile.basename})`);
     if (!destId) missing.push(`target (${targetFile.basename})`);
-    console.warn(
-      "Could not resolve nodeInstanceIds for relation files:",
-      missing.join(", "),
-    );
     new Notice(
       "Could not create relation: one or both files are not discourse nodes or metadata is not ready.",
       3000,
@@ -74,9 +70,6 @@ export const addRelationIfRequested = async (
     getNodeTypeIdForFile(plugin, relationshipTargetFile),
   ]);
   if (!typeA || !typeB) {
-    console.warn(
-      "addRelationIfRequested: could not resolve node types for one or both files",
-    );
     return;
   }
 
@@ -92,9 +85,6 @@ export const addRelationIfRequested = async (
     sourceFile = createdOrSelectedFile;
     targetFile = relationshipTargetFile;
   } else {
-    console.warn(
-      "addRelationIfRequested: file node types do not match relation definition",
-    );
     return;
   }
 
@@ -104,4 +94,4 @@ export const addRelationIfRequested = async (
     targetFile,
     relationTypeId: relation.relationshipTypeId,
   });
-};
+};

apps/obsidian/src/services/QueryEngine.ts

@@ -50,9 +50,6 @@ export class QueryEngine {
       return [];
     }
     if (!this.dc) {
-      console.warn(
-        "Datacore API not available. Search functionality is not available.",
-      );
       return [];
     }
 
@@ -88,9 +85,6 @@ export class QueryEngine {
    */
   getDiscourseNodeById = (nodeInstanceId: string): TFile | null => {
     if (!this.dc) {
-      console.warn(
-        "Datacore API not available. Search functionality is not available.",
-      );
       return null;
     }
 
@@ -125,9 +119,6 @@ export class QueryEngine {
       return [];
     }
     if (!this.dc) {
-      console.warn(
-        "Datacore API not available. Search functionality is not available.",
-      );
       return [];
     }
 
@@ -245,9 +236,6 @@ export class QueryEngine {
     const candidates: BulkImportCandidate[] = [];
 
     if (!this.dc) {
-      console.warn(
-        "Datacore API not available. Falling back to vault iteration.",
-      );
       return this.fallbackScanVault(patterns, validNodeTypes);
     }
 
@@ -290,9 +278,6 @@ export class QueryEngine {
               );
 
               if (!matchedNodeType) {
-                console.warn(
-                  `No matching node type found for pattern with nodeTypeId: ${pattern.nodeTypeId}`,
-                );
                 continue;
               }
 
@@ -348,7 +333,7 @@ export class QueryEngine {
           }
         }
       } catch (error) {
-        console.warn("Error querying DataCore for imported file:", error);
+        // DataCore query may fail; vault-iteration fallback below handles this
       }
     }
 
@@ -403,9 +388,6 @@ export class QueryEngine {
           );
 
           if (!matchedNodeType) {
-            console.warn(
-              `No matching node type found for pattern with nodeTypeId: ${pattern.nodeTypeId}`,
-            );
             continue;
           }
 

apps/obsidian/src/utils/fileChangeListener.ts

@@ -73,8 +73,6 @@ export class FileChangeListener {
       this.handleMetadataChange(file);
     };
     this.plugin.app.metadataCache.on("changed", this.metadataChangeCallback);
-
-    console.debug("FileChangeListener initialized");
   }
 
   /**
@@ -134,7 +132,6 @@ export class FileChangeListener {
       return;
     }
 
-    console.log(`File modified: ${file.path}`);
     this.queueChange(file.path, "content");
   }
 
@@ -146,7 +143,6 @@ export class FileChangeListener {
       return;
     }
 
-    console.log(`File deleted: ${file.path}`);
     this.hasPendingOrphanCleanup = true;
     this.resetDebounceTimer();
   }
@@ -159,7 +155,6 @@ export class FileChangeListener {
       return;
     }
 
-    console.log(`File renamed: ${oldPath} -> ${file.path}`);
     this.queueChange(file.path, "title", oldPath);
   }
 
@@ -180,16 +175,6 @@ export class FileChangeListener {
 
     // Note: pendingCreates helps track files that are created -> added nodeTypeId -> synced to Supabase.
     // If a file is created -> added nodeTypeId manually, it won't be detected until the next global sync (onLoad).
-
-    // Placeholder: Check for relation metadata changes
-    // For now, we'll just log that metadata changed
-    // In the future, this can detect specific relation changes
-    const cache = this.plugin.app.metadataCache.getFileCache(file);
-    if (cache?.frontmatter) {
-      console.debug(
-        `Metadata changed for ${file.path} (relation metadata placeholder)`,
-      );
-    }
   }
 
   /**
@@ -235,7 +220,6 @@ export class FileChangeListener {
    */
   private async processQueue(): Promise<void> {
     if (this.isProcessing) {
-      console.debug("Sync already in progress, skipping");
       return;
     }
 
@@ -283,31 +267,10 @@ export class FileChangeListener {
         }
       }
 
-      if (processedFiles.length > 0) {
-        console.debug(
-          `Successfully processed ${processedFiles.length} file(s):`,
-          processedFiles,
-        );
-      }
-
-      if (failedFiles.length > 0) {
-        console.warn(
-          `Failed to process ${failedFiles.length} file(s), will retry on next change:`,
-          failedFiles,
-        );
-      }
-
       if (this.hasPendingOrphanCleanup) {
-        const deletedCount = await cleanupOrphanedNodes(this.plugin);
-        if (deletedCount > 0) {
-          console.debug(`Deleted ${deletedCount} orphaned node(s)`);
-        }
+        await cleanupOrphanedNodes(this.plugin);
         this.hasPendingOrphanCleanup = false;
       }
-
-      if (processedFiles.length > 0 || failedFiles.length === 0) {
-        console.debug("Sync queue processed");
-      }
     } catch (error) {
       console.error("Error processing sync queue:", error);
       // Items that weren't processed remain in the queue for retry
@@ -341,7 +304,5 @@ export class FileChangeListener {
     this.changeQueue.clear();
     this.pendingCreates.clear();
     this.isProcessing = false;
-
-    console.debug("FileChangeListener cleaned up");
   }
 }

apps/obsidian/src/utils/importNodes.ts

@@ -354,12 +354,6 @@ const fetchNodeContentForImport = async ({
     full.created == null ||
     full.last_modified == null
   ) {
-    if (!direct?.text) {
-      console.warn(`No direct variant found for node ${nodeInstanceId}`);
-    }
-    if (!full?.text) {
-      console.warn(`No full variant found for node ${nodeInstanceId}`);
-    }
     return null;
   }
 
@@ -458,12 +452,10 @@ const downloadFileFromStorage = async ({
       .download(filehash);
 
     if (error) {
-      console.warn(`Error downloading file ${filehash}:`, error);
       return null;
     }
 
     if (!data) {
-      console.warn(`No data returned for file ${filehash}`);
       return null;
     }
 
@@ -858,7 +850,6 @@ const importAssetsForNode = async ({
 
       if (!fileContent) {
         errors.push(`Failed to download file: ${filepath}`);
-        console.warn(`Failed to download file ${filepath} (hash: ${filehash})`);
         continue;
       }
 
@@ -898,7 +889,6 @@ const importAssetsForNode = async ({
 
       // Track path mapping (raw + normalized key so updateMarkdownAssetLinks can lookup by link text)
       setPathMapping(filepath, targetPath);
-      console.log(`Imported asset: ${filepath} -> ${targetPath}`);
     } catch (error) {
       const errorMsg = `Error importing asset ${fileRef.filepath}: ${error}`;
       errors.push(errorMsg);
@@ -1173,7 +1163,6 @@ export const importSelectedNodes = async ({
     const importFolderPath = `import/${sanitizeFileName(spaceName)}`;
     const spaceUri = spaceUris.get(spaceId);
     if (!spaceUri) {
-      console.warn(`Missing URI for space ${spaceId}`);
       for (const _node of nodes) {
         failedCount++;
         processedCount++;
@@ -1302,14 +1291,6 @@ export const importSelectedNodes = async ({
           }
         }
 
-        // Log asset import errors if any
-        if (assetImportResult.errors.length > 0) {
-          console.warn(
-            `Some assets failed to import for node ${node.nodeInstanceId}:`,
-            assetImportResult.errors,
-          );
-        }
-
         // If title changed and file exists, rename it to match the new title
         if (existingFile && processedFile.basename !== sanitizedFileName) {
           const newPath = `${importFolderPath}/${sanitizedFileName}.md`;

apps/obsidian/src/utils/publishNode.ts

@@ -42,9 +42,6 @@ const publishSchema = async ({
   }
 
   if (!schemaResponse.data) {
-    console.warn(
-      `Schema with nodeTypeId ${nodeTypeId} not found in space ${spaceId}`,
-    );
     return; // Schema doesn't exist, skip publishing
   }
 
@@ -299,9 +296,6 @@ export const publishNodeToGroup = async ({
         link,
         file.path,
       );
-      if (attachment === null) {
-        console.warn("Could not find file for " + link);
-      }
       return attachment;
     })
     .filter((a) => !!a);