-
Notifications
You must be signed in to change notification settings - Fork 13
Expand file tree
/
Copy pathtest_task_worker.py
More file actions
1020 lines (811 loc) · 28.7 KB
/
test_task_worker.py
File metadata and controls
1020 lines (811 loc) · 28.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
import dataclasses
import itertools
import threading
from collections.abc import Callable, Iterable
from concurrent.futures import Future
from pathlib import Path
from queue import Full
from typing import Any, Generic, TypeVar
from unittest.mock import ANY, MagicMock, Mock, patch
import pydantic
import pytest
from bluesky.protocols import Movable, Readable, Status
from bluesky.utils import MsgGenerator
from dodal.common import inject
from dodal.common.types import UpdatingPathProvider
from observability_utils.tracing import (
JsonObjectSpanExporter,
asserting_span_exporter,
)
from ophyd_async.core import AsyncStatus
from pydantic import BaseModel
from blueapi.config import DeviceSource, EnvironmentConfig
from blueapi.core import BlueskyContext, EventStream
from blueapi.core.bluesky_types import DataEvent
from blueapi.service.model import PlanModel
from blueapi.utils.base_model import BlueapiBaseModel
from blueapi.worker import (
Task,
TaskStatus,
TaskWorker,
TrackableTask,
WorkerAlreadyStartedError,
WorkerBusyError,
WorkerEvent,
WorkerState,
)
from blueapi.worker.event import TaskResult, TaskStatusEnum
from blueapi.worker.task import register_model, restore_models
_SIMPLE_TASK = Task(name="sleep", params={"time": 0.0})
_LONG_TASK = Task(name="sleep", params={"time": 1.0})
_INDEFINITE_TASK = Task(
name="set_absolute",
params={"movable": "fake_device", "value": 4.0},
)
_FAILING_TASK = Task(name="failing_plan", params={})
_TASK_WITH_METADATA = Task(
name="sleep",
params={"time": 0.0},
metadata={
"foo": "bar",
"baz": 0,
},
)
class FakeDevice(Movable[float]):
event: threading.Event
def __init__(self, name: str = "fake_device") -> None:
self.event = threading.Event()
self.name = name
def set(self, value: float) -> Status:
def when_done(_: Status):
self.event.clear()
async def wait_for_event():
self.event.wait()
stat = AsyncStatus(wait_for_event())
stat.add_callback(when_done)
return stat
def failing_plan() -> MsgGenerator:
raise KeyError("I failed")
@dataclasses.dataclass
class ComplexReturn:
foo: int
bar: list[str]
class ModelReturn(pydantic.BaseModel):
foo: int
bar: list[str]
class Unreturnable:
def __init__(self, foo: int, bar: list[str]):
self.foo = foo
self.bar = bar
@pytest.fixture
def fake_device() -> FakeDevice:
return FakeDevice()
@pytest.fixture
def second_fake_device() -> FakeDevice:
return FakeDevice("second_fake_device")
@pytest.fixture
def context(fake_device: FakeDevice, second_fake_device: FakeDevice) -> BlueskyContext:
ctx = BlueskyContext()
ctx_config = EnvironmentConfig()
ctx_config.sources.append(DeviceSource(module="devices"))
ctx.register_plan(failing_plan)
ctx.register_device(fake_device)
ctx.register_device(second_fake_device)
ctx.with_config(ctx_config)
return ctx
@pytest.fixture
def context_without_devices() -> BlueskyContext:
ctx = BlueskyContext()
ctx_config = EnvironmentConfig()
ctx_config.sources.append(DeviceSource(module="devices"))
ctx.with_config(ctx_config)
return ctx
@pytest.fixture
def inert_worker(context: BlueskyContext) -> TaskWorker:
return TaskWorker(context, start_stop_timeout=2.0)
@pytest.fixture
def worker(inert_worker: TaskWorker) -> Iterable[TaskWorker]:
inert_worker.start()
yield inert_worker
inert_worker.stop()
def test_stop_doesnt_hang(inert_worker: TaskWorker) -> None:
inert_worker.start()
inert_worker.stop()
def test_stop_is_idempotent_if_worker_not_started(inert_worker: TaskWorker) -> None:
inert_worker.stop()
def test_multi_stop(inert_worker: TaskWorker) -> None:
inert_worker.start()
inert_worker.stop()
inert_worker.stop()
def test_restart(inert_worker: TaskWorker) -> None:
inert_worker.start()
inert_worker.stop()
inert_worker.start()
inert_worker.stop()
def test_multi_start(inert_worker: TaskWorker) -> None:
inert_worker.start()
with pytest.raises(WorkerAlreadyStartedError):
inert_worker.start()
inert_worker.stop()
def test_submit_task(
worker: TaskWorker,
) -> None:
assert worker.get_tasks() == []
task_id = worker.submit_task(_SIMPLE_TASK)
assert worker.get_tasks() == [
TrackableTask.model_construct(
task_id=task_id, request_id=ANY, task=_SIMPLE_TASK
)
]
def test_submit_multiple_tasks(worker: TaskWorker) -> None:
assert worker.get_tasks() == []
task_id_1 = worker.submit_task(_SIMPLE_TASK)
assert worker.get_tasks() == [
TrackableTask.model_construct(
task_id=task_id_1, request_id=ANY, task=_SIMPLE_TASK
)
]
task_id_2 = worker.submit_task(_LONG_TASK)
assert worker.get_tasks() == [
TrackableTask.model_construct(
task_id=task_id_1, request_id=ANY, task=_SIMPLE_TASK
),
TrackableTask.model_construct(
task_id=task_id_2, request_id=ANY, task=_LONG_TASK
),
]
def test_stop_with_task_pending(inert_worker: TaskWorker) -> None:
inert_worker.start()
inert_worker.submit_task(_SIMPLE_TASK)
inert_worker.stop()
def test_restart_leaves_task_pending(worker: TaskWorker) -> None:
task_id = worker.submit_task(_SIMPLE_TASK)
assert worker.get_tasks() == [
TrackableTask.model_construct(
task_id=task_id, request_id=ANY, task=_SIMPLE_TASK
)
]
worker.stop()
worker.start()
assert worker.get_tasks() == [
TrackableTask.model_construct(
task_id=task_id, request_id=ANY, task=_SIMPLE_TASK
)
]
def test_submit_before_start_pending(inert_worker: TaskWorker) -> None:
task_id = inert_worker.submit_task(_SIMPLE_TASK)
inert_worker.start()
assert inert_worker.get_tasks() == [
TrackableTask.model_construct(
task_id=task_id, request_id=ANY, task=_SIMPLE_TASK
)
]
inert_worker.stop()
assert inert_worker.get_tasks() == [
TrackableTask.model_construct(
task_id=task_id, request_id=ANY, task=_SIMPLE_TASK
)
]
def test_clear_task(worker: TaskWorker) -> None:
task_id = worker.submit_task(_SIMPLE_TASK)
assert worker.get_tasks() == [
TrackableTask.model_construct(
task_id=task_id, request_id=ANY, task=_SIMPLE_TASK
)
]
assert worker.clear_task(task_id)
assert worker.get_tasks() == []
def test_clear_nonexistent_task(worker: TaskWorker) -> None:
with pytest.raises(KeyError):
worker.clear_task("foo")
def test_does_not_allow_simultaneous_running_tasks(
worker: TaskWorker,
fake_device: FakeDevice,
) -> None:
task_ids = [
worker.submit_task(_INDEFINITE_TASK),
worker.submit_task(_INDEFINITE_TASK),
]
with pytest.raises(WorkerBusyError):
for task_id in task_ids:
worker.begin_task(task_id)
fake_device.event.set()
def test_begin_task_blocks_until_current_task_set(worker: TaskWorker) -> None:
task_id = worker.submit_task(_SIMPLE_TASK)
assert worker.get_active_task() is None
worker.begin_task(task_id)
active_task = worker.get_active_task()
assert active_task is not None
assert active_task.task == _SIMPLE_TASK
@patch("blueapi.worker.task_worker.plan_tag_filter_context")
@patch("blueapi.worker.task_worker.TaskWorker._submit_trackable_task")
def test_begin_task_uses_plan_name_filter(
submit_trackable_task_mock: Mock, filter_mock: Mock, inert_worker: TaskWorker
) -> None:
task_id = inert_worker.submit_task(_SIMPLE_TASK)
inert_worker.begin_task(task_id)
filter_mock.assert_called_once()
@pytest.mark.parametrize(
"result,serial,type_name",
[
(None, None, "NoneType"),
(42, 42, "int"),
("helloWorld", "helloWorld", "str"),
(ComplexReturn(34, ["foo"]), {"foo": 34, "bar": ["foo"]}, "ComplexReturn"),
(
ModelReturn(foo=42, bar=["helloWorld"]),
{"foo": 42, "bar": ["helloWorld"]},
"ModelReturn",
),
(Unreturnable(17, ["fizzbuzz"]), None, "Unreturnable"),
],
)
def test_plan_result_serialized(
worker: TaskWorker, result: Any, serial: Any, type_name: str
):
def result_plan() -> MsgGenerator:
yield from []
return result
worker._ctx.register_plan(result_plan)
task_id = worker.submit_task(Task(name="result_plan"))
events = begin_task_and_wait_until_complete(worker, task_id)
ts = events[-1].task_status
assert ts is not None
assert ts.result == TaskResult(result=serial, type=type_name)
assert ts.model_dump()["result"] == {
"outcome": "success",
"result": serial,
"type": type_name,
}
def test_plan_failure_recorded_in_active_task(worker: TaskWorker) -> None:
task_id = worker.submit_task(_FAILING_TASK)
events_future: Future[list[WorkerEvent]] = take_events(
worker.worker_events,
lambda event: event.task_status is not None and event.task_status.task_failed,
)
worker.begin_task(task_id)
events = events_future.result(timeout=5.0)
assert events[-1].task_status is not None
assert events[-1].task_status.task_failed
assert events[-1].errors == ["'I failed'"]
active_task = worker.get_active_task()
assert active_task is not None
assert active_task.errors == ["'I failed'"]
def test_task_not_run_twice(worker: TaskWorker) -> None:
task_id = worker.submit_task(_SIMPLE_TASK)
events_future: Future[list[WorkerEvent]] = take_events(
worker.worker_events,
lambda event: event.task_status is not None and event.task_status.task_complete,
)
worker.begin_task(task_id)
events_future.result(timeout=5.0)
with pytest.raises(KeyError):
worker.begin_task(task_id)
@pytest.mark.parametrize("num_runs", [0, 1, 2])
def test_produces_worker_events(worker: TaskWorker, num_runs: int) -> None:
task_ids = [worker.submit_task(_SIMPLE_TASK) for _ in range(num_runs)]
event_sequences = [_sleep_events(task_id) for task_id in task_ids]
for task_id, events in zip(task_ids, event_sequences, strict=False):
assert_run_produces_worker_events(events, worker, task_id)
def _sleep_events(task_id: str) -> list[WorkerEvent]:
return [
WorkerEvent(
state=WorkerState.RUNNING,
task_status=TaskStatus(
task_id=task_id,
task_complete=False,
task_failed=False,
result=None,
),
errors=[],
warnings=[],
),
WorkerEvent(
state=WorkerState.IDLE,
task_status=TaskStatus(
task_id=task_id,
task_complete=False,
task_failed=False,
result=None,
),
errors=[],
warnings=[],
),
WorkerEvent(
state=WorkerState.IDLE,
task_status=TaskStatus(
task_id=task_id,
task_complete=True,
task_failed=False,
result=TaskResult.from_result(None),
),
errors=[],
warnings=[],
),
]
@patch("queue.Queue.put_nowait")
def test_full_queue_raises(put_nowait: MagicMock, worker: TaskWorker):
def raise_full(item):
raise Full()
put_nowait.side_effect = raise_full
task = worker.submit_task(_SIMPLE_TASK)
with pytest.raises(WorkerBusyError):
worker.begin_task(task)
def test_metadata_passed_to_context(context: BlueskyContext):
context.run_engine = Mock()
context.run_engine.md = {}
_TASK_WITH_METADATA.do_task(context)
for metadata in [("foo", "bar"), ("baz", 0)]:
assert metadata in context.run_engine.md.items()
#
# Worker helpers
#
def assert_run_produces_worker_events(
expected_events: list[WorkerEvent],
worker: TaskWorker,
task_id: str,
) -> None:
assert begin_task_and_wait_until_complete(worker, task_id) == expected_events
def begin_task_and_wait_until_complete(
worker: TaskWorker,
task_id: str,
timeout: float = 5.0,
) -> list[WorkerEvent]:
events: Future[list[WorkerEvent]] = take_events(
worker.worker_events,
lambda event: event.is_complete(),
)
worker.begin_task(task_id)
return events.result(timeout=timeout)
#
# Event stream helpers
#
@pytest.fixture
def path_provider(tmp_path: Path):
# Prevents issue with leftover state from beamline tests
with patch("dodal.plan_stubs.data_session.get_path_provider") as mock:
mock.return_value = MagicMock(spec=UpdatingPathProvider, return_value=tmp_path)
mock.return_value.data_session.return_value = "foo"
yield
def test_worker_and_data_events_produce_in_order(
worker: TaskWorker, path_provider
) -> None:
assert_running_count_plan_produces_ordered_worker_and_data_events(
[
WorkerEvent(
state=WorkerState.RUNNING,
task_status=TaskStatus(
task_id="count",
task_complete=False,
task_failed=False,
result=None,
),
errors=[],
warnings=[],
),
DataEvent(name="start", doc={}, task_id="0000-1111"),
DataEvent(name="descriptor", doc={}, task_id="0000-1111"),
DataEvent(name="event", doc={}, task_id="0000-1111"),
DataEvent(name="stop", doc={}, task_id="0000-1111"),
WorkerEvent(
state=WorkerState.IDLE,
task_status=TaskStatus(
task_id="count",
task_complete=False,
task_failed=False,
result=None,
),
errors=[],
warnings=[],
),
WorkerEvent(
state=WorkerState.IDLE,
task_status=TaskStatus(
task_id="count",
task_complete=True,
task_failed=False,
result=TaskResult.from_result(None),
),
errors=[],
warnings=[],
),
],
worker,
)
def assert_running_count_plan_produces_ordered_worker_and_data_events(
expected_events: list[WorkerEvent | DataEvent],
worker: TaskWorker,
task: Task | None = None,
timeout: float = 5.0,
) -> None:
default_task = Task(name="count", params={"detectors": {"motor"}, "num": 1})
task = task or default_task
event_streams: list[EventStream[Any, int]] = [
worker.data_events,
worker.worker_events,
]
count = itertools.count()
events: Future[list[Any]] = take_events_from_streams(
event_streams,
lambda _: next(count) >= len(expected_events) - 1,
)
task_id = worker.submit_task(task)
worker.begin_task(task_id)
results = events.result(timeout=timeout)
for actual, expected in itertools.zip_longest(results, expected_events):
if isinstance(expected, WorkerEvent):
if expected.task_status:
expected.task_status.task_id = task_id
assert actual == expected
elif isinstance(expected, DataEvent):
assert isinstance(actual, DataEvent)
assert actual.name == expected.name
E = TypeVar("E")
def take_n_events(
stream: EventStream[E, Any],
num: int,
) -> Future[list[E]]:
count = itertools.count()
return take_events(stream, lambda _: next(count) >= num)
def take_events(
stream: EventStream[E, Any],
cutoff_predicate: Callable[[E], bool],
) -> Future[list[E]]:
events: list[E] = []
future: Future[list[E]] = Future()
def on_event(event: E, event_id: str | None) -> None:
events.append(event)
if cutoff_predicate(event):
future.set_result(events)
sub = stream.subscribe(on_event)
future.add_done_callback(lambda _: stream.unsubscribe(sub))
return future
def take_events_from_streams(
streams: list[EventStream[Any, int]],
cutoff_predicate: Callable[[Any], bool],
) -> Future[list[Any]]:
"""Returns a collated list of futures for events in numerous event streams.
The support for generic and algebraic types doesn't appear to extend to
taking an arbitrary list of concrete types with single but differing
generic arguments while also maintaining the generality of the argument
types.
The type for streams will be any combination of event streams each of a
given event type, where the event type is generic:
List[
Union[
EventStream[WorkerEvent, int],
EventStream[DataEvent, int],
EventStream[ProgressEvent, int]
]
]
"""
events: list[Any] = []
future: Future[list[Any]] = Future()
def on_event(event: Any, event_id: str | None) -> None:
print(event)
events.append(event)
if cutoff_predicate(event):
future.set_result(events)
for stream in streams:
sub = stream.subscribe(on_event)
def callback(unused: Future[list[Any]], stream=stream, sub=sub):
stream.unsubscribe(sub)
future.add_done_callback(callback)
return future
@pytest.mark.parametrize(
"status, expected_task_ids",
[
(TaskStatusEnum.RUNNING, ["task1"]),
(TaskStatusEnum.PENDING, ["task2"]),
(TaskStatusEnum.COMPLETE, ["task3"]),
],
)
def test_get_tasks_by_status(worker: TaskWorker, status, expected_task_ids):
worker._pending_tasks = {
"task1": TrackableTask(
task_id="task1",
task=Task(
name="set_absolute", params={"movable": "fake_device", "value": 4.0}
),
is_complete=False,
is_pending=False,
),
"task2": TrackableTask(
task_id="task2",
task=Task(
name="set_absolute", params={"movable": "fake_device", "value": 4.0}
),
is_complete=False,
is_pending=True,
),
}
worker._completed_tasks = {
"task3": TrackableTask(
task_id="task3",
task=Task(
name="set_absolute", params={"movable": "fake_device", "value": 4.0}
),
is_complete=True,
is_pending=False,
),
}
result = worker.get_tasks_by_status(status)
result_ids = [task.task_id for task in result]
assert result_ids == expected_task_ids
def test_submitting_completed_task_fails(worker: TaskWorker):
with pytest.raises(ValueError):
worker._submit_trackable_task(
TrackableTask(
task_id="task1", task=_SIMPLE_TASK, is_complete=True, is_pending=False
)
)
def test_start_span_ok(
exporter: JsonObjectSpanExporter, inert_worker: TaskWorker
) -> None:
with asserting_span_exporter(exporter, "start"):
inert_worker.start()
inert_worker.stop()
def test_stop_span_ok(
exporter: JsonObjectSpanExporter, inert_worker: TaskWorker
) -> None:
inert_worker.start()
with asserting_span_exporter(exporter, "stop"):
inert_worker.stop()
def test_submit_task_span_ok(
exporter: JsonObjectSpanExporter,
worker: TaskWorker,
) -> None:
assert worker.get_tasks() == []
with asserting_span_exporter(exporter, "submit_task", "task.name", "task.params"):
worker.submit_task(_SIMPLE_TASK)
@patch("blueapi.worker.task_worker.get_baggage")
def test_submit_task_with_correlation_id(
mock_get_baggage: Mock,
exporter: JsonObjectSpanExporter,
worker: TaskWorker,
) -> None:
mock_get_baggage.return_value = "foo"
task_id = worker.submit_task(_SIMPLE_TASK)
trackable_task = worker.get_task_by_id(task_id)
assert trackable_task is not None
assert trackable_task.request_id == "foo"
def test_clear_task_span_ok(
exporter: JsonObjectSpanExporter, worker: TaskWorker
) -> None:
with pytest.raises(KeyError):
with asserting_span_exporter(exporter, "clear_task", "task_id"):
worker.clear_task("foo")
def test_begin_task_span_ok(
exporter: JsonObjectSpanExporter, worker: TaskWorker
) -> None:
task_id = worker.submit_task(_SIMPLE_TASK)
with asserting_span_exporter(exporter, "begin_task", "task_id"):
worker.begin_task(task_id)
def test_injected_devices_are_found(
fake_device: FakeDevice,
context: BlueskyContext,
):
def injected_device_plan(
dev: FakeDevice = inject(fake_device.name),
) -> MsgGenerator:
yield from ()
context.register_plan(injected_device_plan)
params = Task(name="injected_device_plan").prepare_params(context)
assert params["dev"] == fake_device
def test_injected_devices_plan_model(
fake_device: FakeDevice,
context: BlueskyContext,
):
def injected_device_plan(
dev: FakeDevice = inject(fake_device.name),
) -> MsgGenerator:
yield from ()
context.register_plan(injected_device_plan)
plan = context.plans["injected_device_plan"]
PlanModel.from_plan(plan)
def test_missing_injected_devices_fail_early(
context: BlueskyContext,
):
def missing_injection(dev: FakeDevice = inject("does_not_exist")) -> MsgGenerator:
yield from ()
context.register_plan(missing_injection)
with pytest.raises(ValueError, match="Device does_not_exist cannot be found"):
Task(name="missing_injection").prepare_params(context)
def test_invalid_injected_devices_fail_early(
context: BlueskyContext,
):
def invalid_injection(dev: Readable = inject("fake_device")) -> MsgGenerator:
yield from ()
context.register_plan(invalid_injection)
with pytest.raises(
ValueError,
match=(
r"Device fake_device \(test_task_worker.FakeDevice\) "
"is not of type bluesky.protocols.Readable"
),
):
Task(name="invalid_injection").prepare_params(context)
@patch("blueapi.worker.task_worker.plan_tag_filter_context")
def test_worker_uses_plan_tag_filter_context(
mock_context: Mock, inert_worker: TaskWorker
):
task = TrackableTask(task_id="0", task=_SIMPLE_TASK)
inert_worker._task_channel.put_nowait(task)
inert_worker._pending_tasks["0"] = task
mock_context.assert_not_called()
inert_worker._cycle()
mock_context.assert_called_once()
@patch("blueapi.worker.task_worker.LOGGER")
def test_cycle_without_otel_context(mock_logger: Mock, inert_worker: TaskWorker):
task = TrackableTask(task_id="0", task=_SIMPLE_TASK)
inert_worker._task_channel.put_nowait(task)
inert_worker._pending_tasks["0"] = task
inert_worker._cycle()
assert inert_worker._current_task_otel_context is None
# Bad way to tell that this branch has been run, but I can't think of a better way
# Have to set these values to match output
task.is_complete = False
task.is_pending = True
mock_logger.info.assert_called_with(
"Task ran successfully - returned: %s", None, extra={"task_id": "0"}
)
class MyComposite(BlueapiBaseModel):
fake_device: FakeDevice
second_fake_device: FakeDevice
model_config = {"arbitrary_types_allowed": True}
@pydantic.dataclasses.dataclass(config={"arbitrary_types_allowed": True})
class MyPydanticDataClassComposite:
fake_device: FakeDevice
second_fake_device: FakeDevice
@dataclasses.dataclass()
class MyStandardDataClassComposite:
fake_device: FakeDevice
second_fake_device: FakeDevice
def injected_device_plan(composite: MyComposite = inject("")) -> MsgGenerator:
yield from ()
def injected_dataclass_device_plan(
composite: MyPydanticDataClassComposite = inject(""),
) -> MsgGenerator:
yield from ()
def injected_standard_dataclass_device_plan(
composite: MyStandardDataClassComposite = inject(""),
) -> MsgGenerator:
yield from ()
def test_injected_composite_devices_are_found(
fake_device: FakeDevice,
second_fake_device: FakeDevice,
context: BlueskyContext,
):
context.register_plan(injected_device_plan)
params = Task(name="injected_device_plan").prepare_params(context)
assert params["composite"].fake_device == fake_device
assert params["composite"].second_fake_device == second_fake_device
def test_injected_composite_devices_plan_model(
fake_device: FakeDevice,
second_fake_device: FakeDevice,
context: BlueskyContext,
):
context.register_plan(injected_device_plan)
plan = context.plans["injected_device_plan"]
PlanModel.from_plan(plan)
def test_injected_composite_with_pydantic_dataclass(
context: BlueskyContext,
fake_device: FakeDevice,
second_fake_device: FakeDevice,
):
context.register_plan(injected_dataclass_device_plan)
params = Task(name="injected_dataclass_device_plan").prepare_params(context)
assert params["composite"].fake_device == fake_device
assert params["composite"].second_fake_device == second_fake_device
def test_injected_composite_with_standard_dataclass(
context: BlueskyContext,
fake_device: FakeDevice,
second_fake_device: FakeDevice,
):
context.register_plan(injected_standard_dataclass_device_plan)
params = Task(name="injected_standard_dataclass_device_plan").prepare_params(
context
)
assert params["composite"].fake_device == fake_device
assert params["composite"].second_fake_device == second_fake_device
def test_plan_module_with_composite_devices_can_be_loaded_before_device_module(
context_without_devices: BlueskyContext,
fake_device: FakeDevice,
second_fake_device: FakeDevice,
):
context_without_devices.register_plan(injected_device_plan)
context_without_devices.register_device(fake_device)
context_without_devices.register_device(second_fake_device)
params = Task(name="injected_device_plan").prepare_params(context_without_devices)
assert params["composite"].fake_device == fake_device
assert params["composite"].second_fake_device == second_fake_device
T = TypeVar("T")
class GenericPlanArgs(BaseModel):
value1: int
class SpecialisedPlanArgs(GenericPlanArgs, Generic[T]):
value2: T
class SpecialisedPlanArgs2(GenericPlanArgs):
value3: float
def plan_with_model(val: SpecialisedPlanArgs) -> MsgGenerator[T]:
yield from ()
assert isinstance(val, SpecialisedPlanArgs)
def test_plan_args_are_converted_back_to_model(
context: BlueskyContext,
) -> None:
context.register_plan(plan_with_model)
task = Task(name="plan_with_model", params={"val": {"value1": 1, "value2": "test"}})
task.do_task(context)
def plan_using_base_model(val: GenericPlanArgs) -> MsgGenerator[T]:
yield from ()
assert isinstance(val, SpecialisedPlanArgs)
def test_base_model_plan_args_are_converted_back_to_specialised_model(
context: BlueskyContext,
) -> None:
context.register_plan(plan_using_base_model)
register_model(SpecialisedPlanArgs)
task = Task(
name="plan_using_base_model",
params={
"val": {
"__type__": SpecialisedPlanArgs.__name__,
"value1": 1,
"value2": "test",
}
},
)
task.do_task(context)
def plan_with_generic_parameters(val: T) -> MsgGenerator[T]:
yield from ()
assert isinstance(val, SpecialisedPlanArgs)
def test_generic_plan_args_are_converted_back_to_specialised_model(
context: BlueskyContext,
) -> None:
context.register_plan(plan_with_generic_parameters)
register_model(SpecialisedPlanArgs)
task = Task(
name="plan_with_generic_parameters",
params={
"val": {
"__type__": SpecialisedPlanArgs.__name__,
"value1": 1,
"value2": "test",
}
},
)
task.do_task(context)
def test_nested_models_restore_from_types():
register_model(SpecialisedPlanArgs)
register_model(SpecialisedPlanArgs2)
data = {
"__type__": SpecialisedPlanArgs.__name__,
"value1": 1,
"value2": {
"__type__": SpecialisedPlanArgs2.__name__,
"value1": 1,
"value3": 1.5,
},
}
result = restore_models(data)
assert isinstance(result, SpecialisedPlanArgs)
assert result.value1 == 1
assert isinstance(result.value2, SpecialisedPlanArgs2)
assert result.value2.value1 == 1
assert result.value2.value3 == 1.5
def test_nested_models_restore_from_types_and_generic_args():