#141 Objects created without explicit binding began to use the specified default lifetime instead of Transient

Author: NikolayPianikov

src/Pure.DI.Core/Core/BindingBuilder.cs

@@ -98,7 +98,7 @@ public MdBinding Build(MdSetup setup)
             .Select(c => c with { Tags = c.Tags.Select(tag => BuildTag(tag, implementationType, id)).ToImmutableArray() })
             .ToImmutableArray();
 
-        var lifetime = lifetimeProvider.GetActualLifetime(_defaultLifetimes, _lifetime, implementationType, implementationTags, contractsWithTags);
+        var lifetime = lifetimeProvider.GetActualLifetime(_defaultLifetimes, _lifetime, implementationType, implementationTags, contractsWithTags, true);
 
         return new MdBinding(
             int.MaxValue - specialBindingIdGenerator.Generate(),

src/Pure.DI.Core/Core/BindingsFactory.cs

@@ -132,7 +132,7 @@ public MdBinding CreateAutoBinding(
             : ImmutableArray<MdTag>.Empty;
 
         var newContracts = ImmutableArray.Create(new MdContract(semanticModel, setup.Source, sourceType, ContractKind.Implicit, ImmutableArray<MdTag>.Empty));
-        var actualLifetime = lifetimeProvider.GetActualLifetime(setup.DefaultLifetimes, null, sourceType, ImmutableArray<MdTag>.Empty, newContracts);
+        var actualLifetime = lifetimeProvider.GetActualLifetime(setup.DefaultLifetimes, null, sourceType, ImmutableArray<MdTag>.Empty, newContracts, false);
 
         return new MdBinding(
             bindingId,

src/Pure.DI.Core/Core/DependencyGraphBuilder.cs

@@ -382,11 +382,6 @@ public IEnumerable<DependencyNode> Build(GraphBuildContext ctx)
 
                     if (!disableAutoBinding)
                     {
-                        /*if (!Debugger.IsAttached)
-                        {
-                            Debugger.Launch();
-                        }*/
-
                         var autoBinding = bindingsFactory.CreateAutoBinding(setup, targetNode, injection, typeConstructor, ++maxBindingId);
                         var autoNodes = dependencyNodePrioritizer.SortByPriority(nodesFactory.CreateNodes(setup, typeConstructor, autoBinding)).ToList();
                         foreach (var autoNode in autoNodes)

src/Pure.DI.Core/Core/ILifetimeProvider.cs

@@ -7,5 +7,6 @@ interface ILifetimeProvider
         MdLifetime? lifetime,
         ITypeSymbol? type,
         IReadOnlyCollection<MdTag> tags,
-        IReadOnlyCollection<MdContract> contracts);
+        IReadOnlyCollection<MdContract> contracts,
+        bool useCommonDefault);
 }

src/Pure.DI.Core/Core/LifetimeProvider.cs

@@ -1,13 +1,17 @@
 namespace Pure.DI.Core;
 
-class LifetimeProvider(ITypes types, IBaseSymbolsProvider baseSymbolsProvider) : ILifetimeProvider
+class LifetimeProvider(
+    ITypes types,
+    IBaseSymbolsProvider baseSymbolsProvider)
+    : ILifetimeProvider
 {
     public MdLifetime? GetActualLifetime(
         IReadOnlyCollection<MdDefaultLifetime> defaultLifetimes,
         MdLifetime? lifetime,
         ITypeSymbol? type,
         IReadOnlyCollection<MdTag> tags,
-        IReadOnlyCollection<MdContract> contracts)
+        IReadOnlyCollection<MdContract> contracts,
+        bool useCommonDefault)
     {
         if (lifetime is not null)
         {
@@ -30,6 +34,12 @@ class LifetimeProvider(ITypes types, IBaseSymbolsProvider baseSymbolsProvider) :
             }
         }
 
+        // ReSharper disable once ConvertIfStatementToReturnStatement
+        if (!useCommonDefault)
+        {
+            return lifetime;
+        }
+
         return GetDefaultLifetime(defaultLifetimes);
     }