Properly call destroy method so after_commit callback is called.

Author: nashby

lib/destroyed_at.rb

@@ -39,12 +39,15 @@ def destroyed(time = nil)
 
   # Set an object's destroyed_at time.
   def destroy(timestamp = nil)
-    timestamp ||= @marked_for_destruction_at || current_time_from_proper_timezone
-    raw_write_attribute(:destroyed_at, timestamp)
-    run_callbacks(:destroy) do
-      destroy_associations
-      self.class.unscoped.where(self.class.primary_key => id).update_all(destroyed_at: timestamp)
-      @destroyed = true
+    with_transaction_returning_status do
+      timestamp ||= @marked_for_destruction_at || current_time_from_proper_timezone
+      raw_write_attribute(:destroyed_at, timestamp)
+
+      run_callbacks(:destroy) do
+        destroy_associations
+        self.class.unscoped.where(self.class.primary_key => id).update_all(destroyed_at: timestamp)
+        @destroyed = true
+      end
     end
   end
 

test/destroyed_at_test.rb

@@ -260,3 +260,11 @@
   end
 end
 
+describe 'destroying on object should call after_commit callback' do
+  it 'calls after_commit callback on: :destroy' do
+    comment = Comment.create
+    comment.destroy
+
+    comment.after_commited.must_equal true
+  end
+end

test/test_helper.rb

@@ -80,6 +80,14 @@ class Comment < ActiveRecord::Base
   belongs_to :commenter
 
   has_many :likes, as: :likeable, dependent: :destroy
+
+  after_commit :foo, on: :destroy
+
+  attr_reader :after_commited
+
+  def foo
+    @after_commited = true
+  end
 end
 
 class Commenter < ActiveRecord::Base