pr feedback

Author: Datata1

src/codesphere/core/base.py

@@ -1,4 +1,4 @@
-from typing import Any, Generic, List, TypeVar
+from typing import Any, Generic, List, Literal, TypeVar
 
 import yaml
 from pydantic import BaseModel, ConfigDict, RootModel
@@ -67,7 +67,9 @@ def to_yaml(self, *, by_alias: bool = True, exclude_none: bool = False) -> str:
         Returns:
             YAML string representation of the model.
         """
-        data = self.to_dict(by_alias=by_alias, exclude_none=exclude_none)
+        data = self.model_dump(
+            by_alias=by_alias, exclude_none=exclude_none, mode="json"
+        )
         return yaml.safe_dump(
             data, default_flow_style=False, allow_unicode=True, sort_keys=False
         )
@@ -86,19 +88,25 @@ def __len__(self):
         return len(self.root)
 
     def to_list(
-        self, *, by_alias: bool = True, exclude_none: bool = False
+        self,
+        *,
+        by_alias: bool = True,
+        exclude_none: bool = False,
+        mode: Literal["python", "json"] = "python",
     ) -> list[dict[str, Any]]:
         """Export all items as a list of dictionaries.
 
         Args:
             by_alias: Use camelCase keys (API format) if True, snake_case if False.
             exclude_none: Exclude fields with None values if True.
+            mode: Serialization mode. "python" returns native Python objects,
+                  "json" returns JSON-compatible types (e.g., datetime as ISO string).
 
         Returns:
             List of dictionary representations.
         """
         return [
-            item.model_dump(by_alias=by_alias, exclude_none=exclude_none)
+            item.model_dump(by_alias=by_alias, exclude_none=exclude_none, mode=mode)
             for item in self.root
         ]
 
@@ -122,7 +130,8 @@ def to_json(
         import json
 
         return json.dumps(
-            self.to_list(by_alias=by_alias, exclude_none=exclude_none), indent=indent
+            self.to_list(by_alias=by_alias, exclude_none=exclude_none, mode="json"),
+            indent=indent,
         )
 
     def to_yaml(self, *, by_alias: bool = True, exclude_none: bool = False) -> str:
@@ -135,8 +144,8 @@ def to_yaml(self, *, by_alias: bool = True, exclude_none: bool = False) -> str:
         Returns:
             YAML string representation.
         """
-        return yaml.dump(
-            self.to_list(by_alias=by_alias, exclude_none=exclude_none),
+        return yaml.safe_dump(
+            self.to_list(by_alias=by_alias, exclude_none=exclude_none, mode="json"),
             default_flow_style=False,
             allow_unicode=True,
             sort_keys=False,

tests/core/test_base.py

@@ -1,5 +1,6 @@
 import json
 from dataclasses import dataclass
+from datetime import datetime, timezone
 from unittest.mock import MagicMock
 
 import pytest
@@ -319,6 +320,49 @@ class Item(CamelModel):
         assert "itemId: 1" in result
         assert "itemId: 2" in result
 
+    def test_to_json_with_datetime_field(self):
+        """to_json should properly serialize datetime fields to ISO format."""
+
+        class Item(CamelModel):
+            item_id: int
+            created_at: datetime
+
+        dt = datetime(2026, 2, 7, 12, 30, 45, tzinfo=timezone.utc)
+        items = [Item(item_id=1, created_at=dt)]
+        resource_list = ResourceList[Item](root=items)
+        result = resource_list.to_json()
+
+        parsed = json.loads(result)
+        assert parsed == [{"itemId": 1, "createdAt": "2026-02-07T12:30:45Z"}]
+
+    def test_to_list_mode_json(self):
+        """to_list with mode='json' should return JSON-serializable types."""
+
+        class Item(CamelModel):
+            item_id: int
+            created_at: datetime
+
+        dt = datetime(2026, 2, 7, 12, 30, 45, tzinfo=timezone.utc)
+        items = [Item(item_id=1, created_at=dt)]
+        resource_list = ResourceList[Item](root=items)
+        result = resource_list.to_list(mode="json")
+
+        assert result == [{"itemId": 1, "createdAt": "2026-02-07T12:30:45Z"}]
+
+    def test_to_list_mode_python(self):
+        """to_list with mode='python' (default) should return native Python types."""
+
+        class Item(CamelModel):
+            item_id: int
+            created_at: datetime
+
+        dt = datetime(2026, 2, 7, 12, 30, 45, tzinfo=timezone.utc)
+        items = [Item(item_id=1, created_at=dt)]
+        resource_list = ResourceList[Item](root=items)
+        result = resource_list.to_list()
+
+        assert result == [{"itemId": 1, "createdAt": dt}]
+
 
 class TestResourceBase:
     def test_initialization_with_http_client(self):