Skip to content

Commit edd74ed

Browse files
bm1549claude
andcommitted
fix: restore PHP ksr generation test activation, update missing_feature comments
PHP implements ksr but doesn't support branch overrides in system-tests CI. Keep the original test activated (it passes against released PHP once merged), and mark new edge case tests as missing_feature due to branch override limitation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent c896b97 commit edd74ed

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

manifests/php.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -799,10 +799,9 @@ manifest:
799799
: '>=1.16.0'
800800
? tests/parametric/test_sampling_span_tags.py::Test_Knuth_Sample_Rate::test_sampling_extract_knuth_sample_rate_distributed_tracing_tracecontext
801801
: '>=1.16.0'
802-
tests/parametric/test_sampling_span_tags.py::Test_Knuth_Sample_Rate::test_sampling_knuth_sample_rate_not_set_for_default: missing_feature (ksr generation not implemented)
802+
tests/parametric/test_sampling_span_tags.py::Test_Knuth_Sample_Rate::test_sampling_knuth_sample_rate_not_set_for_default: missing_feature (branch override not supported for PHP)
803803
? tests/parametric/test_sampling_span_tags.py::Test_Knuth_Sample_Rate::test_sampling_knuth_sample_rate_overwritten_by_local_sampling
804-
: missing_feature (ksr generation not implemented)
805-
tests/parametric/test_sampling_span_tags.py::Test_Knuth_Sample_Rate::test_sampling_knuth_sample_rate_trace_sampling_rule: missing_feature (ksr generation not implemented)
804+
: missing_feature (branch override not supported for PHP)
806805
tests/parametric/test_sampling_span_tags.py::Test_Sampling_Span_Tags::test_tags_appsec_enabled_sst011: bug (APMAPI-737)
807806
tests/parametric/test_sampling_span_tags.py::Test_Sampling_Span_Tags::test_tags_child_dropped_sst001: bug (APMAPI-737)
808807
tests/parametric/test_sampling_span_tags.py::Test_Sampling_Span_Tags::test_tags_child_kept_sst007: bug (APMAPI-737)

0 commit comments

Comments
 (0)