refactor(log-agent): rename FlusherMode → Destination; add #[must_use] to from_env

- FlusherMode renamed to Destination — it describes where logs are sent, not how
- #[must_use] added to LogFlusherConfig::from_env() to catch ignored return values

Rationale: reviewer feedback — FlusherMode name is misleading; Destination is more accurate

This commit made by [/dd:git:commit:quick](https://github.com/DataDog/claude-marketplace/tree/main/dd/commands/git/commit/quick.md)

Author: litianningdatadog

Cargo.lock

@@ -42,7 +42,9 @@
 //! | DD_OBSERVABILITY_PIPELINES_WORKER_LOGS_URL       | (empty)            |
 //! | LOG_ENTRY_COUNT                                  | 5                  |
 
-use datadog_log_agent::{AggregatorService, FlusherMode, IntakeEntry, LogFlusher, LogFlusherConfig};
+use datadog_log_agent::{
+    AggregatorService, Destination, IntakeEntry, LogFlusher, LogFlusherConfig,
+};
 
 #[allow(clippy::disallowed_methods)] // plain reqwest::Client for local testing
 #[tokio::main]
@@ -175,11 +177,11 @@ fn now_ms() -> i64 {
 
 fn describe_config(config: &LogFlusherConfig) -> (String, bool) {
     match &config.mode {
-        FlusherMode::Datadog => (
+        Destination::Datadog => (
             format!("https://http-intake.logs.{}/api/v2/logs", config.site),
             config.use_compression,
         ),
-        FlusherMode::ObservabilityPipelinesWorker { url } => (url.clone(), false),
+        Destination::ObservabilityPipelinesWorker { url } => (url.clone(), false),
     }
 }
 

crates/datadog-log-agent/examples/send_logs.rs

@@ -8,7 +8,7 @@ use crate::logs_additional_endpoint::{parse_additional_endpoints, LogsAdditional
 
 /// Controls where and how logs are shipped.
 #[derive(Debug, Clone)]
-pub enum FlusherMode {
+pub enum Destination {
     /// Ship to Datadog Logs API.
     /// Endpoint: `https://http-intake.logs.{site}/api/v2/logs`
     /// Headers: `DD-API-KEY`, `DD-PROTOCOL: agent-json`, optionally `Content-Encoding: zstd`
@@ -30,7 +30,7 @@ pub struct LogFlusherConfig {
     pub site: String,
 
     /// Flusher mode — Datadog vs Observability Pipelines Worker.
-    pub mode: FlusherMode,
+    pub mode: Destination,
 
     /// Additional Datadog intake endpoints to ship each batch to in parallel.
     /// Each endpoint uses its own API key and full intake URL.
@@ -58,6 +58,7 @@ impl LogFlusherConfig {
     /// | `DD_FLUSH_TIMEOUT` | `5` (seconds) |
     /// | `DD_OBSERVABILITY_PIPELINES_WORKER_LOGS_ENABLED` | `false` |
     /// | `DD_OBSERVABILITY_PIPELINES_WORKER_LOGS_URL` | (none) |
+    #[must_use]
     pub fn from_env() -> Self {
         let api_key = std::env::var("DD_API_KEY").unwrap_or_default();
         let site = std::env::var("DD_SITE").unwrap_or_else(|_| DEFAULT_SITE.to_string());
@@ -86,9 +87,9 @@ impl LogFlusherConfig {
             if url.is_empty() {
                 tracing::warn!("OPW mode enabled but DD_OBSERVABILITY_PIPELINES_WORKER_LOGS_URL is not set — log flush will fail");
             }
-            FlusherMode::ObservabilityPipelinesWorker { url }
+            Destination::ObservabilityPipelinesWorker { url }
         } else {
-            FlusherMode::Datadog
+            Destination::Datadog
         };
 
         Self {

crates/datadog-log-agent/src/config.rs

@@ -9,7 +9,7 @@ use tracing::{debug, error, warn};
 use zstd::stream::write::Encoder;
 
 use crate::aggregator::AggregatorHandle;
-use crate::config::{FlusherMode, LogFlusherConfig};
+use crate::config::{Destination, LogFlusherConfig};
 use crate::errors::FlushError;
 
 /// Maximum number of send attempts before giving up on a batch.
@@ -142,11 +142,11 @@ impl LogFlusher {
 
     fn resolve_endpoint(&self) -> (String, bool) {
         match &self.config.mode {
-            FlusherMode::Datadog => {
+            Destination::Datadog => {
                 let url = format!("https://http-intake.logs.{}/api/v2/logs", self.config.site);
                 (url, self.config.use_compression)
             }
-            FlusherMode::ObservabilityPipelinesWorker { url } => {
+            Destination::ObservabilityPipelinesWorker { url } => {
                 // OPW does not support compression
                 (url.clone(), false)
             }
@@ -179,7 +179,7 @@ impl LogFlusher {
             .header("DD-API-KEY", api_key)
             .header("Content-Type", "application/json");
 
-        if matches!(self.config.mode, FlusherMode::Datadog) {
+        if matches!(self.config.mode, Destination::Datadog) {
             req = req.header("DD-PROTOCOL", "agent-json");
         }
 
@@ -284,7 +284,7 @@ fn compress_zstd(data: &[u8], level: i32) -> Result<Vec<u8>, FlushError> {
 mod tests {
     use super::*;
     use crate::aggregator::AggregatorService;
-    use crate::config::{FlusherMode, LogFlusherConfig};
+    use crate::config::{Destination, LogFlusherConfig};
     use crate::intake_entry::IntakeEntry;
     use crate::logs_additional_endpoint::LogsAdditionalEndpoint;
     use mockito::Matcher;
@@ -299,7 +299,7 @@ mod tests {
         LogFlusherConfig {
             api_key: "test-api-key".to_string(),
             site: "datadoghq.com".to_string(),
-            mode: FlusherMode::ObservabilityPipelinesWorker {
+            mode: Destination::ObservabilityPipelinesWorker {
                 url: format!("{mock_url}/api/v2/logs"),
             },
             additional_endpoints: Vec::new(),
@@ -348,7 +348,7 @@ mod tests {
         let config = LogFlusherConfig {
             api_key: "test-api-key".to_string(),
             site: "datadoghq.com".to_string(),
-            mode: FlusherMode::Datadog,
+            mode: Destination::Datadog,
             additional_endpoints: Vec::new(),
             use_compression: false,
             compression_level: 3,
@@ -391,7 +391,7 @@ mod tests {
         let config = LogFlusherConfig {
             api_key: "test-api-key".to_string(),
             site: "unused".to_string(),
-            mode: FlusherMode::ObservabilityPipelinesWorker { url: opw_url },
+            mode: Destination::ObservabilityPipelinesWorker { url: opw_url },
             additional_endpoints: Vec::new(),
             use_compression: false,
             compression_level: 3,
@@ -535,7 +535,7 @@ mod tests {
         let config = LogFlusherConfig {
             api_key: "key".to_string(),
             site: "datadoghq.com".to_string(),
-            mode: FlusherMode::ObservabilityPipelinesWorker {
+            mode: Destination::ObservabilityPipelinesWorker {
                 url: format!("{}/api/v2/logs", primary.url()),
             },
             additional_endpoints: vec![
@@ -610,7 +610,7 @@ mod tests {
         let config = LogFlusherConfig {
             api_key: "key".to_string(),
             site: "datadoghq.com".to_string(),
-            mode: FlusherMode::ObservabilityPipelinesWorker {
+            mode: Destination::ObservabilityPipelinesWorker {
                 url: format!("{}/api/v2/logs", primary.url()),
             },
             additional_endpoints: vec![
@@ -712,7 +712,7 @@ mod tests {
         let config = LogFlusherConfig {
             api_key: "key".to_string(),
             site: "datadoghq.com".to_string(),
-            mode: FlusherMode::ObservabilityPipelinesWorker {
+            mode: Destination::ObservabilityPipelinesWorker {
                 url: format!("{}/api/v2/logs", primary.url()),
             },
             additional_endpoints: vec![LogsAdditionalEndpoint {

crates/datadog-log-agent/src/flusher.rs

@@ -19,7 +19,7 @@ pub mod server;
 
 // Re-export the most commonly used types at the crate root
 pub use aggregator::{AggregatorHandle, AggregatorService};
-pub use config::{FlusherMode, LogFlusherConfig};
+pub use config::{Destination, LogFlusherConfig};
 pub use flusher::LogFlusher;
 pub use intake_entry::IntakeEntry;
 pub use logs_additional_endpoint::LogsAdditionalEndpoint;

crates/datadog-log-agent/src/lib.rs

@@ -12,13 +12,13 @@
 //!   HTTP POST → `LogServer` → `AggregatorHandle::insert_batch` → `LogFlusher::flush` → HTTP endpoint
 //!
 //! HTTP traffic is directed to a local `mockito` server via
-//! `FlusherMode::ObservabilityPipelinesWorker`, which accepts a direct URL.
+//! `Destination::ObservabilityPipelinesWorker`, which accepts a direct URL.
 //! Datadog-mode-specific headers (`DD-PROTOCOL`) are covered by unit tests in `flusher.rs`.
 
 #![allow(clippy::disallowed_methods, clippy::unwrap_used, clippy::expect_used)]
 
 use datadog_log_agent::{
-    AggregatorService, FlusherMode, IntakeEntry, LogFlusher, LogFlusherConfig, LogServer,
+    AggregatorService, Destination, IntakeEntry, LogFlusher, LogFlusherConfig, LogServer,
     LogServerConfig, LogsAdditionalEndpoint,
 };
 use mockito::{Matcher, Server};
@@ -38,7 +38,7 @@ fn opw_config(mock_url: &str) -> LogFlusherConfig {
     LogFlusherConfig {
         api_key: "test-api-key".to_string(),
         site: "ignored.datadoghq.com".to_string(),
-        mode: FlusherMode::ObservabilityPipelinesWorker {
+        mode: Destination::ObservabilityPipelinesWorker {
             url: format!("{}/logs", mock_url),
         },
         additional_endpoints: Vec::new(),
@@ -415,7 +415,7 @@ async fn test_opw_mode_uses_custom_url_and_omits_dd_protocol() {
     let config = LogFlusherConfig {
         api_key: "test-api-key".to_string(),
         site: "ignored".to_string(),
-        mode: FlusherMode::ObservabilityPipelinesWorker {
+        mode: Destination::ObservabilityPipelinesWorker {
             url: format!("{}{}", server.url(), opw_path),
         },
         additional_endpoints: Vec::new(),
@@ -461,7 +461,7 @@ async fn test_opw_mode_disables_compression_regardless_of_config() {
     let config = LogFlusherConfig {
         api_key: "key".to_string(),
         site: "ignored".to_string(),
-        mode: FlusherMode::ObservabilityPipelinesWorker {
+        mode: Destination::ObservabilityPipelinesWorker {
             url: format!("{}/logs", server.url()),
         },
         additional_endpoints: Vec::new(),
@@ -600,7 +600,7 @@ async fn test_additional_endpoints_receive_same_batch() {
     let config = LogFlusherConfig {
         api_key: "test-api-key".to_string(),
         site: "ignored".to_string(),
-        mode: FlusherMode::ObservabilityPipelinesWorker {
+        mode: Destination::ObservabilityPipelinesWorker {
             url: format!("{}/logs", primary.url()),
         },
         additional_endpoints: vec![LogsAdditionalEndpoint {
@@ -648,7 +648,7 @@ async fn test_additional_endpoint_failure_does_not_affect_return_value() {
     let config = LogFlusherConfig {
         api_key: "key".to_string(),
         site: "ignored".to_string(),
-        mode: FlusherMode::ObservabilityPipelinesWorker {
+        mode: Destination::ObservabilityPipelinesWorker {
             url: format!("{}/logs", primary.url()),
         },
         additional_endpoints: vec![LogsAdditionalEndpoint {

crates/datadog-log-agent/tests/integration_test.rs

@@ -28,7 +28,7 @@ use libdd_trace_utils::{config_utils::read_cloud_env, trace_utils::EnvironmentTy
 use datadog_fips::reqwest_adapter::create_reqwest_client_builder;
 use datadog_log_agent::{
     AggregatorHandle as LogAggregatorHandle, AggregatorService as LogAggregatorService,
-    FlusherMode as LogFlusherMode, LogFlusher, LogFlusherConfig, LogServer, LogServerConfig,
+    Destination as LogDestination, LogFlusher, LogFlusherConfig, LogServer, LogServerConfig,
 };
 use dogstatsd::{
     aggregator::{AggregatorHandle, AggregatorService},
@@ -405,7 +405,7 @@ fn start_log_agent(
     };
 
     // Fail fast: OPW mode with an empty URL will always produce a network error at flush time.
-    if let LogFlusherMode::ObservabilityPipelinesWorker { url } = &config.mode {
+    if let LogDestination::ObservabilityPipelinesWorker { url } = &config.mode {
         if url.is_empty() {
             error!("OPW mode enabled but DD_OBSERVABILITY_PIPELINES_WORKER_LOGS_URL is empty — log agent disabled");
             return None;