ci: trim verbose comments in Windows workspace cleanup scripts

Author: Leiyks

.gitlab/generate-package.php

@@ -506,17 +506,11 @@
     GIT_STRATEGY: none
     CONTAINER_NAME: ${CI_JOB_NAME_SLUG}-${CI_JOB_ID}
   script: |
-    # Force-remove all running Docker containers before touching the workspace.
-    # A container from a previous job run may still be alive with the workspace volume mounted,
-    # holding an open handle on php_ddtrace.dll — which makes rd /s /q fail with "Access is denied".
+    # Kill leftover containers — a previous run may still hold php_ddtrace.dll open.
     $containers = docker ps -aq 2>$null
     if ($containers) { docker rm -f $containers 2>$null }
 
-    # Reliable workspace cleanup: navigate to parent and use cmd.exe "rd /s /q" on the whole
-    # workspace directory. cmd.exe rd correctly handles Windows junction points (removes the
-    # junction entry without following it into its target), unlike PowerShell's Remove-Item
-    # -Recurse which throws reparse point mismatch errors on PS 5.1 when the workspace
-    # contains junctions (e.g. created by switch-php) or NTFS symlinks (from core.symlinks clone).
+    # Use cmd.exe rd from the parent dir: handles junctions/symlinks that PS5.1 Remove-Item can't.
     Write-Host "Performing workspace cleanup..."
     $workspace = $PWD.Path
     Push-Location ..
@@ -529,10 +523,8 @@
     if ($remaining) { Write-Host "WARNING: could not remove: $($remaining.Name -join ', ')" }
     Write-Host "Cleanup complete."
 
-    # Fail fast on PowerShell cmdlet errors (works on PS 5.1+).
+    # PS 5.1 ignores $PSNativeCommandUseErrorActionPreference — use $LASTEXITCODE checks instead.
     $ErrorActionPreference = 'Stop'
-    # Note: $PSNativeCommandUseErrorActionPreference requires PS 7.3+ and is silently ignored on PS 5.1
-    # (Windows Server 2019 default). Use explicit $LASTEXITCODE checks for native commands instead.
 
     # Manual git clone with proper config
     Write-Host "Cloning repository..."

.gitlab/generate-tracer.php

@@ -122,17 +122,11 @@ function before_script_steps($with_docker_auth = false) {
     GIT_STRATEGY: none
     IMAGE: "registry.ddbuild.io/images/mirror/datadog/dd-trace-ci:php-${PHP_MAJOR_MINOR}_windows"
   script: |
-    # Force-remove all running Docker containers before touching the workspace.
-    # A container from a previous job run may still be alive with the workspace volume mounted,
-    # holding an open handle on php_ddtrace.dll — which makes rd /s /q fail with "Access is denied".
+    # Kill leftover containers — a previous run may still hold php_ddtrace.dll open.
     $containers = docker ps -aq 2>$null
     if ($containers) { docker rm -f $containers 2>$null }
 
-    # Reliable workspace cleanup: navigate to parent and use cmd.exe "rd /s /q" on the whole
-    # workspace directory. cmd.exe rd correctly handles Windows junction points (removes the
-    # junction entry without following it into its target), unlike PowerShell's Remove-Item
-    # -Recurse which throws reparse point mismatch errors on PS 5.1 when the workspace
-    # contains junctions (e.g. created by switch-php) or NTFS symlinks (from core.symlinks clone).
+    # Use cmd.exe rd from the parent dir: handles junctions/symlinks that PS5.1 Remove-Item can't.
     Write-Host "Performing workspace cleanup..."
     $workspace = $PWD.Path
     Push-Location ..
@@ -145,10 +139,8 @@ function before_script_steps($with_docker_auth = false) {
     if ($remaining) { Write-Host "WARNING: could not remove: $($remaining.Name -join ', ')" }
     Write-Host "Cleanup complete."
 
-    # Fail fast on PowerShell cmdlet errors (works on PS 5.1+).
+    # PS 5.1 ignores $PSNativeCommandUseErrorActionPreference — use $LASTEXITCODE checks instead.
     $ErrorActionPreference = 'Stop'
-    # Note: $PSNativeCommandUseErrorActionPreference requires PS 7.3+ and is silently ignored on PS 5.1
-    # (Windows Server 2019 default). Use explicit $LASTEXITCODE checks for native commands instead.
 
     # Manual git clone with proper config
     Write-Host "Cloning repository..."