From 416ffdd0c09912fa0ab7af0ec358dd9bf8272c37 Mon Sep 17 00:00:00 2001 From: Douglas Q Hawkins Date: Tue, 14 Jul 2026 16:41:05 -0400 Subject: [PATCH] Move perf-review skill to .agents/skills to match repo convention Skills live canonically under .agents/skills/, with a .claude/skills/ symlink so Claude Code still discovers them. perf-review (landed in #11912) was the outlier -- stored as real files under .claude/skills. Move it to .agents/skills/perf-review, add the compatibility symlink matching the other five skills, and point the AGENTS.md reference at the canonical path. Co-Authored-By: Claude Opus 4.8 --- {.claude => .agents}/skills/perf-review/SKILL.md | 0 {.claude => .agents}/skills/perf-review/references/.gitignore | 0 {.claude => .agents}/skills/perf-review/references/checks.md | 0 .../skills/perf-review/references/example-review.md | 0 {.claude => .agents}/skills/perf-review/references/guide.md | 0 .claude/skills/perf-review | 1 + AGENTS.md | 2 +- 7 files changed, 2 insertions(+), 1 deletion(-) rename {.claude => .agents}/skills/perf-review/SKILL.md (100%) rename {.claude => .agents}/skills/perf-review/references/.gitignore (100%) rename {.claude => .agents}/skills/perf-review/references/checks.md (100%) rename {.claude => .agents}/skills/perf-review/references/example-review.md (100%) rename {.claude => .agents}/skills/perf-review/references/guide.md (100%) create mode 120000 .claude/skills/perf-review diff --git a/.claude/skills/perf-review/SKILL.md b/.agents/skills/perf-review/SKILL.md similarity index 100% rename from .claude/skills/perf-review/SKILL.md rename to .agents/skills/perf-review/SKILL.md diff --git a/.claude/skills/perf-review/references/.gitignore b/.agents/skills/perf-review/references/.gitignore similarity index 100% rename from .claude/skills/perf-review/references/.gitignore rename to .agents/skills/perf-review/references/.gitignore diff --git a/.claude/skills/perf-review/references/checks.md b/.agents/skills/perf-review/references/checks.md similarity index 100% rename from .claude/skills/perf-review/references/checks.md rename to .agents/skills/perf-review/references/checks.md diff --git a/.claude/skills/perf-review/references/example-review.md b/.agents/skills/perf-review/references/example-review.md similarity index 100% rename from .claude/skills/perf-review/references/example-review.md rename to .agents/skills/perf-review/references/example-review.md diff --git a/.claude/skills/perf-review/references/guide.md b/.agents/skills/perf-review/references/guide.md similarity index 100% rename from .claude/skills/perf-review/references/guide.md rename to .agents/skills/perf-review/references/guide.md diff --git a/.claude/skills/perf-review b/.claude/skills/perf-review new file mode 120000 index 00000000000..60946879935 --- /dev/null +++ b/.claude/skills/perf-review @@ -0,0 +1 @@ +../../.agents/skills/perf-review \ No newline at end of file diff --git a/AGENTS.md b/AGENTS.md index 665c412693e..d733da597d6 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -77,7 +77,7 @@ Before marking a PR ready, run the applicable reviews below over the branch chan ### Performance Review -Follow the performance-review guidelines in [.claude/skills/perf-review/SKILL.md](.claude/skills/perf-review/SKILL.md) — the do-no-harm / assume-hot posture, the hot-path checks (universal + Java J1–J11 + ByteBuddy-Advice idioms), and the confidence/severity model, with the detailed rubric in its `references/`. Scope: hot-path allocation, unbounded memory, repeated work, escaping objects, native-boundary crossings, and JVM-specific pitfalls. +Follow the performance-review guidelines in [.agents/skills/perf-review/SKILL.md](.agents/skills/perf-review/SKILL.md) — the do-no-harm / assume-hot posture, the hot-path checks (universal + Java J1–J11 + ByteBuddy-Advice idioms), and the confidence/severity model, with the detailed rubric in its `references/`. Scope: hot-path allocation, unbounded memory, repeated work, escaping objects, native-boundary crossings, and JVM-specific pitfalls. ## Bootstrap constraints (critical)