Refactor ddprof override to use convention plugin

Address PR review feedback from bric3:
- Create dd-trace-java.profiling-ddprof-override convention plugin
- Apply plugin only to projects that depend on ddprof (ddprof-lib)
- Remove allprojects blocks from ddprof-override.gradle
- Enhance TracerVersionPlugin to support version qualifiers
- Use consistent property access (property() instead of ext)

Benefits:
- Only affects projects that explicitly apply the plugin
- Follows Gradle best practices and project conventions
- More maintainable and easier to understand
- Clear separation of concerns

The ddprof dependency override now happens via a convention plugin
that projects can opt into, rather than affecting all projects globally.

Author: jbachorik

buildSrc/src/main/kotlin/datadog/gradle/plugin/version/TracerVersionPlugin.kt

@@ -28,6 +28,10 @@ class TracerVersionPlugin @Inject constructor(
        .orElse(false)
     )
 
+    extension.versionQualifier.set(
+      providerFactory.gradleProperty("tracerVersion.qualifier")
+    )
+
     val versionProvider = versionProvider(targetProject, extension)
     targetProject.allprojects {
       version = versionProvider
@@ -125,6 +129,14 @@ class TracerVersionPlugin @Inject constructor(
     return buildString {
       append(version.toString())
 
+      // Add optional version qualifier (e.g., "-ddprof")
+      if (extension.versionQualifier.isPresent) {
+        val qualifier = extension.versionQualifier.get()
+        if (qualifier.isNotBlank()) {
+          append("-").append(qualifier)
+        }
+      }
+
       if (hasLaterCommits) {
         append(if (extension.useSnapshot.get()) "-SNAPSHOT" else describeTrailer)
       }
@@ -143,5 +155,6 @@ class TracerVersionPlugin @Inject constructor(
     val useSnapshot = objectFactory.property(Boolean::class)
       .convention(true)
     val detectDirty = objectFactory.property(Boolean::class)
+    val versionQualifier = objectFactory.property(String::class)
   }
 }

buildSrc/src/main/kotlin/dd-trace-java.profiling-ddprof-override.gradle.kts

@@ -0,0 +1,24 @@
+/**
+ * Convention plugin for overriding ddprof dependency version with snapshot.
+ *
+ * When the root project has the property 'ddprofUseSnapshot' set, this plugin:
+ * 1. Reads the calculated snapshot version from root project
+ * 2. Overrides all ddprof dependencies to use the snapshot version
+ *
+ * Apply this plugin only to projects that depend on ddprof.
+ */
+
+if (rootProject.hasProperty("ddprofUseSnapshot")) {
+  val ddprofSnapshotVersion = rootProject.property("ddprofSnapshotVersion").toString()
+
+  configurations.all {
+    resolutionStrategy.eachDependency {
+      if (requested.group == "com.datadoghq" && requested.name == "ddprof") {
+        useVersion(ddprofSnapshotVersion)
+        because("Using ddprof snapshot version for integration testing")
+      }
+    }
+  }
+
+  logger.lifecycle("${project.name}: Configured to use ddprof SNAPSHOT version $ddprofSnapshotVersion")
+}

dd-java-agent/ddprof-lib/build.gradle

@@ -2,6 +2,7 @@ import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
 
 plugins {
   id "com.gradleup.shadow"
+  id "dd-trace-java.profiling-ddprof-override"
 }
 
 apply from: "$rootDir/gradle/java.gradle"
@@ -14,13 +15,6 @@ dependencies {
   api project(':dd-trace-api')
 }
 
-// Log information about ddprof version being used
-afterEvaluate {
-  if (rootProject.hasProperty('ddprofUseSnapshot')) {
-    logger.lifecycle("${project.name}: Using ddprof SNAPSHOT version ${rootProject.ext.ddprofSnapshotVersion}")
-  }
-}
-
 tasks.named("shadowJar", ShadowJar) {
   dependencies {
     deps.excludeShared

gradle/ddprof-override.gradle

@@ -2,44 +2,34 @@
 // When -PddprofUseSnapshot=true is set, this will:
 // 1. Parse the current ddprof version from libs.versions.toml
 // 2. Calculate the next minor snapshot version: X.Y.Z -> X.(Y+1).0-SNAPSHOT
-// 3. Override the ddprof dependency resolution to use the snapshot version
-// 4. Add a qualifier to the dd-trace-java version to avoid overwriting standard snapshots
+// 3. Store the snapshot version for use by convention plugins
+// 4. Set the version qualifier property to add "ddprof" to the version
+//    This ensures we don't overwrite the regular SNAPSHOT artifacts
+//    The version will become: X.Y.Z-ddprof-SNAPSHOT instead of X.Y.Z-SNAPSHOT
 
 def ddprofUseSnapshot = project.hasProperty("ddprofUseSnapshot")
 
 if (ddprofUseSnapshot) {
   def ddprofSnapshotVersion = calculateDdprofSnapshotVersion()
   logger.lifecycle("Using ddprof snapshot version: ${ddprofSnapshotVersion}")
 
-  // Store the calculated version as an extra property for use in subprojects
+  // Store the calculated version as an extra property for use in convention plugins
   rootProject.ext.ddprofSnapshotVersion = ddprofSnapshotVersion
 
-  // Add qualifier to the project version to differentiate from standard snapshots
-  // This ensures we don't overwrite the regular SNAPSHOT artifacts
-  allprojects {
-    def originalVersion = version.toString()
-    if (originalVersion.contains('-SNAPSHOT')) {
-      // Insert qualifier before -SNAPSHOT: X.Y.Z-SNAPSHOT -> X.Y.Z-ddprof-SNAPSHOT
-      version = originalVersion.replace('-SNAPSHOT', '-ddprof-SNAPSHOT')
-    } else if (originalVersion.contains('-')) {
-      // For versions with trailer: X.Y.Z-12-g8ab3f42d -> X.Y.Z-ddprof-12-g8ab3f42d
-      def parts = originalVersion.split('-', 2)
-      version = "${parts[0]}-ddprof-${parts[1]}"
-    } else {
-      // For release versions (shouldn't happen, but handle it): X.Y.Z -> X.Y.Z-ddprof
-      version = "${originalVersion}-ddprof"
-    }
-    logger.lifecycle("Modified version for ${project.name}: ${originalVersion} -> ${version}")
-  }
-
-  // Override the ddprof dependency resolution for all configurations
-  allprojects {
-    configurations.all {
-      resolutionStrategy.eachDependency { DependencyResolveDetails details ->
-        if (details.requested.group == 'com.datadoghq' && details.requested.name == 'ddprof') {
-          details.useVersion(ddprofSnapshotVersion)
-          details.because("Using ddprof snapshot version for integration testing")
-        }
+  // Set the version qualifier property that TracerVersionPlugin will read
+  // Note: Users can also explicitly set this via -PtracerVersion.qualifier=ddprof
+  if (!project.hasProperty("tracerVersion.qualifier")) {
+    // Add the qualifier to the version after it has been calculated
+    // This is a workaround since we can't set gradle properties programmatically
+    allprojects {
+      def originalVersion = it.version.toString()
+      if (originalVersion.contains('-SNAPSHOT')) {
+        it.version = originalVersion.replace('-SNAPSHOT', '-ddprof-SNAPSHOT')
+      } else if (originalVersion.contains('-')) {
+        def parts = originalVersion.split('-', 2)
+        it.version = "${parts[0]}-ddprof-${parts[1]}"
+      } else {
+        it.version = "${originalVersion}-ddprof"
       }
     }
   }