-
Notifications
You must be signed in to change notification settings - Fork 331
Expand file tree
/
Copy pathConfigurationUpdaterTest.java
More file actions
725 lines (686 loc) · 34.4 KB
/
ConfigurationUpdaterTest.java
File metadata and controls
725 lines (686 loc) · 34.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
package com.datadog.debugger.agent;
import static com.datadog.debugger.agent.ConfigurationAcceptor.Source.REMOTE_CONFIG;
import static com.datadog.debugger.agent.DebuggerProductChangesListener.LOG_PROBE_PREFIX;
import static java.util.Collections.singletonList;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.lenient;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoInteractions;
import static org.mockito.Mockito.when;
import static utils.InstrumentationTestHelper.compile;
import static utils.InstrumentationTestHelper.loadClass;
import com.datadog.debugger.el.DSL;
import com.datadog.debugger.el.ProbeCondition;
import com.datadog.debugger.probe.LogProbe;
import com.datadog.debugger.probe.MetricProbe;
import com.datadog.debugger.probe.ProbeDefinition;
import com.datadog.debugger.probe.SpanDecorationProbe;
import com.datadog.debugger.probe.SpanProbe;
import com.datadog.debugger.sink.DebuggerSink;
import com.datadog.debugger.sink.ProbeStatusSink;
import datadog.environment.JavaVirtualMachine;
import datadog.trace.api.Config;
import datadog.trace.bootstrap.debugger.ProbeId;
import datadog.trace.bootstrap.debugger.ProbeImplementation;
import java.io.IOException;
import java.lang.instrument.Instrumentation;
import java.lang.instrument.UnmodifiableClassException;
import java.net.URISyntaxException;
import java.util.*;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.function.Function;
import java.util.stream.Collectors;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.EnabledForJreRange;
import org.junit.jupiter.api.condition.JRE;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.ArgumentCaptor;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import utils.SourceCompiler;
@ExtendWith(MockitoExtension.class)
public class ConfigurationUpdaterTest {
private static final String LANGUAGE = "java";
private static final ProbeId PROBE_ID = new ProbeId("beae1807-f3b0-4ea8-a74f-826790c5e6f8", 42);
private static final ProbeId PROBE_ID2 = new ProbeId("beae1808-f3b0-4ea8-a74f-826790c5e6f8", 12);
private static final ProbeId METRIC_ID = new ProbeId("cfbf2918-e4c1-5fb9-b85e-937881d6f7e9", 1);
private static final ProbeId METRIC_ID2 = new ProbeId("cfbf2919-e4c1-5fb9-b85e-937881d6f7e9", 5);
private static final ProbeId LOG_ID = new ProbeId("d0c03a2a-f5d2-60ca-c96f-a48992e708fa", 2);
private static final ProbeId LOG_ID2 = new ProbeId("d0c03a2b-f5d2-60ca-c96f-a48992e708fa", 6);
private static final ProbeId SPAN_ID = new ProbeId("cfbf2918-e4c1-5fb9-b85e-937881d6f7e9", 1);
private static final ProbeId SPAN_DECORATION_ID =
new ProbeId("cfbf2918-e4c1-5fb9-b85e-937881d6f7e9", 1);
@Mock private Instrumentation inst;
@Mock private DebuggerTransformer transformer;
@Mock private Config tracerConfig;
@Mock private DebuggerSink debuggerSink;
@Mock private ProbeStatusSink probeStatusSink;
private DebuggerSink debuggerSinkWithMockStatusSink;
@BeforeEach
void setUp() {
lenient().when(tracerConfig.getFinalDebuggerSnapshotUrl()).thenReturn("http://localhost");
lenient().when(tracerConfig.getDynamicInstrumentationUploadBatchSize()).thenReturn(100);
lenient().when(tracerConfig.getFinalDebuggerSymDBUrl()).thenReturn("http://localhost");
debuggerSinkWithMockStatusSink = new DebuggerSink(tracerConfig, probeStatusSink);
}
@Test
public void acceptNoProbes() {
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSink);
configurationUpdater.accept(REMOTE_CONFIG, null);
verify(inst, never()).addTransformer(any(), eq(true));
verifyNoInteractions(debuggerSink);
}
@Test
public void acceptNewProbe() {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSinkWithMockStatusSink);
List<LogProbe> logProbes =
singletonList(
LogProbe.builder().probeId(PROBE_ID).where("java.lang.String", "concat").build());
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(inst).addTransformer(any(), eq(true));
verify(inst).getAllLoadedClasses();
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(1, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(PROBE_ID.getEncodedId()));
verify(probeStatusSink).addReceived(eq(PROBE_ID));
}
@Test
public void acceptNewMultiProbes() throws UnmodifiableClassException {
doTestAcceptMultiProbes(Class::getName, String.class, HashMap.class);
}
@Test
public void acceptNewMultiProbesSimpleName() throws UnmodifiableClassException {
doTestAcceptMultiProbes(Class::getSimpleName, String.class, HashMap.class);
}
private void doTestAcceptMultiProbes(Function<Class<?>, String> getClassName, Class<?>... classes)
throws UnmodifiableClassException {
when(inst.getAllLoadedClasses()).thenReturn(classes);
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSinkWithMockStatusSink);
List<LogProbe> logProbes =
Arrays.stream(classes)
.map(getClassName)
.map(className -> LogProbe.builder().probeId(PROBE_ID).where(className, "foo").build())
.collect(Collectors.toList());
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(inst).addTransformer(any(), eq(true));
verify(inst).getAllLoadedClasses();
for (Class<?> expectedClass : classes) {
verify(inst).retransformClasses(eq(expectedClass));
}
verify(probeStatusSink, times(2)).addReceived(eq(PROBE_ID));
}
@Test
public void acceptDuplicatedProbes() {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSinkWithMockStatusSink);
List<LogProbe> logProbes =
Arrays.asList(
LogProbe.builder().probeId(PROBE_ID).where("java.lang.String", "concat").build(),
LogProbe.builder().probeId(PROBE_ID2).where("java.lang.String", "concat").build());
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(inst).addTransformer(any(), eq(true));
verify(inst).getAllLoadedClasses();
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(2, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(PROBE_ID.getEncodedId()));
assertTrue(appliedDefinitions.containsKey(PROBE_ID2.getEncodedId()));
verify(probeStatusSink).addReceived(eq(PROBE_ID));
verify(probeStatusSink).addReceived(eq(PROBE_ID2));
}
@Test
public void accept2PhaseDuplicatedProbes() {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSinkWithMockStatusSink);
// phase 1: single probe definition
List<LogProbe> logProbes =
Arrays.asList(
LogProbe.builder().probeId(PROBE_ID).where("java.lang.String", "concat").build());
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(inst).addTransformer(any(), eq(true));
verify(inst).getAllLoadedClasses();
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(1, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(PROBE_ID.getEncodedId()));
// phase 2: add duplicated probe definitions
logProbes =
Arrays.asList(
LogProbe.builder().probeId(PROBE_ID).where("java.lang.String", "concat").build(),
LogProbe.builder().probeId(PROBE_ID2).where("java.lang.String", "concat").build());
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(2, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(PROBE_ID2.getEncodedId()));
verify(probeStatusSink).addReceived(eq(PROBE_ID));
verify(probeStatusSink).addReceived(eq(PROBE_ID2));
}
@Test
public void acceptRemoveDuplicatedProbes() {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSinkWithMockStatusSink);
// phase 1: duplicated probe definition
List<LogProbe> logProbes =
Arrays.asList(
LogProbe.builder().probeId(PROBE_ID).where("java.lang.String", "concat").build(),
LogProbe.builder().probeId(PROBE_ID2).where("java.lang.String", "concat").build());
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(inst).addTransformer(any(), eq(true));
verify(inst).getAllLoadedClasses();
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(2, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(PROBE_ID.getEncodedId()));
assertTrue(appliedDefinitions.containsKey(PROBE_ID2.getEncodedId()));
// phase 2: remove duplicated probe definitions
logProbes =
Arrays.asList(
LogProbe.builder().probeId(PROBE_ID).where("java.lang.String", "concat").build());
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(1, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(PROBE_ID.getEncodedId()));
verify(probeStatusSink).addReceived(eq(PROBE_ID));
verify(probeStatusSink).addReceived(eq(PROBE_ID2));
verify(probeStatusSink).removeDiagnostics(eq(PROBE_ID2));
}
@Test
public void acceptDontDedupMetricProbes() {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSinkWithMockStatusSink);
List<LogProbe> logProbes =
Arrays.asList(
LogProbe.builder().probeId(PROBE_ID).where("java.lang.String", "concat").build());
List<MetricProbe> metricProbes =
Arrays.asList(
MetricProbe.builder().probeId(METRIC_ID).where("java.lang.String", "concat").build());
List<ProbeDefinition> definitions = new ArrayList<>(metricProbes);
definitions.addAll(logProbes);
configurationUpdater.accept(REMOTE_CONFIG, definitions);
verify(inst).addTransformer(any(), eq(true));
verify(inst).getAllLoadedClasses();
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(2, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(PROBE_ID.getEncodedId()));
assertTrue(appliedDefinitions.containsKey(METRIC_ID.getEncodedId()));
verify(probeStatusSink).addReceived(eq(PROBE_ID));
verify(probeStatusSink).addReceived(eq(METRIC_ID));
}
@Test
public void acceptSourceFileLineNumber() throws UnmodifiableClassException {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSink);
List<LogProbe> logProbes =
singletonList(
LogProbe.builder()
.probeId(PROBE_ID)
.where(null, null, null, 1966, "src/main/java/java/lang/String.java")
.build());
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(inst).addTransformer(any(), eq(true));
verify(inst).getAllLoadedClasses();
verify(inst).retransformClasses(eq(String.class));
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(1, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(PROBE_ID.getEncodedId()));
}
@Test
public void acceptSourceFileLineNumberEmptyTypeName() throws UnmodifiableClassException {
// create anonymous class for dealing with Class#getSimpleName returning empty string for it
Runnable runnable =
new Runnable() {
@Override
public void run() {}
};
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class, runnable.getClass()});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSink);
List<LogProbe> logProbes =
singletonList(
LogProbe.builder()
.probeId(PROBE_ID)
.where("", "", "", 1966, "java/lang/String.java")
.build());
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(inst).addTransformer(any(), eq(true));
verify(inst).getAllLoadedClasses();
verify(inst).retransformClasses(eq(String.class));
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(1, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(PROBE_ID.getEncodedId()));
}
@Test
public void acceptSourceFileLineNumberAnonymousClass() throws UnmodifiableClassException {
Runnable runnable =
new Runnable() {
@Override
public void run() {}
};
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class, runnable.getClass()});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSink);
List<LogProbe> logProbes =
singletonList(
LogProbe.builder()
.probeId(PROBE_ID)
.where("", "", "", 136, "ConfigurationUpdaterTest$2")
.build());
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(inst).addTransformer(any(), eq(true));
verify(inst).getAllLoadedClasses();
verify(inst).retransformClasses(eq(runnable.getClass()));
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(1, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(PROBE_ID.getEncodedId()));
}
@Test
public void acceptDeleteProbe() throws UnmodifiableClassException {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class, HashMap.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSinkWithMockStatusSink);
LogProbe probe1 =
LogProbe.builder()
.language(LANGUAGE)
.probeId(PROBE_ID)
.where("java.lang.String", "concat")
.build();
LogProbe probe2 =
LogProbe.builder()
.language(LANGUAGE)
.probeId(PROBE_ID2)
.where("java.util.HashMap", "<init>", "void ()")
.build();
List<LogProbe> logProbes = Arrays.asList(probe1, probe2);
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(probeStatusSink).addReceived(eq(PROBE_ID));
verify(probeStatusSink).addReceived(eq(PROBE_ID2));
logProbes = singletonList(probe1);
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(probeStatusSink).removeDiagnostics(eq(PROBE_ID2));
verify(inst).removeTransformer(any());
ArgumentCaptor<Class<?>[]> captor = ArgumentCaptor.forClass(Class[].class);
verify(inst, times(3)).retransformClasses(captor.capture());
List<Class<?>[]> allValues = captor.getAllValues();
assertEquals(String.class, allValues.get(0));
assertEquals(HashMap.class, allValues.get(1));
assertEquals(HashMap.class, allValues.get(2)); // for removing instrumentation
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
Assertions.assertEquals(1, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(probe1.getProbeId().getEncodedId()));
}
@Test
public void acceptDeleteProbeSameClass() throws UnmodifiableClassException {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
AtomicInteger expectedDefinitions = new AtomicInteger(2);
ConfigurationUpdater configurationUpdater =
new ConfigurationUpdater(
inst,
(tracerConfig, configuration, listener, probeMetadata, debuggerSink) -> {
assertEquals(expectedDefinitions.get(), configuration.getDefinitions().size());
return transformer;
},
tracerConfig,
debuggerSinkWithMockStatusSink,
new ClassesToRetransformFinder());
LogProbe probe1 =
LogProbe.builder()
.language(LANGUAGE)
.probeId(PROBE_ID)
.where("java.lang.String", "concat")
.build();
LogProbe probe2 =
LogProbe.builder()
.language(LANGUAGE)
.probeId(PROBE_ID2)
.where("java.lang.String", "indexOf", "int (int)")
.build();
List<LogProbe> logProbes = Arrays.asList(probe1, probe2);
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(probeStatusSink).addReceived(eq(PROBE_ID));
verify(probeStatusSink).addReceived(eq(PROBE_ID2));
logProbes = singletonList(probe1);
expectedDefinitions.set(1);
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(probeStatusSink).removeDiagnostics(eq(PROBE_ID2));
verify(inst).removeTransformer(any());
ArgumentCaptor<Class<?>[]> captor = ArgumentCaptor.forClass(Class[].class);
verify(inst, times(2)).retransformClasses(captor.capture());
List<Class<?>[]> allValues = captor.getAllValues();
assertEquals(String.class, allValues.get(0));
assertEquals(String.class, allValues.get(1));
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
Assertions.assertEquals(1, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(probe1.getProbeId().getEncodedId()));
}
@Test
public void acceptClearProbes() throws UnmodifiableClassException {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSinkWithMockStatusSink);
List<LogProbe> logProbes =
singletonList(
LogProbe.builder().probeId(PROBE_ID).where("java.lang.String", "concat").build());
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(probeStatusSink).addReceived(eq(PROBE_ID));
configurationUpdater.accept(REMOTE_CONFIG, null);
verify(probeStatusSink).removeDiagnostics(eq(PROBE_ID));
verify(inst).removeTransformer(any());
verify(inst, times(2)).retransformClasses(any());
Assertions.assertEquals(0, configurationUpdater.getAppliedDefinitions().size());
}
@Test
public void resolve() {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSink);
List<LogProbe> logProbes =
singletonList(
LogProbe.builder()
.probeId(PROBE_ID)
.where("java.lang.String", "concat")
.when(
new ProbeCondition(
DSL.when(DSL.eq(DSL.ref("arg"), DSL.value("foo"))), "arg == 'foo'"))
.build());
logProbes.get(0).buildLocation(null);
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
configurationUpdater.getProbeMetadata().addProbe(logProbes.get(0));
ProbeImplementation probeImplementation = configurationUpdater.resolve(0);
Assertions.assertEquals(
PROBE_ID.getEncodedId(), probeImplementation.getProbeId().getEncodedId());
Assertions.assertEquals("java.lang.String", probeImplementation.getLocation().getType());
Assertions.assertEquals("concat", probeImplementation.getLocation().getMethod());
Assertions.assertNotNull(((LogProbe) probeImplementation).getProbeCondition());
}
@Test
public void resolveFails() throws UnmodifiableClassException {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSink);
List<LogProbe> logProbes =
singletonList(
LogProbe.builder().probeId(PROBE_ID).where("java.lang.String", "concat").build());
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(inst).retransformClasses(eq(String.class));
// simulate that there is a snapshot probe instrumentation left in HashMap class
ProbeImplementation probeImplementation = configurationUpdater.resolve(1);
Assertions.assertNull(probeImplementation);
}
@Test
public void acceptNewMetric() {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSink);
List<MetricProbe> metricProbes =
singletonList(
MetricProbe.builder().probeId(METRIC_ID).where("java.lang.String", "concat").build());
configurationUpdater.accept(REMOTE_CONFIG, metricProbes);
verify(inst).addTransformer(any(), eq(true));
verify(inst).getAllLoadedClasses();
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(1, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(METRIC_ID.getEncodedId()));
}
@Test
public void acceptNewLog() {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSink);
List<LogProbe> logProbes =
singletonList(
LogProbe.builder().probeId(LOG_ID).where("java.lang.String", "concat").build());
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(inst).addTransformer(any(), eq(true));
verify(inst).getAllLoadedClasses();
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(1, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(LOG_ID.getEncodedId()));
}
@Test
public void acceptDeleteMetric() throws UnmodifiableClassException {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class, HashMap.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSink);
MetricProbe metricProbe1 =
MetricProbe.builder()
.language(LANGUAGE)
.probeId(METRIC_ID)
.where("java.lang.String", "concat")
.build();
MetricProbe metricProbe2 =
MetricProbe.builder()
.language(LANGUAGE)
.probeId(METRIC_ID2)
.where("java.util.HashMap", "<init>", "void ()")
.build();
List<MetricProbe> metricProbes = Arrays.asList(metricProbe1, metricProbe2);
configurationUpdater.accept(REMOTE_CONFIG, metricProbes);
metricProbes = singletonList(metricProbe1);
configurationUpdater.accept(REMOTE_CONFIG, metricProbes);
verify(inst).removeTransformer(any());
ArgumentCaptor<Class<?>[]> captor = ArgumentCaptor.forClass(Class[].class);
verify(inst, times(3)).retransformClasses(captor.capture());
List<Class<?>[]> allValues = captor.getAllValues();
assertEquals(String.class, allValues.get(0));
assertEquals(HashMap.class, allValues.get(1));
assertEquals(HashMap.class, allValues.get(2)); // for removing instrumentation
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(1, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(metricProbe1.getProbeId().getEncodedId()));
}
@Test
public void acceptDeleteLog() throws UnmodifiableClassException {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class, HashMap.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSink);
LogProbe logProbe1 =
LogProbe.builder()
.language(LANGUAGE)
.probeId(LOG_ID)
.where("java.lang.String", "concat")
.build();
LogProbe logProbe2 =
LogProbe.builder()
.language(LANGUAGE)
.probeId(LOG_ID2)
.where("java.util.HashMap", "<init>", "void ()")
.build();
List<LogProbe> logProbes = Arrays.asList(logProbe1, logProbe2);
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
logProbes = singletonList(logProbe1);
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
verify(inst).removeTransformer(any());
ArgumentCaptor<Class<?>[]> captor = ArgumentCaptor.forClass(Class[].class);
verify(inst, times(3)).retransformClasses(captor.capture());
List<Class<?>[]> allValues = captor.getAllValues();
assertEquals(String.class, allValues.get(0));
assertEquals(HashMap.class, allValues.get(1));
assertEquals(HashMap.class, allValues.get(2)); // for removing instrumentation
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(1, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(logProbe1.getProbeId().getEncodedId()));
}
@Test
public void acceptClearMetrics() throws UnmodifiableClassException {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSink);
List<MetricProbe> metricProbes =
singletonList(
MetricProbe.builder().probeId(METRIC_ID).where("java.lang.String", "concat").build());
configurationUpdater.accept(REMOTE_CONFIG, metricProbes);
configurationUpdater.accept(REMOTE_CONFIG, null);
verify(inst).removeTransformer(any());
verify(inst, times(2)).retransformClasses(any());
assertEquals(0, configurationUpdater.getAppliedDefinitions().size());
}
@Test
public void acceptClearLogs() throws UnmodifiableClassException {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSink);
List<LogProbe> logProbes =
singletonList(
LogProbe.builder().probeId(LOG_ID).where("java.lang.String", "concat").build());
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
configurationUpdater.accept(REMOTE_CONFIG, null);
verify(inst).removeTransformer(any());
verify(inst, times(2)).retransformClasses(any());
assertEquals(0, configurationUpdater.getAppliedDefinitions().size());
}
@Test
public void acceptChangeProbeToMetric() throws UnmodifiableClassException {
when(inst.getAllLoadedClasses())
.thenReturn(new Class[] {String.class, HashMap.class, StringBuilder.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSink);
List<LogProbe> logProbes =
Arrays.asList(
LogProbe.builder()
.language(LANGUAGE)
.probeId(PROBE_ID)
.where("java.lang.String", "concat")
.build(),
LogProbe.builder()
.language(LANGUAGE)
.probeId(PROBE_ID2)
.where("java.util.HashMap", "<init>", "void ()")
.build());
configurationUpdater.accept(REMOTE_CONFIG, logProbes);
List<MetricProbe> metricProbes =
singletonList(
MetricProbe.builder()
.language(LANGUAGE)
.probeId(METRIC_ID)
.where("java.lang.StringBuilder", "append")
.build());
configurationUpdater.accept(REMOTE_CONFIG, metricProbes);
verify(inst).removeTransformer(any());
ArgumentCaptor<Class<?>[]> captor = ArgumentCaptor.forClass(Class[].class);
verify(inst, times(5)).retransformClasses(captor.capture());
List<Class<?>[]> allValues = captor.getAllValues();
assertEquals(String.class, allValues.get(0));
assertEquals(HashMap.class, allValues.get(1));
assertEquals(String.class, allValues.get(2));
assertEquals(HashMap.class, allValues.get(3));
assertEquals(StringBuilder.class, allValues.get(4));
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(1, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(METRIC_ID.getEncodedId()));
}
@Test
public void acceptNewSpan() {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSink);
SpanProbe spanProbe =
SpanProbe.builder().probeId(SPAN_ID).where("java.lang.String", "concat").build();
configurationUpdater.accept(REMOTE_CONFIG, singletonList(spanProbe));
verify(inst).addTransformer(any(), eq(true));
verify(inst).getAllLoadedClasses();
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(1, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(SPAN_ID.getEncodedId()));
}
@Test
public void acceptNewDecorationSpan() {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {String.class});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSink);
SpanDecorationProbe spanProbe =
SpanDecorationProbe.builder()
.probeId(SPAN_DECORATION_ID)
.where("java.lang.String", "concat")
.build();
configurationUpdater.accept(REMOTE_CONFIG, singletonList(spanProbe));
verify(inst).addTransformer(any(), eq(true));
verify(inst).getAllLoadedClasses();
Map<String, ProbeDefinition> appliedDefinitions = configurationUpdater.getAppliedDefinitions();
assertEquals(1, appliedDefinitions.size());
assertTrue(appliedDefinitions.containsKey(SPAN_DECORATION_ID.getEncodedId()));
}
@Test
public void handleException() {
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSinkWithMockStatusSink);
Exception ex = new Exception("oops");
configurationUpdater.handleException(LOG_PROBE_PREFIX + PROBE_ID.getId(), ex);
verify(probeStatusSink).addError(eq(ProbeId.from(PROBE_ID.getId() + ":0")), eq(ex));
}
@Test
public void methodParametersAttribute() throws Exception {
final String CLASS_NAME = "CapturedSnapshot01";
Map<String, byte[]> buffers =
compile(CLASS_NAME, SourceCompiler.DebugInfo.ALL, "8", Arrays.asList("-parameters"));
Class<?> testClass = loadClass(CLASS_NAME, buffers);
if (JavaVirtualMachine.isJavaVersion(17)) {
// on JDK 17 introduced Spring6 class
Class<?> springClass = Class.forName("org.springframework.core.SpringVersion");
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {testClass, springClass});
} else {
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {testClass});
}
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSinkWithMockStatusSink);
configurationUpdater.accept(
REMOTE_CONFIG,
singletonList(LogProbe.builder().probeId(PROBE_ID).where(CLASS_NAME, "main").build()));
if (JavaVirtualMachine.isJavaVersion(17)) {
// on JDK 17 with Spring6 class, transformation cannot happen
verify(inst, times(2)).getAllLoadedClasses();
verify(inst, times(0)).retransformClasses(any());
ArgumentCaptor<ProbeId> probeIdCaptor = ArgumentCaptor.forClass(ProbeId.class);
ArgumentCaptor<String> strCaptor = ArgumentCaptor.forClass(String.class);
verify(probeStatusSink, times(1)).addError(probeIdCaptor.capture(), strCaptor.capture());
assertEquals(PROBE_ID.getId(), probeIdCaptor.getAllValues().get(0).getId());
assertEquals(
"Method Parameters detected, instrumentation not supported for CapturedSnapshot01",
strCaptor.getAllValues().get(0));
} else {
ArgumentCaptor<Class<?>[]> captor = ArgumentCaptor.forClass(Class[].class);
verify(inst, times(1)).retransformClasses(captor.capture());
List<Class<?>[]> allValues = captor.getAllValues();
assertEquals(testClass, allValues.get(0));
}
}
@Test
@EnabledForJreRange(min = JRE.JAVA_17)
public void methodParametersAttributeRecord()
throws IOException, URISyntaxException, UnmodifiableClassException {
// make sure record method are not detected as having methodParameters attribute.
// /!\ record canonical constructor has the MethodParameters attribute,
// but not returned by Class::getDeclaredMethods()
final String CLASS_NAME = "com.datadog.debugger.CapturedSnapshot29";
final String RECORD_NAME = "com.datadog.debugger.MyRecord1";
Map<String, byte[]> buffers = compile(CLASS_NAME, SourceCompiler.DebugInfo.ALL, "17");
Class<?> testClass = loadClass(RECORD_NAME, buffers);
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {testClass});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSinkWithMockStatusSink);
configurationUpdater.accept(
REMOTE_CONFIG,
singletonList(LogProbe.builder().probeId(PROBE_ID).where(RECORD_NAME, "<init>").build()));
verify(inst).getAllLoadedClasses();
ArgumentCaptor<Class<?>[]> captor = ArgumentCaptor.forClass(Class[].class);
verify(inst, times(1)).retransformClasses(captor.capture());
List<Class<?>[]> allValues = captor.getAllValues();
assertEquals(testClass, allValues.get(0));
}
@Test
@EnabledForJreRange(min = JRE.JAVA_17)
public void recordWithTypeAnnotation()
throws IOException, URISyntaxException, UnmodifiableClassException {
// make sure record method are not detected as having methodParameters attribute.
// /!\ record canonical constructor has the MethodParameters attribute,
// but not returned by Class::getDeclaredMethods()
final String CLASS_NAME = "com.datadog.debugger.CapturedSnapshot33";
Map<String, byte[]> buffers = compile(CLASS_NAME, SourceCompiler.DebugInfo.ALL, "17");
Class<?> testClass = loadClass(CLASS_NAME, buffers);
when(inst.getAllLoadedClasses()).thenReturn(new Class[] {testClass});
ConfigurationUpdater configurationUpdater = createConfigUpdater(debuggerSinkWithMockStatusSink);
configurationUpdater.accept(
REMOTE_CONFIG,
singletonList(LogProbe.builder().probeId(PROBE_ID).where(CLASS_NAME, "parse").build()));
verify(inst).getAllLoadedClasses();
verify(inst, times(0)).retransformClasses(any());
}
private DebuggerTransformer createTransformer(
Config tracerConfig,
Configuration configuration,
DebuggerTransformer.InstrumentationListener listener,
ProbeMetadata probeMetadata,
DebuggerSink debuggerSink) {
return transformer;
}
private ConfigurationUpdater createConfigUpdater(DebuggerSink sink) {
return new ConfigurationUpdater(
inst, this::createTransformer, tracerConfig, sink, new ClassesToRetransformFinder());
}
}