Code revised with reactor

Applied rules:
 * ForeachItemsAssignToEmptyArrayToAssignRector
 * SimplifyMirrorAssignRector

Author: DanProgs

lib/api/xmlrpc/v1/xmlrpc.class.php

@@ -9100,17 +9100,15 @@ public function updateBuildCustomFieldsValues($args)
                     $cfieldMgr->design_values_to_db($hash,
                         $args[self::$buildIDParamName], null, null, 'build');
                     // Add the result for each custom field to the returned array
-                    array_push($ret,
-                        array(
-                            'status' => 'ok',
-                            'msg' => 'Custom Field:' . $cfName . ' processed '
-                        ));
+                    $ret[] = array(
+                        'status' => 'ok',
+                        'msg' => 'Custom Field:' . $cfName . ' processed '
+                    );
                 } else {
-                    array_push($ret,
-                        array(
-                            'status' => 'ko',
-                            'msg' => 'Custom Field:' . $cfName . ' skipped '
-                        ));
+                    $ret[] = array(
+                        'status' => 'ko',
+                        'msg' => 'Custom Field:' . $cfName . ' skipped '
+                    );
                 }
             }
             // Return the result after all of the fields have been processed

lib/execute/execSetResults.php

@@ -1903,7 +1903,7 @@ function getBackupSteps(&$tcaseMgr, $guiObj, $testPlanId, $platformId, $buildId)
     $stepsIds = array();
     foreach ($guiObj->map_last_exec as $tcId => $elements) {
         foreach ($guiObj->map_last_exec[$tcId]['steps'] as $step) {
-            array_push($stepsIds, $step["id"]);
+            $stepsIds[] = $step["id"];
         }
     }
 

lib/functions/code_testing/dBug.php

@@ -220,7 +220,7 @@ public function varIsBoolean($var)
     public function varIsArray($var)
     {
         $var_ser = serialize($var);
-        array_push($this->arrHistory, $var_ser);
+        $this->arrHistory[] = $var_ser;
 
         $this->makeTableHeader("array", "array");
         if (is_array($var)) {
@@ -252,7 +252,7 @@ public function varIsArray($var)
     public function varIsObject($var)
     {
         $var_ser = serialize($var);
-        array_push($this->arrHistory, $var_ser);
+        $this->arrHistory[] = $var_ser;
         $this->makeTableHeader("object", "object");
 
         if (is_object($var)) {

lib/functions/database.class.php

@@ -234,13 +234,12 @@ public function exec_query($p_query, $p_limit = - 1, $p_offset = - 1)
         }
 
         if ($this->logQueries) {
-            array_push($this->queries_array,
-                array(
-                    $p_query,
-                    $t_elapsed,
-                    $ec,
-                    $emsg
-                ));
+            $this->queries_array[] = array(
+                $p_query,
+                $t_elapsed,
+                $ec,
+                $emsg
+            );
         }
 
         return $t_result;
@@ -473,7 +472,7 @@ private function count_unique_queries()
         foreach ($this->queries_array as $t_val_array) {
             if (! in_array($t_val_array[0], $t_shown_queries)) {
                 $t_unique_queries ++;
-                array_push($t_shown_queries, $t_val_array[0]);
+                $t_shown_queries[] = $t_val_array[0];
             }
         }
         return $t_unique_queries;

lib/functions/plugin_api.php

@@ -173,7 +173,6 @@ function plugin_config_set($option, $value, $project = TL_ANY_PROJECT)
         $value = serialize($value);
     } elseif (is_float($value)) {
         $config_type = CONFIG_TYPE_FLOAT;
-        $value = $value;
     } elseif (is_int($value) || is_numeric($value)) {
         $config_type = CONFIG_TYPE_INT;
         $value = $dbHandler->prepare_int($value);

lib/functions/requirement_spec_mgr.class.php

@@ -765,7 +765,7 @@ public function get_requirement_child_by_id($id)
     {
         $children = $this->get_requirement_child_by_id_req($id);
         foreach ($children as $child) {
-            array_push($this->requirement_child_ids, $child);
+            $this->requirement_child_ids[] = $child;
             $this->get_requirement_child_by_id($child["destination_id"]);
         }
         return $this->requirement_child_ids;

lib/issuetrackerintegration/githubrestInterface.class.php

@@ -77,7 +77,6 @@ private function completeCfg()
         if (property_exists($this->cfg, 'attributes')) {
             $attr = get_object_vars($this->cfg->attributes);
             foreach ($attr as $name => $elem) {
-                $name = $name;
                 if (is_object($elem)) {
                     $elem = get_object_vars($elem);
                     $cc = current($elem);

lib/issuetrackerintegration/gitlabrestInterface.class.php

@@ -77,7 +77,6 @@ private function completeCfg()
         if (property_exists($this->cfg, 'attributes')) {
             $attr = get_object_vars($this->cfg->attributes);
             foreach ($attr as $name => $elem) {
-                $name = $name;
                 if (is_object($elem)) {
                     $elem = get_object_vars($elem);
                     $cc = current($elem);

lib/issuetrackerintegration/jirarestInterface.class.php

@@ -642,7 +642,6 @@ private function processAttributes()
     {
         $attr = get_object_vars($this->cfg->attributes);
         foreach ($attr as $name => $elem) {
-            $name = $name;
             switch ($name) {
                 case 'customFieldValues':
                     $this->getCustomFieldsAttribute($name, $elem);

lib/issuetrackerintegration/jirasoapInterface.class.php

@@ -433,7 +433,6 @@ private function processAttributes()
     {
         $attr = get_object_vars($this->cfg->attributes);
         foreach ($attr as $name => $elem) {
-            $name = $name;
             switch ($name) {
                 case 'customFieldValues':
                     $this->getCustomFieldsAttribute($name, $elem);