feat (Configuration): use a cached_property for preferred usernames and subs lookups

fix: reorder imports

fix: set exclude=True on computed field

fix (Configuration): Don't use a computed field.

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Author: ryuwd

diracx-core/src/diracx/core/config/schema.py

@@ -2,6 +2,7 @@
 
 import os
 from datetime import date, datetime
+from functools import cached_property
 from typing import Annotated, Any, MutableMapping, TypeVar
 
 from pydantic import BaseModel as _BaseModel
@@ -158,6 +159,11 @@ class RegistryConfig(BaseModel):
     Groups: MutableMapping[str, GroupConfig]
     """DIRAC groups section, subsections represent the name of the group."""
 
+    @cached_property
+    def _preferred_username_to_sub(self) -> dict[str, str]:
+        """Compute reverse lookup map from preferred username to user sub."""
+        return {user.PreferedUsername: sub for sub, user in self.Users.items()}
+
     def sub_from_preferred_username(self, preferred_username: str) -> str:
         """Get the user sub from the preferred username.
 
@@ -171,10 +177,10 @@ def sub_from_preferred_username(self, preferred_username: str) -> str:
             KeyError: If no user with the given preferred username is found.
 
         """
-        for sub, user in self.Users.items():
-            if user.PreferedUsername == preferred_username:
-                return sub
-        raise KeyError(f"User {preferred_username} not found in registry")
+        try:
+            return self._preferred_username_to_sub[preferred_username]
+        except KeyError:
+            raise KeyError(f"User {preferred_username} not found in registry") from None
 
 
 class DIRACConfig(BaseModel):