From 9b9482037becd8ba73b8c5989e083acaefd356eb Mon Sep 17 00:00:00 2001
From: TaprootFreak <142087526+TaprootFreak@users.noreply.github.com>
Date: Tue, 24 Mar 2026 09:11:38 +0100
Subject: [PATCH] Fix Scrypt pending balance: only match confirmed deposits
 (#3506)

Pending Scrypt deposits (status != 'ok') were incorrectly used as
receiver matches in getUnmatchedSenders, causing sent bank_tx to
disappear from the toScrypt pending tracking. This led to funds
being neither in pending nor in liquidityBalance, creating gaps
in the total financial balance.

Only match against deposits with status 'ok' so that unconfirmed
transfers remain correctly tracked as pending toScrypt.
---
 src/subdomains/supporting/log/log-job.service.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/subdomains/supporting/log/log-job.service.ts b/src/subdomains/supporting/log/log-job.service.ts
index fb673c829d..5905acc3fd 100644
--- a/src/subdomains/supporting/log/log-job.service.ts
+++ b/src/subdomains/supporting/log/log-job.service.ts
@@ -386,7 +386,7 @@ export class LogJobService {
       (b) => b.accountIban === yapealChfBank.iban && b.creditDebitIndicator === BankTxIndicator.DEBIT,
     );
     const chfReceiverScryptExchangeTx = recentScryptExchangeTx.filter(
-      (k) => k.type === ExchangeTxType.DEPOSIT && k.status !== 'failed' && k.currency === 'CHF',
+      (k) => k.type === ExchangeTxType.DEPOSIT && k.status === 'ok' && k.currency === 'CHF',
     );
 
     // sender and receiver data
@@ -416,7 +416,7 @@ export class LogJobService {
         b.instructedCurrency,
     );
     const eurReceiverScryptExchangeTx = recentScryptExchangeTx.filter(
-      (k) => k.type === ExchangeTxType.DEPOSIT && k.status !== 'failed' && k.currency === 'EUR',
+      (k) => k.type === ExchangeTxType.DEPOSIT && k.status === 'ok' && k.currency === 'EUR',
     );
 
     // CHF: Scrypt -> Yapeal