fix: add NOT_FOUND status for withdrawal idempotency check

Add explicit NOT_FOUND status to WithdrawStatus enum to distinguish
between "never submitted" and "in progress" withdrawals. This prevents
double cBTC burning if the process restarts after withdrawSend() but
before correlationId is persisted.

Author: bernd2022

src/integration/blockchain/clementine/clementine-client.ts

@@ -29,6 +29,7 @@ export enum DepositStatus {
 }
 
 export enum WithdrawStatus {
+  NOT_FOUND = 'not_found',
   PENDING = 'pending',
   SCANNING = 'scanning',
   SIGNING = 'signing',
@@ -314,9 +315,20 @@ export class ClementineClient {
    * Get the status of a withdrawal operation
    * Command: clementine-cli withdraw status <WITHDRAWAL_UTXO>
    * @param withdrawalUtxo The withdrawal UTXO to check (format: txid:vout)
+   * @returns Status result with NOT_FOUND if no withdrawal exists for this UTXO
    */
   async withdrawStatus(withdrawalUtxo: string): Promise<WithdrawStatusResult> {
     const output = await this.executeCommand(['withdraw', 'status', withdrawalUtxo]);
+
+    // Check if no withdrawal exists for this UTXO
+    // CLI outputs "No withdrawals found for OutPoint ..." if never submitted
+    if (output.toLowerCase().includes('no withdrawals found')) {
+      return {
+        withdrawalUtxo,
+        status: WithdrawStatus.NOT_FOUND,
+      };
+    }
+
     return this.parseWithdrawStatus(output, withdrawalUtxo);
   }
 

src/subdomains/core/liquidity-management/adapters/actions/clementine-bridge.adapter.ts

@@ -13,6 +13,7 @@ import {
   CLEMENTINE_WITHDRAWAL_DUST_BTC,
   ClementineClient,
   ClementineNetwork,
+  WithdrawStatus,
 } from 'src/integration/blockchain/clementine/clementine-client';
 import { ClementineService } from 'src/integration/blockchain/clementine/clementine.service';
 import { Blockchain } from 'src/integration/blockchain/shared/enums/blockchain.enum';
@@ -406,7 +407,10 @@ export class ClementineBridgeAdapter extends LiquidityActionAdapter {
     // This prevents double cBTC burning if the process crashes after withdrawSend()
     // but before the correlationId is persisted
     const existingStatus = await this.clementineClient.withdrawStatus(data.withdrawalUtxo);
-    if (existingStatus.status !== 'pending' && existingStatus.status !== 'failed') {
+
+    // Only proceed with withdrawSend() if NO withdrawal exists for this UTXO
+    // If status is anything other than NOT_FOUND, the withdrawal was already submitted
+    if (existingStatus.status !== WithdrawStatus.NOT_FOUND) {
       this.logger.info(
         `Withdrawal: already submitted to bridge (status: ${existingStatus.status}), skipping withdrawSend()`,
       );