fix: replace fuzzy matching with reference-based 1:1 matching for Scrypt pending balance

Replace amount+timing greedy matching in getUnmatchedSenders with exact
reference matching (bankTx.remittanceInfo === exchangeTx.txId). This
eliminates wrong pairings that inflated the pending balance.

Additional fixes:
- Remove txId filter on EUR receivers (excluded legitimate deposits)
- Change status === 'ok' to status !== 'failed' on all Scrypt exchange_tx
  filters (pending deposits/withdrawals now count as matched)
- Reduce sender window from 21 to 7 days (max transfer duration)

Author: TaprootFreak

src/subdomains/supporting/log/__tests__/log-job.service.spec.ts

@@ -465,4 +465,93 @@ describe('LogJobService', () => {
       receiver: receiverTx.slice(7),
     });
   });
+
+  // --- getUnmatchedSenders (reference-based matching) ---
+
+  it('should match sender and receiver by reference', () => {
+    const senderTx = [
+      createCustomBankTx({ id: 1, created: Util.hoursBefore(24), remittanceInfo: 'DEPOSIT-100' }),
+    ];
+    const receiverTx = [
+      createCustomExchangeTx({ id: 1, created: Util.hoursBefore(20), txId: 'DEPOSIT-100' }),
+    ];
+
+    expect(service.getUnmatchedSenders(senderTx, receiverTx)).toEqual([]);
+  });
+
+  it('should return sender when references do not match', () => {
+    const senderTx = [
+      createCustomBankTx({ id: 1, created: Util.hoursBefore(24), remittanceInfo: 'DEPOSIT-100' }),
+    ];
+    const receiverTx = [
+      createCustomExchangeTx({ id: 1, created: Util.hoursBefore(20), txId: 'DEPOSIT-200' }),
+    ];
+
+    expect(service.getUnmatchedSenders(senderTx, receiverTx)).toEqual(senderTx);
+  });
+
+  it('should return sender when sender has no reference', () => {
+    const senderTx = [
+      createCustomBankTx({ id: 1, created: Util.hoursBefore(24), remittanceInfo: undefined }),
+    ];
+    const receiverTx = [
+      createCustomExchangeTx({ id: 1, created: Util.hoursBefore(20), txId: 'DEPOSIT-100' }),
+    ];
+
+    expect(service.getUnmatchedSenders(senderTx, receiverTx)).toEqual(senderTx);
+  });
+
+  it('should return sender when receiver has no reference', () => {
+    const senderTx = [
+      createCustomBankTx({ id: 1, created: Util.hoursBefore(24), remittanceInfo: 'DEPOSIT-100' }),
+    ];
+    const receiverTx = [
+      createCustomExchangeTx({ id: 1, created: Util.hoursBefore(20), txId: undefined }),
+    ];
+
+    expect(service.getUnmatchedSenders(senderTx, receiverTx)).toEqual(senderTx);
+  });
+
+  it('should filter out senders older than 7 days', () => {
+    const senderTx = [
+      createCustomBankTx({ id: 1, created: Util.hoursBefore(200), remittanceInfo: 'DEPOSIT-100' }),
+    ];
+    const receiverTx = [
+      createCustomExchangeTx({ id: 1, created: Util.hoursBefore(20), txId: 'DEPOSIT-200' }),
+    ];
+
+    expect(service.getUnmatchedSenders(senderTx, receiverTx)).toEqual([]);
+  });
+
+  it('should return all senders when receiver list is empty', () => {
+    const senderTx = [
+      createCustomBankTx({ id: 1, created: Util.hoursBefore(24), remittanceInfo: 'DEPOSIT-100' }),
+      createCustomBankTx({ id: 2, created: Util.hoursBefore(24), remittanceInfo: 'DEPOSIT-200' }),
+    ];
+
+    expect(service.getUnmatchedSenders(senderTx, [])).toEqual(senderTx);
+  });
+
+  it('should match multiple senders partially', () => {
+    const senderTx = [
+      createCustomBankTx({ id: 1, created: Util.hoursBefore(48), remittanceInfo: 'DEPOSIT-100' }),
+      createCustomBankTx({ id: 2, created: Util.hoursBefore(24), remittanceInfo: 'DEPOSIT-200' }),
+    ];
+    const receiverTx = [
+      createCustomExchangeTx({ id: 1, created: Util.hoursBefore(20), txId: 'DEPOSIT-100' }),
+    ];
+
+    expect(service.getUnmatchedSenders(senderTx, receiverTx)).toEqual([senderTx[1]]);
+  });
+
+  it('should match ExchangeTx senders by txId against BankTx receivers by remittanceInfo', () => {
+    const senderTx = [
+      createCustomExchangeTx({ id: 1, created: Util.hoursBefore(24), txId: 'WITHDRAWAL-50' }),
+    ];
+    const receiverTx = [
+      createCustomBankTx({ id: 1, created: Util.hoursBefore(20), remittanceInfo: 'WITHDRAWAL-50' }),
+    ];
+
+    expect(service.getUnmatchedSenders(senderTx, receiverTx)).toEqual([]);
+  });
 });

src/subdomains/supporting/log/log-job.service.ts

@@ -371,7 +371,7 @@ export class LogJobService {
       (b) => b.accountIban === yapealChfBank.iban && b.creditDebitIndicator === BankTxIndicator.DEBIT,
     );
     const chfReceiverScryptExchangeTx = recentScryptExchangeTx.filter(
-      (k) => k.type === ExchangeTxType.DEPOSIT && k.status === 'ok' && k.currency === 'CHF',
+      (k) => k.type === ExchangeTxType.DEPOSIT && k.status !== 'failed' && k.currency === 'CHF',
     );
 
     // sender and receiver data
@@ -401,20 +401,20 @@ export class LogJobService {
         b.instructedCurrency,
     );
     const eurReceiverScryptExchangeTx = recentScryptExchangeTx.filter(
-      (k) => k.type === ExchangeTxType.DEPOSIT && k.status === 'ok' && k.currency === 'EUR' && k.txId,
+      (k) => k.type === ExchangeTxType.DEPOSIT && k.status !== 'failed' && k.currency === 'EUR',
     );
 
     // CHF: Scrypt -> Yapeal
     const chfSenderScryptExchangeTx = recentScryptExchangeTx.filter(
-      (k) => k.type === ExchangeTxType.WITHDRAWAL && k.status === 'ok' && k.currency === 'CHF',
+      (k) => k.type === ExchangeTxType.WITHDRAWAL && k.status !== 'failed' && k.currency === 'CHF',
     );
     const chfReceiverScryptBankTx = recentScryptBankTx.filter(
       (b) => b.accountIban === yapealChfBank.iban && b.creditDebitIndicator === BankTxIndicator.CREDIT,
     );
 
     // EUR: Scrypt -> Bank
     const eurSenderScryptExchangeTx = recentScryptExchangeTx.filter(
-      (k) => k.type === ExchangeTxType.WITHDRAWAL && k.status === 'ok' && k.currency === 'EUR',
+      (k) => k.type === ExchangeTxType.WITHDRAWAL && k.status !== 'failed' && k.currency === 'EUR',
     );
     const eurReceiverScryptBankTx = recentScryptBankTx.filter(
       (b) => eurBankIbans.includes(b.accountIban) && b.creditDebitIndicator === BankTxIndicator.CREDIT,
@@ -1061,34 +1061,26 @@ export class LogJobService {
     senderTx: (BankTx | ExchangeTx)[],
     receiverTx: (BankTx | ExchangeTx)[],
   ): (BankTx | ExchangeTx)[] {
-    const before21Days = Util.daysBefore(21);
-    const recentSenders = senderTx.filter((s) => s.created > before21Days);
+    const before7Days = Util.daysBefore(7);
+    const recentSenders = senderTx.filter((s) => s.created > before7Days);
 
     if (!recentSenders.length || !receiverTx.length) return [...recentSenders];
 
-    const sortedSenders = [...recentSenders].sort((a, b) => a.id - b.id);
-    const sortedReceivers = [...receiverTx].sort((a, b) => a.id - b.id);
-    const matchedSenderIds = new Set<number>();
-
-    for (const receiver of sortedReceivers) {
-      const receiverAmount = receiver instanceof BankTx ? receiver.instructedAmount : receiver.amount;
-
-      const match = sortedSenders.find((s) => {
-        if (matchedSenderIds.has(s.id)) return false;
-
-        const senderAmount = s instanceof BankTx ? s.instructedAmount : s.amount;
-        const senderDate = s instanceof BankTx ? s.valueDate : s.created;
-        const daysDiff = Math.abs(Util.daysDiff(senderDate, receiver.created));
-
-        return s instanceof BankTx
-          ? senderAmount === receiverAmount && daysDiff <= 5 && receiver.created > s.created
-          : senderAmount === receiverAmount && receiver.created > s.created;
-      });
-
-      if (match) matchedSenderIds.add(match.id);
+    const receiverRefs = new Set<string>();
+    for (const r of receiverTx) {
+      const ref = this.getTxReference(r);
+      if (ref) receiverRefs.add(ref);
     }
 
-    return sortedSenders.filter((s) => !matchedSenderIds.has(s.id));
+    return recentSenders.filter((s) => {
+      const ref = this.getTxReference(s);
+      return !ref || !receiverRefs.has(ref);
+    });
+  }
+
+  private getTxReference(tx: BankTx | ExchangeTx): string | undefined {
+    if (tx instanceof BankTx) return tx.remittanceInfo?.trim() || undefined;
+    return tx.txId?.trim() || undefined;
   }
 
   public filterSenderPendingList(