From c818172d2d9fa114bfacc0211c800fef8b7f7456 Mon Sep 17 00:00:00 2001 From: Halavus Nenuli Date: Mon, 16 Mar 2026 08:22:00 +0100 Subject: [PATCH 1/2] added qerror() in set_selected_action --- changelog.txt | 1 + gui/siegemanager.lua | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/changelog.txt b/changelog.txt index 9ca3d5e44..127e125f5 100644 --- a/changelog.txt +++ b/changelog.txt @@ -31,6 +31,7 @@ Template for new versions: ## New Features ## Fixes +- `gui/siegemanager`: Added error message in the console if no siege engine is selected ## Misc Improvements diff --git a/gui/siegemanager.lua b/gui/siegemanager.lua index b45e5180e..492490a40 100644 --- a/gui/siegemanager.lua +++ b/gui/siegemanager.lua @@ -416,6 +416,10 @@ end function SiegeEngineList:set_selected_action(action) local _, selected = self.subviews.list:getSelected() + if not selected then + qerror('No siege engine selected') + end + local successful = set_siege_engine_action({selected.data}, action) if not successful then self:refresh_view(true) From 6f2e9f692f17255fe3f2872b4eaa6e3bee1e1245 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 16 Mar 2026 07:28:44 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- gui/siegemanager.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gui/siegemanager.lua b/gui/siegemanager.lua index 492490a40..675d3b016 100644 --- a/gui/siegemanager.lua +++ b/gui/siegemanager.lua @@ -419,7 +419,7 @@ function SiegeEngineList:set_selected_action(action) if not selected then qerror('No siege engine selected') end - + local successful = set_siege_engine_action({selected.data}, action) if not successful then self:refresh_view(true)