Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added significant change to api #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Added significant change to api #43
Changes from all commits
fcce9f4da761f78850f46535845a222be61dd442c93810dcaFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 5 in src/Dfe.CaseAggregationService.Domain/Entities/SigChange/SigChangeSummary.cs
Check warning on line 5 in src/Dfe.CaseAggregationService.Domain/Entities/SigChange/SigChangeSummary.cs
Non-nullable property 'SigChangeId' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
Check warning on line 18 in src/Dfe.CaseAggregationService.Infrastructure/Gateways/SignificantChangeApiClient.cs
'System.Exception' should not be thrown by user code.
Check warning on line 36 in src/Dfe.CaseAggregationService.Infrastructure/Gateways/SignificantChangeApiClient.cs
Member 'ParseNullableDate' does not access instance data and can be marked as static
Check warning on line 36 in src/Dfe.CaseAggregationService.Infrastructure/Gateways/SignificantChangeApiClient.cs
Make 'ParseNullableDate' a static method.
Check warning on line 48 in src/Dfe.CaseAggregationService.Infrastructure/Gateways/SignificantChangeApiClient.cs
Make 'ParseDate' a static method.
Check warning on line 48 in src/Dfe.CaseAggregationService.Infrastructure/Gateways/SignificantChangeApiClient.cs
Member 'ParseDate' does not access instance data and can be marked as static
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.