Harden up commands.c and add some X macro setup for defense fields.

Author: DCurrent

engine/source/defense_fields.def

@@ -0,0 +1,16 @@
+DEF_FIELD_INT(block_damage_adjust)
+DEF_FIELD_INT(block_damage_max)
+DEF_FIELD_INT(block_damage_min)
+DEF_FIELD_INT(blockpower)
+DEF_FIELD_FLOAT(blockratio)
+DEF_FIELD_INT(blockthreshold)
+DEF_FIELD_INT(blocktype)
+DEF_FIELD_INT(damage_adjust)
+DEF_FIELD_INT(damage_max)
+DEF_FIELD_INT(damage_min)
+DEF_FIELD_INT(death_config_flags)
+DEF_FIELD_FLOAT(factor)
+DEF_FIELD_FLOAT(knockdown)
+DEF_FIELD_PTR(meta_data)
+DEF_FIELD_INT(meta_tag)
+DEF_FIELD_INT(pain)

engine/source/openborscript/commands.c

@@ -8,39 +8,56 @@ void freeCommandList(List *list)
     free(list);
 }
 
-// attention: modifies usercommand to lowercase
-void *getCommandlistCommand(List *list, char* usercommand)
+/**
+ * getCommandlistCommand
+ * ---------------------
+ * Refactor - Caskey, Damon V.
+ * 2025-05-17
+ * 
+ * Looks up a command in the given list by its name, case-insensitively.
+ *
+ * Notes:
+ *   - The search is case-insensitive.
+ *   - Memory is dynamically allocated for the lowercase copy and freed before return.
+ */
+void* getCommandlistCommand(List* list, const char* usercommand)
 {
-    if (!usercommand || !usercommand[0])
-    {
-        goto fail;
+    if (!list || !usercommand || !usercommand[0]) {
+        return NULL;
     }
-    lc(usercommand, strlen(usercommand));
-    Node *n = List_GetNodeByName(list, usercommand);
-    if(n)
-    {
-        return n->value;
+
+    size_t len = strlen(usercommand);
+    char* buf = (char*)malloc(len + 1);
+    
+    if (!buf){
+        return NULL;
     }
-fail:
-    return NULL;
+
+    memcpy(buf, usercommand, len + 1); // Copy including null terminator
+    lc(buf, len);
+
+    Node* n = List_GetNodeByName(list, buf);
+    free(buf);
+
+    return n ? n->value : NULL;
 }
 
-modelCommands getModelCommand(List *list, char* usercommand)
+modelCommands getModelCommand(List *list, const char* usercommand)
 {
     return (modelCommands) getCommandlistCommand(list, usercommand);
 }
 
-modelstxtCommands getModelstxtCommand(List *list, char *usercommand)
+modelstxtCommands getModelstxtCommand(List *list, const char *usercommand)
 {
     return (modelstxtCommands) getCommandlistCommand(list, usercommand);
 }
 
-levelCommands getLevelCommand(List *list, char *usercommand)
+levelCommands getLevelCommand(List *list, const char *usercommand)
 {
     return (levelCommands) getCommandlistCommand(list, usercommand);
 }
 
-levelOrderCommands getLevelOrderCommand(List *list, char *usercommand)
+levelOrderCommands getLevelOrderCommand(List *list, const char *usercommand)
 {
     return (levelOrderCommands) getCommandlistCommand(list, usercommand);
 }

engine/source/openborscript/commands.h

@@ -794,16 +794,16 @@ typedef enum
 void freeCommandList(List *list);
 
 List *createModelCommandList(void);
-modelCommands getModelCommand(List *list, char *usercommand);
+modelCommands getModelCommand(List *list, const char *usercommand);
 
 List *createModelstxtCommandList(void);
-modelstxtCommands getModelstxtCommand(List *list, char *usercommand);
+modelstxtCommands getModelstxtCommand(List *list, const char *usercommand);
 
 List *createLevelCommandList(void);
-levelCommands getLevelCommand(List *list, char *usercommand);
+levelCommands getLevelCommand(List *list, const char *usercommand);
 
 List *createLevelOrderCommandList(void);
-levelOrderCommands getLevelOrderCommand(List *list, char *usercommand);
+levelOrderCommands getLevelOrderCommand(List *list, const char *usercommand);
 
 #endif