Add scroll to top/bottom in note view for long notes

Crustack · Crustack · commit cfc9eb26ac22 · 2026-02-23T18:18:47.000+01:00
diff --git a/app/src/main/java/com/philkes/notallyx/presentation/activity/note/EditActivity.kt b/app/src/main/java/com/philkes/notallyx/presentation/activity/note/EditActivity.kt
@@ -98,6 +98,7 @@ import com.philkes.notallyx.utils.findWebUrls
 import com.philkes.notallyx.utils.getFileName
 import com.philkes.notallyx.utils.getMimeType
 import com.philkes.notallyx.utils.getUriForFile
+import com.philkes.notallyx.utils.isInLandscapeMode
 import com.philkes.notallyx.utils.log
 import com.philkes.notallyx.utils.mergeSkipFirst
 import com.philkes.notallyx.utils.observeSkipFirst
@@ -132,6 +133,8 @@ abstract class EditActivity(private val type: Type) :
     internal lateinit var changeHistory: ChangeHistory
     protected var undo: View? = null
     protected var redo: View? = null
+    protected var jumpToTop: View? = null
+    protected var jumpToBottom: View? = null
 
     protected var colorInt: Int = -1
     protected var inputMethodManager: InputMethodManager? = null
@@ -546,6 +549,23 @@ abstract class EditActivity(private val type: Type) :
 
     protected fun isInSearchMode(): Boolean = binding.EnterSearchKeyword.visibility == VISIBLE
 
+    protected fun updateJumpButtonsVisibility(manualSize: Int? = null) {
+        jumpToTop?.post {
+            Log.d("JUMP", "Lines: ${binding.EnterBody.lineCount}")
+            val show =
+                when (notallyModel.type) {
+                    Type.NOTE ->
+                        (manualSize ?: binding.EnterBody.lineCount) >
+                            (if (isInLandscapeMode) 30 else 75)
+                    Type.LIST ->
+                        (manualSize ?: notallyModel.items.size) >
+                            (if (isInLandscapeMode) 15 else 25)
+                }
+            jumpToTop?.isVisible = show
+            jumpToBottom?.isVisible = show
+        }
+    }
+
     protected fun endSearch() {
         binding.EnterSearchKeyword.apply {
             visibility = GONE
@@ -570,6 +590,14 @@ abstract class EditActivity(private val type: Type) :
         }
         binding.BottomAppBarCenter.apply {
             removeAllViews()
+            jumpToTop =
+                addIconButton(
+                    R.string.jump_to_top,
+                    R.drawable.vertical_align_top,
+                    marginStart = 0,
+                ) {
+                    binding.ScrollView.apply { post { fullScroll(View.FOCUS_UP) } }
+                }
             undo =
                 addIconButton(
                         R.string.undo,
@@ -613,6 +641,26 @@ abstract class EditActivity(private val type: Type) :
                         }
                     }
                     .apply { isEnabled = changeHistory.canRedo.value }
+            jumpToBottom =
+                addIconButton(
+                    R.string.jump_to_bottom,
+                    R.drawable.vertical_align_bottom,
+                    marginStart = 2,
+                ) {
+                    binding.ScrollView.apply {
+                        post {
+                            val lastChild: View? = binding.ScrollView.getChildAt(0)
+                            if (lastChild != null) {
+                                val bottom: Int =
+                                    lastChild.bottom + binding.ScrollView.paddingBottom
+                                binding.ScrollView.smoothScrollTo(0, bottom)
+                            } else {
+                                fullScroll(View.FOCUS_DOWN)
+                            }
+                        }
+                    }
+                }
+            updateJumpButtonsVisibility()
         }
         binding.BottomAppBarRight.apply {
             removeAllViews()
diff --git a/app/src/main/java/com/philkes/notallyx/presentation/activity/note/EditListActivity.kt b/app/src/main/java/com/philkes/notallyx/presentation/activity/note/EditListActivity.kt
@@ -241,11 +241,13 @@ class EditListActivity : EditActivity(Type.LIST), MoreListActions {
                         endSearch()
                     }
                 },
-            ) { _ ->
-                if (isInSearchMode() && search.results.value > 0) {
-                    updateSearchResults(search.query)
-                }
-            }
+                { _ ->
+                    if (isInSearchMode() && search.results.value > 0) {
+                        updateSearchResults(search.query)
+                    }
+                },
+                { items -> updateJumpButtonsVisibility(items) },
+            )
         adapter =
             ListItemAdapter(
                 colorInt,
diff --git a/app/src/main/java/com/philkes/notallyx/presentation/activity/note/EditNoteActivity.kt b/app/src/main/java/com/philkes/notallyx/presentation/activity/note/EditNoteActivity.kt
@@ -162,6 +162,7 @@ class EditNoteActivity : EditActivity(Type.NOTE), AddNoteActions {
             notallyModel.body = text
             if (textChanged) {
                 updateSearchResults(search.query)
+                updateJumpButtonsVisibility()
             }
         }
     }
diff --git a/app/src/main/java/com/philkes/notallyx/presentation/view/note/listitem/ListManager.kt b/app/src/main/java/com/philkes/notallyx/presentation/view/note/listitem/ListManager.kt
@@ -3,7 +3,6 @@ package com.philkes.notallyx.presentation.view.note.listitem
 import android.util.Log
 import android.view.View
 import android.view.inputmethod.InputMethodManager
-import android.widget.EditText
 import androidx.recyclerview.widget.RecyclerView
 import com.philkes.notallyx.data.model.ListItem
 import com.philkes.notallyx.data.model.check
@@ -48,6 +47,7 @@ class ListManager(
     private val inputMethodManager: InputMethodManager?,
     private val endSearch: (() -> Unit)?,
     val refreshSearch: ((refocusView: View?) -> Unit)?,
+    val onItemSizeChanged: ((items: Int) -> Unit)?,
 ) {
     lateinit var adapter: ListItemAdapter
     var checkedAdapter: CheckedListItemAdapter? = null
@@ -151,6 +151,7 @@ class ListManager(
                 inputMethodManager?.let { viewHolder.focusEditText(inputMethodManager = it) }
             }
         }
+        onItemSizeChanged?.invoke(items.size)
     }
 
     /**
@@ -201,6 +202,7 @@ class ListManager(
         if (pushChange && result) {
             changeHistory.push(ListDeleteChange(stateBefore, getState(), this))
         }
+        onItemSizeChanged?.invoke(items.size)
         return result
     }
 
@@ -372,6 +374,7 @@ class ListManager(
         if (pushChange) {
             changeHistory.push(DeleteCheckedChange(stateBefore, getState(), this))
         }
+        onItemSizeChanged?.invoke(items.size)
     }
 
     fun findParent(item: ListItem) = items.findParent(item) ?: itemsChecked?.findParent(item)
diff --git a/app/src/main/java/com/philkes/notallyx/utils/AndroidExtensions.kt b/app/src/main/java/com/philkes/notallyx/utils/AndroidExtensions.kt
@@ -246,6 +246,9 @@ fun Activity.showErrorDialog(
         .show()
 }
 
+val Activity.isInLandscapeMode
+    get() = resources.configuration.orientation == Configuration.ORIENTATION_LANDSCAPE
+
 private const val MAX_LOGS_FILE_SIZE_KB: Long = 2048
 
 private fun Context.logToFile(
diff --git a/app/src/main/res/drawable/vertical_align_bottom.xml b/app/src/main/res/drawable/vertical_align_bottom.xml
@@ -0,0 +1,10 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+    android:width="24dp"
+    android:height="24dp"
+    android:viewportWidth="960"
+    android:viewportHeight="960"
+    android:tint="?attr/colorControlNormal">
+  <path
+      android:fillColor="@android:color/white"
+      android:pathData="M160,840L160,760L800,760L800,840L160,840ZM480,680L280,480L336,424L440,528L440,120L520,120L520,528L624,424L680,480L480,680Z"/>
+</vector>
diff --git a/app/src/main/res/drawable/vertical_align_top.xml b/app/src/main/res/drawable/vertical_align_top.xml
@@ -0,0 +1,10 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+    android:width="24dp"
+    android:height="24dp"
+    android:viewportWidth="960"
+    android:viewportHeight="960"
+    android:tint="?attr/colorControlNormal">
+  <path
+      android:fillColor="@android:color/white"
+      android:pathData="M160,200L160,120L800,120L800,200L160,200ZM440,840L440,432L336,536L280,480L480,280L680,480L624,536L520,432L520,840L440,840Z"/>
+</vector>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -216,6 +216,8 @@
     <string name="item">Item</string>
     <string name="json_files">JSON Files</string>
     <string name="json_files_help">In order to import your Notes from JSON files (single file or folder), click Import. Every valid JSON file is imported as a separate note, the file’s name becomes the note’s title.</string>
+    <string name="jump_to_bottom">Jump to bottom</string>
+    <string name="jump_to_top">Jump to top</string>
     <string name="label_exists">Label exists</string>
     <string name="label_visibility">Hide/Show the label in the navigation panel</string>
     <string name="labels">Labels</string>
diff --git a/app/src/test/kotlin/com/philkes/notallyx/recyclerview/listmanager/ListManagerTestBase.kt b/app/src/test/kotlin/com/philkes/notallyx/recyclerview/listmanager/ListManagerTestBase.kt
@@ -59,7 +59,7 @@ open class ListManagerTestBase {
         listItemVH = mock(ListItemVH::class.java)
         preferences = mock(NotallyXPreferences::class.java)
         listManager =
-            ListManager(recyclerView, changeHistory, preferences, inputMethodManager, {}) {}
+            ListManager(recyclerView, changeHistory, preferences, inputMethodManager, {}, {}, null)
         // Prepare view holder
         `when`(recyclerView.findViewHolderForAdapterPosition(anyInt())).thenReturn(listItemVH)
     }
diff --git a/app/translations.xlsx b/app/translations.xlsx

Original file line number	Diff line number	Diff line change
`@@ -162,6 +162,7 @@ class EditNoteActivity : EditActivity(Type.NOTE), AddNoteActions {`
`162`	`162`	`notallyModel.body = text`
`163`	`163`	`if (textChanged) {`
`164`	`164`	`updateSearchResults(search.query)`
	`165`	`+ updateJumpButtonsVisibility()`
`165`	`166`	`}`
`166`	`167`	`}`
`167`	`168`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@ package com.philkes.notallyx.presentation.view.note.listitem`
`3`	`3`	`import android.util.Log`
`4`	`4`	`import android.view.View`
`5`	`5`	`import android.view.inputmethod.InputMethodManager`
`6`		`-import android.widget.EditText`
`7`	`6`	`import androidx.recyclerview.widget.RecyclerView`
`8`	`7`	`import com.philkes.notallyx.data.model.ListItem`
`9`	`8`	`import com.philkes.notallyx.data.model.check`
`@@ -48,6 +47,7 @@ class ListManager(`
`48`	`47`	`private val inputMethodManager: InputMethodManager?,`
`49`	`48`	`private val endSearch: (() -> Unit)?,`
`50`	`49`	`val refreshSearch: ((refocusView: View?) -> Unit)?,`
	`50`	`+ val onItemSizeChanged: ((items: Int) -> Unit)?,`
`51`	`51`	`) {`
`52`	`52`	`lateinit var adapter: ListItemAdapter`
`53`	`53`	`var checkedAdapter: CheckedListItemAdapter? = null`
`@@ -151,6 +151,7 @@ class ListManager(`
`151`	`151`	`inputMethodManager?.let { viewHolder.focusEditText(inputMethodManager = it) }`
`152`	`152`	`}`
`153`	`153`	`}`
	`154`	`+ onItemSizeChanged?.invoke(items.size)`
`154`	`155`	`}`
`155`	`156`
`156`	`157`	`/**`
`@@ -201,6 +202,7 @@ class ListManager(`
`201`	`202`	`if (pushChange && result) {`
`202`	`203`	`changeHistory.push(ListDeleteChange(stateBefore, getState(), this))`
`203`	`204`	`}`
	`205`	`+ onItemSizeChanged?.invoke(items.size)`
`204`	`206`	`return result`
`205`	`207`	`}`
`206`	`208`
`@@ -372,6 +374,7 @@ class ListManager(`
`372`	`374`	`if (pushChange) {`
`373`	`375`	`changeHistory.push(DeleteCheckedChange(stateBefore, getState(), this))`
`374`	`376`	`}`
	`377`	`+ onItemSizeChanged?.invoke(items.size)`
`375`	`378`	`}`
`376`	`379`
`377`	`380`	`fun findParent(item: ListItem) = items.findParent(item) ?: itemsChecked?.findParent(item)`
Original file line number	Diff line number	Diff line change
`@@ -246,6 +246,9 @@ fun Activity.showErrorDialog(`
`246`	`246`	`.show()`
`247`	`247`	`}`
`248`	`248`
	`249`	`+val Activity.isInLandscapeMode`
	`250`	`+ get() = resources.configuration.orientation == Configuration.ORIENTATION_LANDSCAPE`
	`251`	`+`
`249`	`252`	`private const val MAX_LOGS_FILE_SIZE_KB: Long = 2048`
`250`	`253`
`251`	`254`	`private fun Context.logToFile(`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ open class ListManagerTestBase {`
`59`	`59`	`listItemVH = mock(ListItemVH::class.java)`
`60`	`60`	`preferences = mock(NotallyXPreferences::class.java)`
`61`	`61`	`listManager =`
`62`		`- ListManager(recyclerView, changeHistory, preferences, inputMethodManager, {}) {}`
	`62`	`+ ListManager(recyclerView, changeHistory, preferences, inputMethodManager, {}, {}, null)`
`63`	`63`	`// Prepare view holder`
`64`	`64`	`when`(recyclerView.findViewHolderForAdapterPosition(anyInt())).thenReturn(listItemVH)
`65`	`65`	`}`