Merge pull request #10 from CriticalSolutionsNetwork/Make-Domain-Suffix-Optional

### Summary
This PR introduces improvements to the GraphAppToolkit module to enhance installation reliability and make the domain suffix parameter optional during app initialization.

### Changes
- **Fixed** module installation logic to properly register after build and import.  
- **Fixed** parameter handling across module manifest and public functions for improved consistency.  
- **Fixed** minimum PowerShell version validation during module install.  
- **Changed** app name initialization to make the domain suffix optional for greater flexibility in tenant naming conventions.  
- Minor internal refactors and cleanup.

### Motivation and Context
These updates resolve installation issues and streamline app creation workflows by allowing users to omit the domain suffix when initializing new app registrations. This provides better alignment with diverse tenant naming standards.

### Testing
- Verified module installation succeeds in both PowerShell 5.1 and 7.x environments.  
- Confirmed all cmdlets load without warnings or dependency issues.  
- Tested new parameter behavior for `-DomainSuffix` to ensure backward compatibility.

### Related Issues
Fixes # (add issue number if applicable)

Author: DrIOSX

.gitignore

@@ -18,4 +18,6 @@ package-lock.json
 ZZBuild-Help.ps1
 test1.ps1
 helpdoc.ps1
-StyleGuide.md
+StyleGuide.md
+.copilot/
+samplescript.ps1

.vscode/launch.json

@@ -0,0 +1,16 @@
+{
+    // Use IntelliSense to learn about possible attributes.
+    // Hover to view descriptions of existing attributes.
+    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+    "version": "0.2.0",
+    "configurations": [
+        {
+            "name": "PowerShell: Launch Current File",
+            "type": "PowerShell",
+            "request": "launch",
+            "script": "${file}",
+            "args": [],
+            "createTemporaryIntegratedConsole": true
+        }
+    ]
+}

CHANGELOG.md

@@ -5,6 +5,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Fixed module installation logic to correctly register the module after build and import.  
+- Fixed parameter handling in module manifest and public functions for better consistency.  
+- Fixed minimum PowerShell version declaration and validation during install.  
+- Minor internal refactor related to domain-suffix optional parameter handling.  
+
+### Changed
+
+- Made the domain suffix optional during app name initialization for greater flexibility in tenant naming conventions.
+
+## [0.2.1] - 2025-03-17
+
 ### Added
 
 - Added Get-TkMsalToken cmdlet to retrieve an MSAL token using API calls.

Cmdlets_Mapping.csv

@@ -0,0 +1,29 @@
+Function Name,Visibility,Used Cmdlets
+Connect-TkMsService,Private,"Get-MgUser, Get-MgContext, Get-MgOrganization, Remove-MgContext, Connect-MgGraph, Disconnect-ExchangeOnline, Connect-ExchangeOnline"
+ConvertTo-ParameterSplat,Private,Write-AuditLog
+Get-TkExistingCert,Private,"Get-ChildItem, Where-Object, Remove-Item, Write-AuditLog"
+Get-TkExistingSecret,Private,"Get-Secret, Write-AuditLog"
+Get-TkMsalToken,Private,"Invoke-RestMethod, Write-AuditLog"
+Initialize-TkAppAuthCertificate,Private,"Get-ChildItem, New-SelfSignedCertificate, Write-AuditLog"
+Initialize-TkAppName,Private,Write-AuditLog
+Initialize-TkEmailAppParamsObject,Private,
+Initialize-TkM365AuditAppParamsObject,Private,
+Initialize-TkMemPolicyManagerAppParamsObject,Private,
+Initialize-TkModuleEnv,Private,"Install-Module, Import-Module, Get-Module, Write-AuditLog"
+Initialize-TkRequiredResourcePermissionObject,Private,"Get-MgServicePrincipal, Find-MgGraphPermission, Write-AuditLog"
+New-TkAppRegistration,Private,"Get-ChildItem, New-MgApplication, Write-AuditLog"
+New-TkAppSpOauth2Registration,Private,Write-AuditLog
+Connect-TkMsService,Private,"Get-MgUser, Get-MgContext, Get-MgOrganization, Remove-MgContext, Connect-MgGraph, Disconnect-ExchangeOnline, Connect-ExchangeOnline"
+ConvertTo-ParameterSplat,Private,Write-AuditLog
+Get-TkExistingCert,Public,"Get-ChildItem, Where-Object, Remove-Item, Write-AuditLog"
+Get-TkExistingSecret,Public,"Get-Secret, Write-AuditLog"
+Get-TkMsalToken,Public,"Invoke-RestMethod, Write-AuditLog"
+Initialize-TkAppAuthCertificate,Public,"Get-ChildItem, New-SelfSignedCertificate, Write-AuditLog"
+Initialize-TkAppName,Public,Write-AuditLog
+Initialize-TkEmailAppParamsObject,Public,
+Initialize-TkM365AuditAppParamsObject,Public,
+Initialize-TkMemPolicyManagerAppParamsObject,Public,
+Initialize-TkModuleEnv,Public,"Install-Module, Import-Module, Get-Module, Write-AuditLog"
+Initialize-TkRequiredResourcePermissionObject,Public,"Get-MgServicePrincipal, Find-MgGraphPermission, Write-AuditLog"
+New-TkAppRegistration,Public,"Get-ChildItem, New-MgApplication, Write-AuditLog"
+New-TkAppSpOauth2Registration,Public,Write-AuditLog

README.md

@@ -14,7 +14,4 @@
     ChangelogManagement         = 'latest'
     Sampler                     = 'latest'
     'Sampler.GitHubTasks'       = 'latest'
-
-
 }
-

README2.md

@@ -2,7 +2,7 @@
 <!--
 <auto-generated>
   <synopsis>
-    This code was generated by a psDoc. on: 03/17/2025 08:59:20
+    This code was generated by a psDoc. on: 10/06/2025 09:44:12
     Get it here: https://github.com/ChaseFlorell/psDoc
   </synopsis>
   <description>
@@ -271,7 +271,9 @@ <h3> Syntax </h3>
                         </div>
 						<div class="panel panel-default">
                             <div class='panel-body'>
-<pre class="brush: ps">Publish-TkEmailApp [-AppPrefix &lt;String&gt;] -AuthorizedSenderUserName &lt;String&gt; -MailEnabledSendingGroup &lt;String&gt; [-CertPrefix &lt;String&gt;] [-CertThumbprint &lt;String&gt;] [-KeyExportPolicy &lt;String&gt;] [-VaultName &lt;String&gt;] [-OverwriteVaultSecret] [-ReturnParamSplat] [-DoNotUseDomainSuffix] [-LogOutput &lt;String&gt;] [-WhatIf] [-Confirm] [&lt;CommonParameters&gt;]
+<pre class="brush: ps">Publish-TkEmailApp [-WhatIf] [-Confirm] [&lt;CommonParameters&gt;]
+
+Publish-TkEmailApp [-AppPrefix &lt;String&gt;] -AuthorizedSenderUserName &lt;String&gt; -MailEnabledSendingGroup &lt;String&gt; [-CertPrefix &lt;String&gt;] [-CertThumbprint &lt;String&gt;] [-KeyExportPolicy &lt;String&gt;] [-VaultName &lt;String&gt;] [-OverwriteVaultSecret] [-ReturnParamSplat] [-DoNotUseDomainSuffix] [-LogOutput &lt;String&gt;] [-WhatIf] [-Confirm] [&lt;CommonParameters&gt;]
 
 Publish-TkEmailApp -ExistingAppObjectId &lt;String&gt; -CertPrefix &lt;String&gt; [-CertThumbprint &lt;String&gt;] [-KeyExportPolicy &lt;String&gt;] [-VaultName &lt;String&gt;] [-OverwriteVaultSecret] [-ReturnParamSplat] [-DoNotUseDomainSuffix] [-LogOutput &lt;String&gt;] [-WhatIf] [-Confirm] [&lt;CommonParameters&gt;]</pre>
                             </div>
@@ -293,7 +295,7 @@ <h3> Parameters </h3>
 									<tr>
 										<td><nobr>-AppPrefix</nobr></td>
                                         <td class="visible-lg visible-md"></td>
-                                        <td><p>The prefix used to initialize the Graph Email App. Must be 2-4 characters, letters, and numbers only. Default is 'Gtk'.</p>
+                                        <td><p>The prefix used to initialize the Graph Email App. Must be 2-4 characters, letters, and numbers only. The default value is 'Gtk'.</p>
 </td>
 										<td class="visible-lg visible-md">false</td>
 										<td class="visible-lg">false</td>
@@ -347,7 +349,7 @@ <h3> Parameters </h3>
 									<tr>
 										<td><nobr>-KeyExportPolicy</nobr></td>
                                         <td class="visible-lg visible-md"></td>
-                                        <td><p>Key export policy for the certificate. Valid values are 'Exportable' and 'NonExportable'. Default is 'NonExportable'.</p>
+                                        <td><p>Key export policy for the certificate. Valid values are 'Exportable' and 'NonExportable'. The default value is 'NonExportable'.</p>
 </td>
 										<td class="visible-lg visible-md">false</td>
 										<td class="visible-lg">false</td>

RequiredModules.psd1

@@ -12,7 +12,12 @@ Publishes a new or existing Graph Email App with specified configurations.
 
 ## SYNTAX
 
-### CreateNewApp (Default)
+### Interactive (Default)
+```
+Publish-TkEmailApp [-ProgressAction <ActionPreference>] [-WhatIf] [-Confirm] [<CommonParameters>]
+```
+
+### CreateNewApp
 ```
 Publish-TkEmailApp [-AppPrefix <String>] -AuthorizedSenderUserName <String> -MailEnabledSendingGroup <String>
  [-CertPrefix <String>] [-CertThumbprint <String>] [-KeyExportPolicy <String>] [-VaultName <String>]
@@ -228,7 +233,7 @@ Must be a valid 40-character hexadecimal string.
 
 ```yaml
 Type: String
-Parameter Sets: (All)
+Parameter Sets: CreateNewApp, UseExistingApp
 Aliases:
 
 Required: False
@@ -245,7 +250,7 @@ Default is 'NonExportable'.
 
 ```yaml
 Type: String
-Parameter Sets: (All)
+Parameter Sets: CreateNewApp, UseExistingApp
 Aliases:
 
 Required: False
@@ -261,7 +266,7 @@ Otherwise, use the default 'GraphEmailAppLocalStore'.
 
 ```yaml
 Type: String
-Parameter Sets: (All)
+Parameter Sets: CreateNewApp, UseExistingApp
 Aliases:
 
 Required: False
@@ -276,7 +281,7 @@ If specified, overwrite the vault secret if it already exists.
 
 ```yaml
 Type: SwitchParameter
-Parameter Sets: (All)
+Parameter Sets: CreateNewApp, UseExistingApp
 Aliases:
 
 Required: False
@@ -291,7 +296,7 @@ If specified, return the parameter splat for use in other functions.
 
 ```yaml
 Type: SwitchParameter
-Parameter Sets: (All)
+Parameter Sets: CreateNewApp, UseExistingApp
 Aliases:
 
 Required: False
@@ -306,7 +311,7 @@ Switch to add session domain suffix to the app name.
 
 ```yaml
 Type: SwitchParameter
-Parameter Sets: (All)
+Parameter Sets: CreateNewApp, UseExistingApp
 Aliases:
 
 Required: False
@@ -321,7 +326,7 @@ If specified, log the output to the console.
 
 ```yaml
 Type: String
-Parameter Sets: (All)
+Parameter Sets: CreateNewApp, UseExistingApp
 Aliases:
 
 Required: False

docs/index.html

@@ -45,6 +45,9 @@ function Connect-TkMsService {
         [Switch]
         $ExchangeOnline
     )
+    # Used Cmdlets
+    # Get-MgUser, Get-MgContext, Get-MgOrganization, Remove-MgContext, Connect-MgGraph, Disconnect-ExchangeOnline, Connect-ExchangeOnline
+
     # Begin Logging
     if (-not $script:LogString) {
         Write-AuditLog -Start
@@ -160,5 +163,8 @@ function Connect-TkMsService {
             }
         }
     }
+    else {
+        Write-AuditLog 'No service specified for connection.'
+    }
     Write-AuditLog -EndFunction
 }