Merge remote-tracking branch 'origin/main' into feature/new-menus

Author: CosimoTiger

pom.xml

@@ -47,7 +47,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-javadoc-plugin</artifactId>
-                <version>3.11.1</version>
+                <version>3.11.2</version>
                 <configuration>
                     <doclint>all,-missing</doclint>
                 </configuration>
@@ -101,7 +101,7 @@
         <dependency>
             <groupId>org.junit.jupiter</groupId>
             <artifactId>junit-jupiter-engine</artifactId>
-            <version>5.11.3</version>
+            <version>5.11.4</version>
             <scope>test</scope>
         </dependency>
         <dependency>

src/main/java/com/cosimo/utilities/item/ItemBuilder.java

@@ -24,12 +24,14 @@
  * A proxy class (rather than a true builder) that wraps around an {@link ItemStack}, allowing easier, more fluent and
  * chained modifications of the item.
  */
+@SuppressWarnings("unused")
 public class ItemBuilder implements Cloneable {
 
     /**
      * Mutable {@link ItemStack}.
      */
     private final ItemStack itemStack;
+    private ItemMeta itemMeta;
 
     /**
      * Creates a new {@link ItemBuilder} from an item stored in a given configuration file's path or a default provided
@@ -132,6 +134,7 @@ public ItemBuilder(@NonNull Material material) {
      */
     public ItemBuilder(@NonNull ItemStack itemStack) {
         this.itemStack = itemStack;
+        this.itemMeta = itemStack.getItemMeta();
     }
 
     /**
@@ -246,7 +249,9 @@ public ItemBuilder loreAt(@Nullable String line, final int @NonNull ... indices)
      */
     @NonNull
     public ItemBuilder with(@NonNull Consumer<ItemStack> itemConsumer) {
-        itemConsumer.accept(this.itemStack);
+        itemConsumer.accept(this.build());
+        this.itemMeta = this.itemStack.getItemMeta();
+
         return this;
     }
 
@@ -474,7 +479,7 @@ public ItemBuilder clearLore() {
      */
     @NonNull
     public Optional<ItemMeta> getItemMeta() {
-        return Optional.ofNullable(this.itemStack.getItemMeta());
+        return Optional.ofNullable(this.itemMeta);
     }
 
     /**
@@ -503,6 +508,7 @@ public boolean isBreakable() {
      */
     @NonNull
     public ItemStack build() {
+        this.itemStack.setItemMeta(this.itemMeta);
         return this.itemStack;
     }
 
@@ -514,7 +520,7 @@ public ItemStack build() {
      */
     @NonNull
     public <E> Button<E> asButton() {
-        return Button.of(this.itemStack);
+        return Button.of(this.build());
     }
 
     /**
@@ -525,9 +531,10 @@ public <E> Button<E> asButton() {
      */
     @NonNull
     public <E> Button<E> asButton(E property) {
-        return Button.of(this.itemStack, property);
+        return Button.of(this.build(), property);
     }
 
+    @SuppressWarnings("MethodDoesntCallSuperMethod")
     @Override
     public ItemBuilder clone() {
         return new ItemBuilder(this.itemStack.clone());