fix(cli): only save history on successful run completion

Fixes bounty issue #1531

Previously, cortex run would create a rollout file immediately upon starting a session. If the session failed (e.g. due to an API error), this file would persist, polluting the history with failed attempts. This change ensures that if an error occurs during a new session, the rollout file is cleaned up before exiting.

Author: factorydroid

cortex-cli/src/run_cmd.rs

@@ -745,6 +745,21 @@ impl RunCli {
         let _ = session_task.await;
 
         if error_occurred {
+            // If it was a new session and an error occurred, we should probably clean up
+            // the history entry so it doesn't pollute the logs with failed runs.
+            if let SessionMode::New { .. } = session_mode {
+                let rollout_path =
+                    cortex_engine::rollout::get_rollout_path(&config.cortex_home, &session_id);
+                if rollout_path.exists() {
+                    if let Err(e) = std::fs::remove_file(&rollout_path) {
+                        if self.verbose {
+                            eprintln!("Failed to remove failed session history: {}", e);
+                        }
+                    } else if self.verbose {
+                        eprintln!("Removed failed session history: {}", session_id);
+                    }
+                }
+            }
             std::process::exit(1);
         }